Page MenuHomePhorge

Throw an error if we attempt to release a manually executed job.
ClosedPublic

Authored by mollekopf on Sep 9 2022, 10:01 AM.
Tags
None
Referenced Files
F11828337: D3821.id10925.diff
Sat, Apr 20, 8:56 PM
Unknown Object (File)
Wed, Apr 17, 9:42 AM
Unknown Object (File)
Sat, Apr 13, 10:55 AM
Unknown Object (File)
Thu, Mar 28, 5:12 PM
Unknown Object (File)
Tue, Mar 26, 8:35 AM
Unknown Object (File)
Mar 19 2024, 10:40 AM
Unknown Object (File)
Mar 13 2024, 11:01 PM
Unknown Object (File)
Mar 13 2024, 10:59 PM
Subscribers

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sep 9 2022, 10:02 AM
machniak subscribed.

This does not sound right. In your use-case we do release(60) which is not "failing silently" but waiting for domain to be set up and trying again.

This revision now requires changes to proceed.Sep 20 2022, 12:20 PM

I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.

Please, add an explanatory comment .

This revision is now accepted and ready to land.Sep 20 2022, 1:51 PM

Adjusted tests to expect the exception. All tests are passing.

This revision was automatically updated to reflect the committed changes.