Page MenuHomePhorge

A new artisan status:health command
ClosedPublic

Authored by mollekopf on Sep 1 2022, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 10:14 PM
Unknown Object (File)
Fri, Mar 22, 9:01 PM
Unknown Object (File)
Mar 9 2024, 12:36 PM
Unknown Object (File)
Mar 4 2024, 10:55 AM
Unknown Object (File)
Feb 25 2024, 1:32 PM
Unknown Object (File)
Jan 30 2024, 3:39 AM
Unknown Object (File)
Jan 24 2024, 2:18 PM
Unknown Object (File)
Jan 24 2024, 1:06 PM
Subscribers

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sep 1 2022, 4:41 PM

Just check if an exception is thrown for mollie

machniak subscribed.
machniak added inline comments.
src/app/Backends/LDAP.php
74

This if is kinda redundant. The method should work anyway. Also, just "validate" as a method name is maybe not the best name. How about "heathcheck" or "setupcheck"?

src/app/Backends/OpenExchangeRates.php
62

Spacing.

src/app/Console/Commands/Status/Health.php
15

A check for Redis cache could also be added, I guess.

148

In other commands {user} usually means email or ID. So, maybe support that, or rename to {email}?

src/app/Providers/Payment/Mollie.php
40

we prefer bool over boolean in phpdoc.

This revision now requires changes to proceed.Sep 20 2022, 12:48 PM

Addressed comments, added redis check.

machniak added inline comments.
src/app/Backends/OpenExchangeRates.php
60

Redundant spaces here and below.

src/app/Console/Commands/Status/Health.php
81

Hmm.. So, this command requires an email address of an existing user. That means that it can't be used with an empty database. I wonder whether it would make sense to make the email optional. We could still check IMAP by logging in as cyrus-admin.

This revision now requires changes to proceed.Sep 29 2022, 10:19 AM
mollekopf marked 6 inline comments as done.

Dropped the need for an email address, fixed spacing

mollekopf added inline comments.
src/app/Console/Commands/Status/Health.php
81

You're right, that's easy enough.

This revision is now accepted and ready to land.Sep 29 2022, 1:34 PM
This revision was automatically updated to reflect the committed changes.