Page MenuHomekolab.org

A new artisan status:health command
AcceptedPublic

Authored by mollekopf on Sep 1 2022, 4:34 PM.

Diff Detail

Repository
rK kolab
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 40205
Build 16286: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Sep 1 2022, 4:34 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sep 1 2022, 4:41 PM
mollekopf updated this revision to Diff 10856.Fri, Sep 9, 10:02 AM

Just check if an exception is thrown for mollie

machniak requested changes to this revision.Tue, Sep 20, 12:48 PM
machniak added a subscriber: machniak.
machniak added inline comments.
src/app/Backends/LDAP.php
74

This if is kinda redundant. The method should work anyway. Also, just "validate" as a method name is maybe not the best name. How about "heathcheck" or "setupcheck"?

src/app/Backends/OpenExchangeRates.php
62

Spacing.

src/app/Console/Commands/Status/Health.php
15

A check for Redis cache could also be added, I guess.

148

In other commands {user} usually means email or ID. So, maybe support that, or rename to {email}?

src/app/Providers/Payment/Mollie.php
40

we prefer bool over boolean in phpdoc.

This revision now requires changes to proceed.Tue, Sep 20, 12:48 PM
mollekopf updated this revision to Diff 10964.Thu, Sep 29, 9:36 AM

Addressed comments, added redis check.

machniak requested changes to this revision.Thu, Sep 29, 10:19 AM
machniak added inline comments.
src/app/Backends/OpenExchangeRates.php
60

Redundant spaces here and below.

src/app/Console/Commands/Status/Health.php
81

Hmm.. So, this command requires an email address of an existing user. That means that it can't be used with an empty database. I wonder whether it would make sense to make the email optional. We could still check IMAP by logging in as cyrus-admin.

This revision now requires changes to proceed.Thu, Sep 29, 10:19 AM
mollekopf updated this revision to Diff 10985.Thu, Sep 29, 1:15 PM
mollekopf marked 6 inline comments as done.

Dropped the need for an email address, fixed spacing

mollekopf marked an inline comment as done.Thu, Sep 29, 1:16 PM
mollekopf added inline comments.
src/app/Console/Commands/Status/Health.php
81

You're right, that's easy enough.

machniak accepted this revision.Thu, Sep 29, 1:34 PM
This revision is now accepted and ready to land.Thu, Sep 29, 1:34 PM