Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rK2099c114c142: A new artisan status:health command
rK617c9069857f: A new artisan status:health command
rKd2bf3de3376c: A new artisan status:health command
rK2a4d4a1d4338: A new artisan status:health command
rK076bdf72e231: A new artisan status:health command
rKbbe06e769ef5: A new artisan status:health command
rKd0c4d878b455: A new artisan status:health command
rK34497287c3f5: A new artisan status:health command
rK401d0beea9b2: A new artisan status:health command
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 40205 Build 16286: arc lint + arc unit
Event Timeline
| src/app/Backends/LDAP.php | ||
|---|---|---|
| 74 | This if is kinda redundant. The method should work anyway. Also, just "validate" as a method name is maybe not the best name. How about "heathcheck" or "setupcheck"? | |
| src/app/Backends/OpenExchangeRates.php | ||
| 62 | Spacing. | |
| src/app/Console/Commands/Status/Health.php | ||
| 15 | A check for Redis cache could also be added, I guess. | |
| 148 | In other commands {user} usually means email or ID. So, maybe support that, or rename to {email}? | |
| src/app/Providers/Payment/Mollie.php | ||
| 40 | we prefer bool over boolean in phpdoc. | |
| src/app/Backends/OpenExchangeRates.php | ||
|---|---|---|
| 60 | Redundant spaces here and below. | |
| src/app/Console/Commands/Status/Health.php | ||
| 81 | Hmm.. So, this command requires an email address of an existing user. That means that it can't be used with an empty database. I wonder whether it would make sense to make the email optional. We could still check IMAP by logging in as cyrus-admin. | |
| src/app/Console/Commands/Status/Health.php | ||
|---|---|---|
| 81 | You're right, that's easy enough. | |