Cleanup

Rebasing

1. Updating D3202: Added a patching mechanism

Fixup

phpcs fixes

phpcs fixes

Just like what we have for phpstan.

Fixed some phpstan complaints

Addressed comments

In D3196#38563, @machniak wrote:

Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:

interface StatusSuspendedInterface {
    const STATUS_SUSPENDED = 4;
    function isSuspended();
    function suspend();
    function unsuspend();
}

For now I prefer to not define interfaces and use my simple trait with the common status functionality.

In T6805#94630, @sicherha wrote:

Apparently I need to be added to the PyKolab Developers group to be able to land changes.

Script cleanup

Looks reasonable, maybe a webpackPrefetch: true could make sense to enable prefetching (might be enabled by default anyways though).

Perhaps drop the temporary table again, but looks reasonable otherwise.

I'm wondering whether there is a cleaner solution to relying on constants being defined in the class from the trait and the objectState function, both seems a bit magic. But since the object states do not mean the same thing between different objects, I can't think of a better solution either.

Thanks for the excellent work @sicherha!

I don't think the performance impact matters for the uses we have here.

This requires python >= 2.6, which is fine I think.

Rebased

Rebased

Rebased

Rebased

Rebased and run horizon in the background as well

Various changes