Page MenuHomePhorge
Feed Advanced Search

Jun 25 2019

machniak committed rRPK7ca7273ae96b: Fix "There are unsaved changes..." warning when terminating document session… (authored by machniak).
Fix "There are unsaved changes..." warning when terminating document session…
Jun 25 2019, 11:53 AM
machniak added a comment to T5160: webdav subfolders are not listed in chwala .

Could you confirm that this code works for you? I think it should work with SabreDAV 2.1 as well as any newer version.

$is_dir = !empty($props['{DAV:}resourcetype']) && count($props['{DAV:}resourcetype']->getValue()) > 0;
Jun 25 2019, 10:01 AM · Bug Reports
machniak added a comment to T5160: webdav subfolders are not listed in chwala .

I'm trying to tell you that your patch is not acceptable because it does not work with Kolab's WebDAV server (and maybe others). From the debug you provided I see that it might be a Sabre compat. issue. For me it is different:

Sabre\DAV\Property\ResourceType::__set_state(array(
   'resourceType' => array (
      0 => '{DAV:}collection',
    ),
))

What version of SabreDAV do you have installed?

Jun 25 2019, 9:22 AM · Bug Reports

Jun 24 2019

machniak added a comment to T5160: webdav subfolders are not listed in chwala .

However, I don't get it. Does that mean that OwnCloud returns set-but-empty DAV:resourcetype for folders? Could you provide sample owncloud response? Or, is commit d1342141be6 working for you?

Jun 24 2019, 3:01 PM · Bug Reports
machniak committed rCd1342141be6a: T5160: Fix bug where webdav driver didn't recognize folders/files properly (authored by machniak).
T5160: Fix bug where webdav driver didn't recognize folders/files properly
Jun 24 2019, 3:00 PM
machniak added a comment to T5160: webdav subfolders are not listed in chwala .

Proposed solution does not work with Kolab's WebDAV implementation (iRony). However, indeed standard says that files have no contenttype, so I'm going to fix it anyway.

Jun 24 2019, 2:53 PM · Bug Reports
machniak closed T1520: Show event description in the invitation Roundcube as Resolved.

Case 1 is already implemented.

Jun 24 2019, 1:59 PM · Roundcube, Architecture & Design
machniak closed T2459: Feature request: Allow viewing attachments in draft email for web application as Resolved.

It's part of Kolab 16.

Jun 24 2019, 1:56 PM · Roundcube
machniak committed rWAP35251088ee10: Log an error when SQL DSN is empty (authored by machniak).
Log an error when SQL DSN is empty
Jun 24 2019, 1:36 PM
machniak committed rWAP89b1896ae72f: Fix performance when validating multiple email addresses (Bifrost#T221026) (authored by machniak).
Fix performance when validating multiple email addresses (Bifrost#T221026)
Jun 24 2019, 12:01 PM

Jun 21 2019

machniak committed rC53e565eebd5d: Fix various issues with document Save action and WOPI (Bifrost#T220024) (authored by machniak).
Fix various issues with document Save action and WOPI (Bifrost#T220024)
Jun 21 2019, 12:27 PM
machniak committed rRPKb87333e0e29b: Files: Add missing "Saving..." label (authored by machniak).
Files: Add missing "Saving..." label
Jun 21 2019, 12:14 PM
machniak committed rCe1dc8919171e: Fix duplicated entries in document Download menu (authored by machniak).
Fix duplicated entries in document Download menu
Jun 21 2019, 10:21 AM
machniak committed rC74b68d9b770d: Fix file's last modification time format in WOPI response (authored by machniak).
Fix file's last modification time format in WOPI response
Jun 21 2019, 9:28 AM

Jun 20 2019

machniak committed rRPK8f8c6ab5ae60: Cleanup (authored by machniak).
Cleanup
Jun 20 2019, 2:53 PM
machniak committed rRPK098d25dd18f9: Elastic: Remove redundant styles (authored by machniak).
Elastic: Remove redundant styles
Jun 20 2019, 2:43 PM
machniak committed rC1a0c9648c7a1: Resolve user uid into name in sharing dialog (Bifrost#T216238) (authored by machniak).
Resolve user uid into name in sharing dialog (Bifrost#T216238)
Jun 20 2019, 11:34 AM
machniak committed rC50d90f2dc69e: Resolve user uid into name in sharing dialog (Bifrost#T216238) (authored by machniak).
Resolve user uid into name in sharing dialog (Bifrost#T216238)
Jun 20 2019, 11:33 AM
machniak committed rRPK2a1d9bb6b802: Files: Support display/title (instead of uid) in sharing form (authored by machniak).
Files: Support display/title (instead of uid) in sharing form
Jun 20 2019, 11:03 AM

Jun 19 2019

machniak committed rRPK22bfc61fbf41: Files: Add title text to truncated long folder names on folders list (authored by machniak).
Files: Add title text to truncated long folder names on folders list
Jun 19 2019, 1:18 PM
machniak committed rRPK15a38f87e046: Other user uid mapping for Chwala (Bifrost#T216238) (authored by machniak).
Other user uid mapping for Chwala (Bifrost#T216238)
Jun 19 2019, 1:00 PM
machniak committed rC289bea6e0a41: Add possibility to replace other user uid in folder path into name and vice… (authored by machniak).
Add possibility to replace other user uid in folder path into name and vice…
Jun 19 2019, 12:59 PM

Jun 18 2019

machniak closed T5444: Elastic: Support new-line char as a separator for pasted recipients - Not working as Resolved.

Fixed in be2e3f21541 [roundcubemail master].

Jun 18 2019, 4:26 PM · Bug Reports

Jun 14 2019

machniak committed rRPKde726e8cac85: Fix PHP Fatal error: Call to a member function get() on a non-object (authored by machniak).
Fix PHP Fatal error: Call to a member function get() on a non-object
Jun 14 2019, 2:22 PM

Jun 13 2019

machniak committed rRPKacd1740a2975: Replace other user folders uids with display name (Bifrost#T216238) (authored by machniak).
Replace other user folders uids with display name (Bifrost#T216238)
Jun 13 2019, 3:36 PM
machniak resigned from D761: Python smtpd library can now log debug information to pykolab log stream (debug level 9).

It looks good, but I don't really know it does what it looks like it should be doing ;)

Jun 13 2019, 11:51 AM

Jun 12 2019

machniak committed rRPK9da21b887c05: CS fixes, updates to composer.json files (authored by machniak).
CS fixes, updates to composer.json files
Jun 12 2019, 10:33 AM
machniak committed rRPKffd4de999869: Don't require jqueryui plugin, it's always enabled (authored by machniak).
Don't require jqueryui plugin, it's always enabled
Jun 12 2019, 10:33 AM

Jun 11 2019

machniak added a comment to T5414: Roundcube show calendar invitation with wrong date.

This version does not work with Roundcube 1.3.

Jun 11 2019, 7:42 PM · Roundcube Kolab Plugins , Bug Reports
machniak committed rWAP4dd0a08ffb79: Reset domains list page size when using it for internal checks (authored by machniak).
Reset domains list page size when using it for internal checks
Jun 11 2019, 10:45 AM
machniak added a comment to T5414: Roundcube show calendar invitation with wrong date.

You're using the outdated fork repo. The official one is here https://git.kolab.org/diffusion/RPK/repository/master/

Jun 11 2019, 9:08 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T5438: Wrong style calendar and tasklist.

these versions may require Roundcube from git-master.

Jun 11 2019, 9:03 AM · Bug Reports, Roundcube Kolab Plugins

Jun 7 2019

machniak committed rRPK3a13f5c3a7f3: Elastic: Move readonly (locker) icon on folder lists to the left (authored by machniak).
Elastic: Move readonly (locker) icon on folder lists to the left
Jun 7 2019, 2:33 PM
machniak closed T5414: Roundcube show calendar invitation with wrong date as Resolved.

Fixed.

Jun 7 2019, 12:26 PM · Roundcube Kolab Plugins , Bug Reports
machniak committed rPNLc65aaadc6749: Bump version number in composer.json (authored by machniak).
Bump version number in composer.json
Jun 7 2019, 11:58 AM

Jun 6 2019

machniak committed rRSCe86bfcc49628: Add missing labels to the env (authored by machniak).
Add missing labels to the env
Jun 6 2019, 1:17 PM

Jun 5 2019

machniak committed rRPK32b42e21eee1: Verify folder_classname() result before use (authored by machniak).
Verify folder_classname() result before use
Jun 5 2019, 4:02 PM
machniak closed T1170: Release Net_LDAP3-1.0.5 as Resolved.
Jun 5 2019, 9:52 AM · Release Managers, Net_LDAP3

Jun 2 2019

machniak committed rRPK6358d0ebfacc: Calendar: Fix white on white color for itip event preview (authored by machniak).
Calendar: Fix white on white color for itip event preview
Jun 2 2019, 9:44 AM

Jun 1 2019

machniak added a comment to T5239: Chwala: Folder limit should be configurable.

Please, be more clear. I don't have owncloud installation. Are you saying that it returns full folders hierarchy event if we ask for "1,noroot"? My understanding of owncloud and other dav servers was that they do (may) not support "infinity", but "1,noroot" should be supported. And this is what the rest of the code expects.

Jun 1 2019, 1:34 PM · Architecture & Design

May 31 2019

machniak committed rRPK98239ee764fe: Elastic: Fix position of counter badge on calendars list (authored by machniak).
Elastic: Fix position of counter badge on calendars list
May 31 2019, 2:01 PM
machniak committed rRPKd87235e20e22: Calendar: Limit number of event occurrences when "checking an itip event in… (authored by machniak).
Calendar: Limit number of event occurrences when "checking an itip event in…
May 31 2019, 1:56 PM
machniak committed rRPK8d04cec2f178: T5414: Fix Check Calendar button pointing to a wrong date (authored by machniak).
T5414: Fix Check Calendar button pointing to a wrong date
May 31 2019, 1:56 PM
machniak reopened T5414: Roundcube show calendar invitation with wrong date as "Open".

I'm reopening this as there are more related issues. E.g. the Check Calendar button points to the wrong date.

May 31 2019, 11:56 AM · Roundcube Kolab Plugins , Bug Reports
machniak closed T5414: Roundcube show calendar invitation with wrong date as Resolved.

This was hard to track, but fixed.

May 31 2019, 11:22 AM · Roundcube Kolab Plugins , Bug Reports
machniak committed rRPK2f75ab5b39dc: T5414: Fix wrong all-day event date in invitation box (authored by machniak).
T5414: Fix wrong all-day event date in invitation box
May 31 2019, 11:22 AM
machniak added a comment to T5375: stopping wallace leaves a process behind, restart fails.

No such issue on CentOS with wallace-0.8.11-7.1.el7.kolab_16.

May 31 2019, 7:59 AM · PyKolab, Bug Reports

May 30 2019

machniak closed T4584: Not possible to drag and drop an event on touch screen as Resolved.

This is working out of the box, but requires long-press. After a long press you can move the event. After a long press event also a handle to resize the event appears, so you can also resize the event.

May 30 2019, 2:24 PM · Roundcube Kolab Plugins , UX Seminar WS17
machniak closed T5229: inconsistency between android and iOS when scrolling down as Wontfix.

I don't think we can control that with current design. For me scrolling in the dialog is consistent. Problems start when a virtual keyboard appears.

May 30 2019, 2:22 PM · Roundcube Kolab Plugins , Bug Reports, UX Seminar WS17

May 29 2019

machniak committed rPd9c2a876f852: Merge branch 'master' of ssh://git.kolab.org/diffusion/P/pykolab (authored by machniak).
Merge branch 'master' of ssh://git.kolab.org/diffusion/P/pykolab
May 29 2019, 1:41 PM
machniak committed rP7f07f49c107f: Fix restarting apache2 service on Debian 9 (Bifrost#T163148) (authored by machniak).
Fix restarting apache2 service on Debian 9 (Bifrost#T163148)
May 29 2019, 1:41 PM
machniak closed T5408: HTML Composer on roundcube: Link insertion as Resolved.

Fixed in 668ca02c3f3d8 [roundcubemail master].

May 29 2019, 1:02 PM · Roundcube, Bug Reports
machniak lowered the priority of T5375: stopping wallace leaves a process behind, restart fails from Needs Triage to Normal.

Confirmed. If I then try to start wallace, I got:

2019-05-29 11:36:24,741 pykolab.wallace WARNING [10320] Could not bind to socket on port 10026 on bind address localhost
2019-05-29 11:36:24,741 pykolab.wallace WARNING [10320] Could not shut down socket
2019-05-29 11:36:25,743 pykolab.wallace WARNING [10320] Could not shut down socket
2019-05-29 11:36:26,745 pykolab.wallace WARNING [10320] Could not shut down socket
2019-05-29 11:36:27,747 pykolab.wallace WARNING [10320] Could not shut down socket
2019-05-29 11:36:28,750 pykolab.wallace WARNING [10320] Could not shut down socket
...

and

# ps ax | grep wallace
 3595 ?        S      0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
10320 ?        Sl     0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
10321 ?        S      0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
10322 ?        S      0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
10323 ?        S      0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
10324 ?        S      0:00 /usr/bin/python /usr/sbin/wallaced -l warning --fork --user kolab
May 29 2019, 12:38 PM · PyKolab, Bug Reports
machniak lowered the priority of T5327: Apostrophe in employee name causes LDAP crash from Needs Triage to Normal.
May 29 2019, 12:27 PM · PyKolab, Bug Reports
machniak closed T4554: Add new Calender is buggy as Resolved.

Fixed on kolabnow.com.

May 29 2019, 12:25 PM · UX Seminar WS17
machniak lowered the priority of T5333: Roundcube calendar issues from Needs Triage to Normal.

What is the user date and time format? You could also check what are the input arguments to parseDate() in line 169 of libcalendaring.js file. Just add console.log(this.datepicker_settings.dateFormat, date, this.datepicker_settings) a line before.

May 29 2019, 12:24 PM · Roundcube Kolab Plugins , Bug Reports
machniak lowered the priority of T5351: Dependency broken in package kolab-webclient for debian 8 (jessie) ! (php-pspell) from Needs Triage to Normal.

I didn't check that on Debian 8, but a few notes:

  1. It's not an issue on Debian 9 indeed.
  2. Roundcube will not fallback to any other method if it is configured to use pspell.
May 29 2019, 12:18 PM · Jessie, Kolab 16, Bug Reports
machniak lowered the priority of T5414: Roundcube show calendar invitation with wrong date from Needs Triage to Normal.

I think I saw this before, but never had time to work on this. Probably the date is handled as date-time and converted to user timezone, but should not for all-day events.

May 29 2019, 12:01 PM · Roundcube Kolab Plugins , Bug Reports
machniak lowered the priority of T5408: HTML Composer on roundcube: Link insertion from Needs Triage to Normal.

I confirm. This is for the Kolab skin based on Larry. Looks like it is caused by some style in Larry. The responsive skin has no such issue.

May 29 2019, 11:57 AM · Roundcube, Bug Reports
machniak committed rP1bf9df4c94e7: Use UTF8 charset on smtp_access_policy tables (Bifrost#T162941) (authored by machniak).
Use UTF8 charset on smtp_access_policy tables (Bifrost#T162941)
May 29 2019, 11:46 AM

May 28 2019

machniak committed rP5615f05304e5: Make sure main.cf exists before executing postmap (authored by machniak).
Make sure main.cf exists before executing postmap
May 28 2019, 3:38 PM
machniak committed rP36c3ab0dda8d: Fix Postfix TLS setup on Debian 9 (Bifrost#T163064) (authored by machniak).
Fix Postfix TLS setup on Debian 9 (Bifrost#T163064)
May 28 2019, 3:33 PM
machniak committed rP5a60e0c9e657: Fix restarting apache2 service on Debian 9 (Bifrost#T163148) (authored by machniak).
Fix restarting apache2 service on Debian 9 (Bifrost#T163148)
May 28 2019, 2:33 PM
machniak committed rRPKde8e018c4a2a: Fix kolab_alarms table schema for MariaDB (Bifrost#T163148) (authored by machniak).
Fix kolab_alarms table schema for MariaDB (Bifrost#T163148)
May 28 2019, 1:56 PM

May 27 2019

machniak committed rRPK915035e9bad5: Small code simplification (authored by machniak).
Small code simplification
May 27 2019, 3:12 PM
machniak added a comment to T5223: white space underneath "save" and "abort".

I don't see it on current beta.kolabnow.com withiPone SE iOS 12.1.4. Could you re-test and provide screenshot if it's still an issue?

May 27 2019, 11:59 AM · Roundcube Kolab Plugins , Bug Reports, UX Seminar WS17
machniak added a comment to T4983: When selecting a time you can't see them all.

I'm unable to reproduce on current beta.kolabnow.com with Chromim 73.0.3683.86.

May 27 2019, 11:48 AM · UX Seminar WS17

May 22 2019

machniak added a comment to T5402: Releases for standalone Roundcube.

The package was created by Thomas, but it looks he's not interested in working on this currently (or just have no time). Problem is that current calendar plugin version will probably not work with Roundcube 1.3. It also requires some manual packaging work for Elastic skin support. Also there are some known issues in the database driver noone have time to work on. From Kolab perspective we could spend that time better on other things. Maybe after the final 1.4.0 release I'll do something about the situation, but I can't promise anything.

May 22 2019, 9:47 AM · Roundcube Kolab Plugins
machniak closed T5399: Github and Gitlab mirrors as Resolved.

They are not maintained and they were never supported by Kolab.

May 22 2019, 9:36 AM · Roundcube Kolab Plugins
machniak closed T5381: Bugs reported via Gitlab as Resolved.

It is a "fork" that we do not manage.

May 22 2019, 9:32 AM · Roundcube Kolab Plugins
machniak committed rRPKd42ca55bfc1e: README update (authored by machniak).
README update
May 22 2019, 9:29 AM
machniak committed rRPK5e63cef9d564: Remove old TODO file (authored by machniak).
Remove old TODO file
May 22 2019, 9:20 AM

May 21 2019

machniak committed rRPK985d88fed2b8: Tasks: Fix folder edit/create issues (authored by machniak).
Tasks: Fix folder edit/create issues
May 21 2019, 11:48 AM

May 20 2019

machniak added a comment to T5239: Chwala: Folder limit should be configurable.

But you say it's a fix. So, what exactly are you trying to fix? I don't see a problem when I use chwala with Kolab storage connected using webdav driver.

May 20 2019, 3:45 PM · Architecture & Design

May 19 2019

machniak added a comment to T5239: Chwala: Folder limit should be configurable.

The whole point is to never use infinity. Now the procedure is recursive and we never fetch more than one level of the folder tree. Or are you saying that your webdav server does not support "1,noroot"?

May 19 2019, 7:41 AM · Architecture & Design

May 16 2019

machniak committed rRPK4136938a7ac8: Don't store invalid objects in cache (authored by machniak).
Don't store invalid objects in cache
May 16 2019, 10:36 AM
machniak committed rRPK5d560bf4cd77: Merge branch 'dev/perf' of ssh://git.kolab.org/diffusion/RPK/roundcubemail… (authored by machniak).
Merge branch 'dev/perf' of ssh://git.kolab.org/diffusion/RPK/roundcubemail…
May 16 2019, 8:52 AM

May 15 2019

machniak committed rRPKace036d6c8b0: Fix regression where tags were not available in Add a Note dialog… (authored by machniak).
Fix regression where tags were not available in Add a Note dialog…
May 15 2019, 4:23 PM

May 14 2019

machniak updated the diff for D714: LIST-EXTENDED/LIST-STATUS support.

Fix problem with "numeric" folders (Bifrost#T209392)

May 14 2019, 4:46 PM
machniak committed rRPKf848609ea1e4: Elastic: Improve event/task reminders (alarms) input (authored by machniak).
Elastic: Improve event/task reminders (alarms) input
May 14 2019, 11:05 AM
machniak committed rRPKf847df8e50b8: Fix broken resource details when kolabDescAttribute contains non-JSON-formatted… (authored by machniak).
Fix broken resource details when kolabDescAttribute contains non-JSON-formatted…
May 14 2019, 9:52 AM

May 13 2019

machniak committed rWAP28916f61deba: Update Hosted page with the new skin (authored by machniak).
Update Hosted page with the new skin
May 13 2019, 10:08 AM
machniak committed rWAPcde009921471: Fix error after jQuery update (authored by machniak).
Fix error after jQuery update
May 13 2019, 10:08 AM

May 10 2019

machniak committed rWAP1ad22e15c181: Skip form initialization if there's no id attribute (authored by machniak).
Skip form initialization if there's no id attribute
May 10 2019, 2:25 PM
machniak committed rWAP648e537423e9: Update to jQuery-3.4.1 (authored by machniak).
Update to jQuery-3.4.1
May 10 2019, 1:42 PM
machniak committed rWAP1995649953b5: New skin (authored by machniak).
New skin
May 10 2019, 1:42 PM
machniak committed rWAP0f51ea19380e: Remove kolabsys and minimal skins (authored by machniak).
Remove kolabsys and minimal skins
May 10 2019, 1:42 PM

May 7 2019

machniak committed rPNL4dbc8c189d7c: Use "native" vlv searching on PHP >= 7.3.5 (Bifrost#T193325) (authored by machniak).
Use "native" vlv searching on PHP >= 7.3.5 (Bifrost#T193325)
May 7 2019, 12:18 PM
machniak committed rP8b48619c0482: Fix enabling dirsrv service on Ubuntu (Bifrost#T200782) (authored by machniak).
Fix enabling dirsrv service on Ubuntu (Bifrost#T200782)
May 7 2019, 10:55 AM
machniak committed rRPK7d6e1fd78742: Calendar: Fix broken UI when using unsupported (old) view type 'table'… (authored by machniak).
Calendar: Fix broken UI when using unsupported (old) view type 'table'…
May 7 2019, 10:27 AM
machniak committed rI66a2d09850ad: Prevent from setting calendar name to folder's uid (Bifrost#T205762) (authored by machniak).
Prevent from setting calendar name to folder's uid (Bifrost#T205762)
May 7 2019, 10:12 AM

May 6 2019

machniak committed rSd867f6f5c5d7: Check if kolab_auth class exist before using it (authored by machniak).
Check if kolab_auth class exist before using it
May 6 2019, 12:56 PM
machniak committed rRPK464b49ee3497: Elastic: Fix various regressions (authored by machniak).
Elastic: Fix various regressions
May 6 2019, 10:57 AM
machniak committed rRPKb81e4798d091: Elastic: Unset 'rename' icon, use the one from Elastic core (authored by machniak).
Elastic: Unset 'rename' icon, use the one from Elastic core
May 6 2019, 9:08 AM
machniak committed rRPK290adfbbb118: Merge branch 'dev/elastic' (authored by machniak).
Merge branch 'dev/elastic'
May 6 2019, 9:08 AM

May 2 2019

machniak committed rRPKfb72e36fa418: Small phpdoc fixes (authored by machniak).
Small phpdoc fixes
May 2 2019, 12:38 PM
machniak committed rIaf758674b05c: Fix typo in method name, CS fixes (authored by machniak).
Fix typo in method name, CS fixes
May 2 2019, 12:21 PM

Apr 29 2019

machniak committed rRPK02637611ed6d: Fix various issues caused by caching outdate properties (authored by machniak).
Fix various issues caused by caching outdate properties
Apr 29 2019, 3:45 PM
machniak committed rRPKe648167c38f5: Add posibility to remove pending/declined invitation events (Bifrost#T203431) (authored by machniak).
Add posibility to remove pending/declined invitation events (Bifrost#T203431)
Apr 29 2019, 12:40 PM

Apr 26 2019

machniak committed rRPKff7f8f76d32b: Unset 'rsvp' flag when changing attendee status (authored by machniak).
Unset 'rsvp' flag when changing attendee status
Apr 26 2019, 5:15 PM