Page MenuHomePhorge
Feed Search

Jan 11 2022

mollekopf requested review of D3280: roundcube config changes.
Jan 11 2022, 11:07 PM
mollekopf requested review of D3277: Ignore the inetuserstatus for now.
Jan 11 2022, 11:07 PM
mollekopf requested review of D3274: Enable debugging for wallace as well..
Jan 11 2022, 11:07 PM
mollekopf requested review of D3271: Adjust the base dns for calendar.inc.php as well..
Jan 11 2022, 11:07 PM
mollekopf requested review of D3268: Set all require environment variables for the kolab container.
Jan 11 2022, 11:07 PM
mollekopf updated the diff for D3202: Added a patching mechanism .
  1. Updating D3202: Added a patching mechanism
Jan 11 2022, 11:07 PM
mollekopf updated the diff for D3026: Make kolab deployment ready to install on a linode.

Fixup

Jan 11 2022, 11:06 PM
mollekopf added a reviewer for D3262: Enable phpstan on resources and fix duplicate entry: Restricted Project.
Jan 11 2022, 9:37 PM
mollekopf requested review of D3262: Enable phpstan on resources and fix duplicate entry.
Jan 11 2022, 9:37 PM
mollekopf updated the diff for D2984: Proxy authorization for irony/syncroton.

phpcs fixes

Jan 11 2022, 9:22 PM
mollekopf updated the diff for D2978: Mediasoup based Kolab Meet.

phpcs fixes

Jan 11 2022, 9:21 PM
mollekopf added a reviewer for D3256: Added a phpcs script: Restricted Project.

Just like what we have for phpstan.

Jan 11 2022, 7:59 PM
mollekopf requested review of D3256: Added a phpcs script.
Jan 11 2022, 7:59 PM
mollekopf updated the diff for D3029: CompanionApp support.

Fixed some phpstan complaints

Jan 11 2022, 7:54 PM
mollekopf updated the diff for D2984: Proxy authorization for irony/syncroton.

Addressed comments

Jan 11 2022, 7:54 PM
mollekopf added inline comments to D2984: Proxy authorization for irony/syncroton.
Jan 11 2022, 7:53 PM
mollekopf accepted D3196: StatusPropertyTrait, and some more code de-duplication.
Jan 11 2022, 6:55 PM
mollekopf added a comment to D3196: StatusPropertyTrait, and some more code de-duplication.

Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:

interface StatusSuspendedInterface {
    const STATUS_SUSPENDED = 4;
    function isSuspended();
    function suspend();
    function unsuspend();
}

For now I prefer to not define interfaces and use my simple trait with the common status functionality.

Jan 11 2022, 6:54 PM
mollekopf committed rK9f64703aff04: utils: activesynccli, kolabendpointtester, generatemail.
Jan 11 2022, 6:47 PM
mollekopf closed D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 11 2022, 6:47 PM
mollekopf accepted D3250: [Python 3] Use new exception syntax, part 2.
Jan 11 2022, 7:31 AM

Jan 10 2022

mollekopf added a comment to T6805: Port pykolab to Python 3.

Apparently I need to be added to the PyKolab Developers group to be able to land changes.

Jan 10 2022, 6:12 PM · Architecture & Design
mollekopf added a member for PyKolab Developers: sicherha.
Jan 10 2022, 6:12 PM
mollekopf added inline comments to D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 10 2022, 11:23 AM
mollekopf updated the diff for D3211: utils: activesynccli, kolabendpointtester, generatemail.

Script cleanup

Jan 10 2022, 11:22 AM
mollekopf committed rK7b5c09f0a54f: Improve 09-enable-debugging.
Jan 10 2022, 11:13 AM
mollekopf committed rK65ff4d17e8f1: set the new invitation policy.
Jan 10 2022, 11:13 AM
mollekopf committed rKef3b5ed9cbf4: Configure the new webmail_url.
Jan 10 2022, 11:13 AM
mollekopf committed rKdff0dad77ec1: utils: activesynccli, kolabendpointtester, generatemail.
Jan 10 2022, 11:13 AM
mollekopf committed rKa038ec315193: Kolab development environment.
Jan 10 2022, 11:13 AM
mollekopf committed rKc1c8c229ef34: "production" meet server deployment.
Jan 10 2022, 11:13 AM
mollekopf committed rKa6772ff4d133: Enabled the kolab invitation calendars.
Jan 10 2022, 11:13 AM
mollekopf committed rK992d38b93db9: Resourcemanagement patches.
Jan 10 2022, 11:13 AM
mollekopf committed rK513cada1af44: Set the new invitation policy.
Jan 10 2022, 11:13 AM
mollekopf added a reverting change for rK0f46d2ae62ed: Use https for the roundcube backend: rK84dec6491252: Added a patching mechanism.
Jan 10 2022, 11:13 AM
mollekopf committed rK84dec6491252: Added a patching mechanism.
Jan 10 2022, 11:13 AM
mollekopf committed rK2282652967b0: Added cache to .gitignore.
Jan 10 2022, 11:13 AM
mollekopf committed rK323faa8f22a6: CompanionApp WIP.
Jan 10 2022, 11:13 AM
mollekopf committed rK61d8a29389dc: Healthchecks.
Jan 10 2022, 11:13 AM
mollekopf committed rK4681da7ce206: Make kolab deployment ready to install on a linode.
Jan 10 2022, 11:13 AM
mollekopf committed rK4070f33fc302: Proxy authorization for irony/syncroton.
Jan 10 2022, 11:13 AM
mollekopf committed rKf3d34412c14a: bin/quickstart.sh enhancements.
Jan 10 2022, 11:13 AM
mollekopf committed rK7e00d6e8997f: Mediasoup based Kolab Meet.
Jan 10 2022, 11:13 AM
mollekopf committed rKedcd78120cf2: Use password command.
Jan 10 2022, 11:13 AM
mollekopf committed rKe2c9a06fbc86: My pdf output is only 2696 bytes long.
Jan 10 2022, 11:13 AM
mollekopf accepted D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
Jan 10 2022, 10:19 AM
mollekopf added a comment to D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.

Looks reasonable, maybe a webpackPrefetch: true could make sense to enable prefetching (might be enabled by default anyways though).

Jan 10 2022, 10:19 AM
mollekopf accepted D3184: Kolab3 migration tool.

Perhaps drop the temporary table again, but looks reasonable otherwise.

Jan 10 2022, 10:08 AM
mollekopf requested changes to D3196: StatusPropertyTrait, and some more code de-duplication.
Jan 10 2022, 9:51 AM
mollekopf added a comment to D3196: StatusPropertyTrait, and some more code de-duplication.

I'm wondering whether there is a cleaner solution to relying on constants being defined in the class from the trait and the objectState function, both seems a bit magic. But since the object states do not mean the same thing between different objects, I can't think of a better solution either.

Jan 10 2022, 9:51 AM
mollekopf added a comment to T6805: Port pykolab to Python 3.

Thanks for the excellent work @sicherha!

Jan 10 2022, 9:15 AM · Architecture & Design
mollekopf accepted D3244: [Python 3] Use .items() instead of .iteritems().

I don't think the performance impact matters for the uses we have here.

Jan 10 2022, 9:14 AM
mollekopf accepted D3241: [Python 3] Get rid of .has_key().
Jan 10 2022, 9:07 AM
mollekopf accepted D3235: [Python 3] Remove unnecessary occurrences of .keys().
Jan 10 2022, 9:00 AM
mollekopf accepted D3232: [Python 3] Use new exception syntax.
Jan 10 2022, 8:56 AM
mollekopf accepted D3229: [Python 3] Use print() as function instead of statement.
Jan 10 2022, 8:53 AM
mollekopf accepted D3226: [Python 3] Use 0o prefix for octal numbers.

This requires python >= 2.6, which is fine I think.

Jan 10 2022, 8:44 AM
mollekopf accepted D3223: [Python 3] Avoid use of 0 prefix for decimal literals.
Jan 10 2022, 8:38 AM

Jan 9 2022

mollekopf committed rK97b238141ae4: Improve 09-enable-debugging.
Jan 9 2022, 7:24 PM
mollekopf committed rKa5442f2b287b: set the new invitation policy.
Jan 9 2022, 7:24 PM
mollekopf committed rK4ddb4b1da906: Configure the new webmail_url.
Jan 9 2022, 7:24 PM
mollekopf committed rK8d38178ca50e: Kolab development environment.
Jan 9 2022, 7:24 PM
mollekopf committed rK101f7fba0926: utils: activesynccli, kolabendpointtester, generatemail.
Jan 9 2022, 7:24 PM
mollekopf committed rK175671b35e90: Enabled the kolab invitation calendars.
Jan 9 2022, 7:24 PM
mollekopf committed rK3fe8fa152654: "production" meet server deployment.
Jan 9 2022, 7:24 PM
mollekopf committed rK11af899f0764: Set the new invitation policy.
Jan 9 2022, 7:24 PM
mollekopf committed rK47ffd7cfcb5a: Resourcemanagement patches.
Jan 9 2022, 7:24 PM
mollekopf added a reverting change for rK0f46d2ae62ed: Use https for the roundcube backend: rKb9c268cd9e35: Added a patching mechanism.
Jan 9 2022, 7:24 PM
mollekopf committed rKb9c268cd9e35: Added a patching mechanism.
Jan 9 2022, 7:24 PM
mollekopf committed rKe445eb423179: Added cache to .gitignore.
Jan 9 2022, 7:24 PM
mollekopf committed rK71ff7f595cf0: CompanionApp WIP.
Jan 9 2022, 7:24 PM
mollekopf committed rKbf779ad9d0d2: Healthchecks.
Jan 9 2022, 7:24 PM
mollekopf committed rK73325057d86d: Proxy authorization for irony/syncroton.
Jan 9 2022, 7:24 PM
mollekopf committed rKd42c5990a0d5: Make kolab deployment ready to install on a linode.
Jan 9 2022, 7:24 PM
mollekopf committed rKe42e3c3a5245: bin/quickstart.sh enhancements.
Jan 9 2022, 7:24 PM
mollekopf committed rK1b2d96e7e0c5: Mediasoup based Kolab Meet.
Jan 9 2022, 7:24 PM
mollekopf committed rKa5e390ebacd1: Use password command.
Jan 9 2022, 7:24 PM
mollekopf committed rK77bc4629c16f: My pdf output is only 2696 bytes long.
Jan 9 2022, 7:24 PM

Jan 7 2022

mollekopf updated subscribers of D3032: Healthchecks.
Jan 7 2022, 4:07 PM
mollekopf updated subscribers of D3023: bin/quickstart.sh enhancements.
Jan 7 2022, 4:02 PM
mollekopf updated the diff for D3023: bin/quickstart.sh enhancements.

Rebased

Jan 7 2022, 3:58 PM
mollekopf updated subscribers of D2942: bin/quickstart.sh enhancements.
Jan 7 2022, 3:57 PM
mollekopf added a reviewer for D3211: utils: activesynccli, kolabendpointtester, generatemail: Restricted Project.
Jan 7 2022, 3:53 PM
mollekopf added a reviewer for D3208: Kolab development environment: Restricted Project.
Jan 7 2022, 3:52 PM
mollekopf requested review of D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 7 2022, 3:51 PM
mollekopf requested review of D3208: Kolab development environment.
Jan 7 2022, 3:51 PM
mollekopf requested review of D3205: "production" meet server deployment.
Jan 7 2022, 3:51 PM
mollekopf requested review of D3202: Added a patching mechanism .
Jan 7 2022, 3:50 PM
mollekopf added a reverting change for rK0f46d2ae62ed: Use https for the roundcube backend: D3202: Added a patching mechanism .
Jan 7 2022, 3:50 PM
mollekopf updated the diff for D3032: Healthchecks.

Rebased

Jan 7 2022, 3:50 PM
mollekopf updated the diff for D2984: Proxy authorization for irony/syncroton.

Rebased

Jan 7 2022, 3:50 PM
mollekopf updated the diff for D3026: Make kolab deployment ready to install on a linode.

Rebased

Jan 7 2022, 3:50 PM
mollekopf updated the diff for D3023: bin/quickstart.sh enhancements.

Rebased and run horizon in the background as well

Jan 7 2022, 3:50 PM
mollekopf updated the diff for D2978: Mediasoup based Kolab Meet.

Various changes

Jan 7 2022, 3:49 PM

Jan 6 2022

mollekopf added inline comments to D3184: Kolab3 migration tool.
Jan 6 2022, 1:19 PM
mollekopf committed rK8a50f346ec20: Run horizon async as well.
Jan 6 2022, 12:05 PM
mollekopf committed rK1d239807639a: Improve 09-enable-debugging.
Jan 6 2022, 12:05 PM
mollekopf committed rK899682939fe5: SSLNOVERIFY for kolabendpointtester.
Jan 6 2022, 12:05 PM
mollekopf committed rK36af5ee4d113: More endpoint tester checks.
Jan 6 2022, 12:05 PM
mollekopf committed rK975fb08ea85f: More utilities.
Jan 6 2022, 12:05 PM