Moved the token validation to findAndAuthenticate, so we can skip mfa when a token has been validated.

After another look I think we might be doing something wrong here. A valid token should disable/skip 2FA use. Current User::findAndAuthenticate() will not skip 2FA if the password is a valid token.

Comment style

Now with an actual test

Addressed comments

• Fix comment
• ID generation for mail without Message-ID

• Incremental migration tests for Takeout
• Fixes in incremental migration across drivers

Placing this in User::validateCredentials() maybe is not a bad idea, but it creates some redundancy. See NGINXController::authorizeRequest() - AuthUtils::tokenValidate() now will be called twice. Also, test this new case in Unit/UserTest::testPasswordValidation().

• CS fixes
• Revert unneded change
• ANNOTATE base tag driver
• Improvements
• SQL driver fixes
• Small doc fix
• Fixes regarding syncroton API for tags
• Support saving task tags as categories
• Fix regression
• Regressions and cleanup

• Fix regression

Can be shipped after that adjustments IMO.

I think because of the latest change, this is now required:

• Fix regression

Patch merged.

It's a bit of a mess indeed.
I think it's not needed because default_port will be ignored if the port is part of the host string.
I'm unsure how to clean this up without breaking anything, so I'll just stick to doing what we do elsewhere.

Adjust to doing the same as iRony/syncroton

• Support saving task tags as categories

On the other hand we use default_port everywhere, and we probably should not. I'm just wondering, why that second part of this change is not needed in Syncroton and iRony, but is in Chwala.

Ha, I missed we use parse_host() in select_host(). So, that whole change in login() seems redundant.

This could be simplified by use of rcube_utils::parse_host() which is what we already do in Syncroton and iRony.

The imap user is being created from UserSeeder in the demo config. You have to remove that part. Also, maybe the command should be db:init or data:init, but just init is also fine.

Tested with ci/testctl deploy

It's all right. The extra headers could also have been passed through the DAV\Search "interface", I suppose.