Details
Details
- Reviewers
machniak - Group Reviewers
Chwala Developers - Commits
- rCb25cd48b4026: Adjust to roundcube 1.6
Diff Detail
Diff Detail
- Repository
- rC chwala
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This could be simplified by use of rcube_utils::parse_host() which is what we already do in Syncroton and iRony.
Comment Actions
Ha, I missed we use parse_host() in select_host(). So, that whole change in login() seems redundant.
Comment Actions
On the other hand we use default_port everywhere, and we probably should not. I'm just wondering, why that second part of this change is not needed in Syncroton and iRony, but is in Chwala.
Comment Actions
It's a bit of a mess indeed.
I think it's not needed because default_port will be ignored if the port is part of the host string.
I'm unsure how to clean this up without breaking anything, so I'll just stick to doing what we do elsewhere.