Page MenuHomePhorge

Adjust to roundcube 1.6
ClosedPublic

Authored by mollekopf on Dec 18 2024, 8:25 AM.
Tags
None
Referenced Files
F18246750: D5070.diff
Fri, Jan 24, 7:29 PM
Unknown Object (File)
Fri, Jan 24, 3:18 PM
Unknown Object (File)
Fri, Jan 24, 1:45 AM
Unknown Object (File)
Thu, Jan 23, 6:39 PM
Unknown Object (File)
Tue, Jan 14, 6:16 PM
Unknown Object (File)
Fri, Jan 10, 6:27 AM
Unknown Object (File)
Thu, Jan 9, 11:32 AM
Unknown Object (File)
Tue, Jan 7, 6:14 PM
Subscribers

Details

Diff Detail

Repository
rC chwala
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.

This could be simplified by use of rcube_utils::parse_host() which is what we already do in Syncroton and iRony.

Ha, I missed we use parse_host() in select_host(). So, that whole change in login() seems redundant.

On the other hand we use default_port everywhere, and we probably should not. I'm just wondering, why that second part of this change is not needed in Syncroton and iRony, but is in Chwala.

Adjust to doing the same as iRony/syncroton

It's a bit of a mess indeed.
I think it's not needed because default_port will be ignored if the port is part of the host string.
I'm unsure how to clean this up without breaking anything, so I'll just stick to doing what we do elsewhere.

This revision is now accepted and ready to land.Dec 19 2024, 8:32 AM
This revision was automatically updated to reflect the committed changes.