Page MenuHomePhorge
Feed Advanced Search

Aug 18 2021

machniak updated the diff for D2752: French localization.
  • Localize "/month"
Aug 18 2021, 3:59 PM
machniak requested review of D2752: French localization.
Aug 18 2021, 3:49 PM
machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 18 2021, 12:15 PM
machniak accepted D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:53 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:45 AM
machniak added inline comments to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:35 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:34 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.

Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.

Aug 18 2021, 8:00 AM

Aug 17 2021

machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 6:32 PM
machniak committed rK67e900314a1b: Merge branch 'master' into dev/kolabmeet (authored by machniak).
Merge branch 'master' into dev/kolabmeet
Aug 17 2021, 3:49 PM
machniak committed rK6cf47624770c: Basic PowerDNS functionality (authored by vanmeeuwen).
Basic PowerDNS functionality
Aug 17 2021, 3:23 PM
machniak closed D2722: Basic PowerDNS functionality.
Aug 17 2021, 3:23 PM
machniak committed rKd30fd0cfff6a: Refresh package-lock.json, fix problem with frappe-charts styles integration (authored by machniak).
Refresh package-lock.json, fix problem with frappe-charts styles integration
Aug 17 2021, 3:10 PM
machniak committed rKa384d26dbb7f: Fix linting issues, mostly indentation (authored by machniak).
Fix linting issues, mostly indentation
Aug 17 2021, 12:16 PM
machniak committed rK89a0ce5ab84f: Bootstrap v5 (authored by machniak).
Bootstrap v5
Aug 17 2021, 12:01 PM
machniak closed D2734: Bootstrap v5.
Aug 17 2021, 12:01 PM
machniak accepted D2722: Basic PowerDNS functionality.
Aug 17 2021, 12:00 PM
machniak updated the diff for D2734: Bootstrap v5.
  • Remove jQuery for realz
Aug 17 2021, 11:33 AM
machniak added a comment to D2722: Basic PowerDNS functionality.

One last issue. Other than that it looks good. I didn't test the docker part, I guess we'll need some intergration tests later.

Aug 17 2021, 11:15 AM
machniak requested review of D2734: Bootstrap v5.
Aug 17 2021, 11:01 AM
machniak added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 10:11 AM
machniak added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 9:38 AM
machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.

I miss tests for console commands. I get they are simple and CLI has the worse coverage, but still it shouldn't be that hard.

Aug 17 2021, 8:46 AM

Aug 16 2021

machniak added inline comments to D2722: Basic PowerDNS functionality.
Aug 16 2021, 4:31 PM
machniak requested changes to D2722: Basic PowerDNS functionality.

Minor comments just after the code review, no testing and closer look on it yet.

Aug 16 2021, 4:08 PM
machniak added inline comments to D2716: Add possibility to change system currency.
Aug 16 2021, 1:00 PM
machniak updated the diff for D2716: Add possibility to change system currency.
  • Support multi-currency in income calculation for stats
Aug 16 2021, 12:23 PM
machniak planned changes to D2716: Add possibility to change system currency.

I'm planning on updating this diff with a fix for stats (where the income chart should sum up eur and chf payments using conversion rates and present the results in chf).

Aug 16 2021, 10:24 AM
machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 16 2021, 10:18 AM

Aug 13 2021

machniak updated the diff for D2716: Add possibility to change system currency.
  • More tests
Aug 13 2021, 8:37 AM
machniak updated the summary of D2716: Add possibility to change system currency.
Aug 13 2021, 8:27 AM

Aug 12 2021

machniak updated the diff for D2716: Add possibility to change system currency.
  • Add tests, fix small bugs
  • Use wallet currency in bonus/penalty dialog
Aug 12 2021, 3:36 PM
machniak planned changes to D2716: Add possibility to change system currency.
Aug 12 2021, 2:03 PM
machniak requested review of D2716: Add possibility to change system currency.
Aug 12 2021, 11:59 AM

Aug 10 2021

machniak updated the diff for D2371: Degraded accounts.
  • Remove unintentionally recovered app/Console/Development/UserStatus.php
  • Cleanup
Aug 10 2021, 12:21 PM
machniak updated the diff for D2371: Degraded accounts.
  • Merge branch 'master' into dev/status-degraded
  • Fix regressions regarding tenants
  • Fix more regressions
  • Small cleanup
Aug 10 2021, 12:02 PM

Aug 9 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • "Move" pgp.enable to per-tenant settings
Aug 9 2021, 4:36 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Fix a test breaking other tests
Aug 9 2021, 2:52 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Merge branch 'master' into dev/encryption
Aug 9 2021, 12:35 PM
machniak committed rK49da450ef27c: Fix some flaky browser tests assertions (authored by machniak).
Fix some flaky browser tests assertions
Aug 9 2021, 11:22 AM
machniak committed rKb61bace3b004: Skip horizon test if it's not installed (authored by machniak).
Skip horizon test if it's not installed
Aug 9 2021, 10:57 AM
machniak committed rK51b0e87be933: Fix costsPerDay() test (authored by machniak).
Fix costsPerDay() test
Aug 9 2021, 10:44 AM

Aug 2 2021

machniak added a comment to D2686: Greylist alias test.

I think this is all right. Note that anything that uses setUpTest() is very slow. I'd prefer if we didn't use this method at all, or at least not in setUp() method on a file with many tests.

Aug 2 2021, 6:16 PM

Jul 31 2021

machniak committed rPNL9bcc57027a06: Fix PHP 8.1 compatibility where LDAP connection is not a resource, but an object (authored by machniak).
Fix PHP 8.1 compatibility where LDAP connection is not a resource, but an object
Jul 31 2021, 5:37 PM
machniak committed rPNL8c1b36bb9fa9: Fix PHP 8.1 deprecation warnings (authored by machniak).
Fix PHP 8.1 deprecation warnings
Jul 31 2021, 5:34 PM

Jul 30 2021

machniak committed rKdea894c6f30b: Fix some browser tests in mobile mode (authored by machniak).
Fix some browser tests in mobile mode
Jul 30 2021, 3:42 PM
machniak committed rK97429f370ebe: Refactored tenant:create command's code to fix strange phpstan errors (authored by machniak).
Refactored tenant:create command's code to fix strange phpstan errors
Jul 30 2021, 2:01 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Switch new keypair algorithms to RSA
  • Use Laravel's Storage functionality
  • Add exportPublicKey() use
  • Generate a keypair for new alias
  • Unregister keys on alias delete
  • Add forgotten file
  • Fix issues found by phpstan
Jul 30 2021, 1:26 PM
machniak committed rKcfe21edcc120: Update stylelint (authored by machniak).
Update stylelint
Jul 30 2021, 12:22 PM
machniak committed rKcd7b7bfa791c: Update more npm deps (authored by machniak).
Update more npm deps
Jul 30 2021, 12:16 PM
machniak committed rK1bddbe52d3c3: Update some npm deps (authored by machniak).
Update some npm deps
Jul 30 2021, 12:16 PM
machniak committed rK14543c757732: Fix one more test (authored by machniak).
Fix one more test
Jul 30 2021, 9:51 AM
machniak committed rK54dc4cddd144: Fix some tests dependency on APP_NAME (authored by machniak).
Fix some tests dependency on APP_NAME
Jul 30 2021, 9:44 AM
machniak committed rK96ee1e4826b9: Set MAIL_REPLYTO_ADDRESS in .env.example (authored by machniak).
Set MAIL_REPLYTO_ADDRESS in .env.example
Jul 30 2021, 9:24 AM
machniak committed rKb0d4d89a22a9: Fix regressions (authored by machniak).
Fix regressions
Jul 30 2021, 9:08 AM
machniak committed rKeca49d51185b: Fix "Could not scan for classes inside "database/factories"" (authored by machniak).
Fix "Could not scan for classes inside "database/factories""
Jul 30 2021, 8:13 AM

Jul 29 2021

machniak committed rRPKc99ac18b8940: Use ISO week numbers in both full-calendar and date picker (authored by machniak).
Use ISO week numbers in both full-calendar and date picker
Jul 29 2021, 2:34 PM
machniak updated the diff for D2623: Greylisting + SPF.
  • Remove redundant generatePassphrase()
  • Fix migration
  • Fix regression
  • Fix various bugs found by phpstan and test regressions
Jul 29 2021, 2:04 PM

Jul 28 2021

machniak updated the diff for D2659: Tenant settings.
  • Fix withObjectTenantContext macro
    • It's result should not depend on the current user role
    • It was throwing exceptions when working with an unauth user (e.g. /meet endpoints)
    • Fixed some tests
Jul 28 2021, 2:11 PM

Jul 22 2021

machniak committed rAC9386fe6e5fb6: Add an option to respond to mobilesync requests only (authored by machniak).
Add an option to respond to mobilesync requests only
Jul 22 2021, 3:39 PM
machniak committed rKb584482f2d8d: Fix body padding issue after deleting a user (authored by machniak).
Fix body padding issue after deleting a user
Jul 22 2021, 2:19 PM
machniak committed rK86b4731f2166: Fix call to undefined method App\Providers\Payment\Mollie::exchangeRate() (authored by machniak).
Fix call to undefined method App\Providers\Payment\Mollie::exchangeRate()
Jul 22 2021, 2:00 PM
machniak requested review of D2680: Meet: Audio volume control.
Jul 22 2021, 12:06 PM
machniak committed rK9fa729c67776: Fix missing localization label (authored by machniak).
Fix missing localization label
Jul 22 2021, 9:46 AM
machniak added a comment to T6610: style.css and files_api.js only http not https.

The kolab_files plugin has some configuration. You can set these to an absolute URLs.

// URL of kolab-chwala installation
$config['kolab_files_url'] = '/chwala/';
Jul 22 2021, 8:32 AM · Bug Reports
machniak added a comment to T6670: Deleted groups still appearing under Global Address Book.

The ldap group information is cached, by default for 10 minutes. Check ldap_cache and ldap_cache_ttl settings. You can disable the cache with $config['ldap_cache'] = null;.

Jul 22 2021, 8:30 AM · Roundcube

Jul 19 2021

machniak committed rAC2e81ac04b413: Set AutoDiscoverSMTPAddress to user login, and fallback to email, the same as… (authored by machniak).
Set AutoDiscoverSMTPAddress to user login, and fallback to email, the same as…
Jul 19 2021, 3:43 PM
machniak committed rAC9372ec6fc7a0: Merge branch 'master' of ssh://git.kolab.org/diffusion/AC/autoconf (authored by machniak).
Merge branch 'master' of ssh://git.kolab.org/diffusion/AC/autoconf
Jul 19 2021, 1:57 PM
machniak committed rACbade385c19e2: Return early on unsupported protocol (authored by machniak).
Return early on unsupported protocol
Jul 19 2021, 1:57 PM
machniak committed rAC9906f5974c08: Typo: ErrorCore -> ErrorCode (authored by machniak).
Typo: ErrorCore -> ErrorCode
Jul 19 2021, 10:26 AM
machniak committed rAC31b044adcd83: Fix JSON autodiscovery for requests with non-v1.0 syntax (authored by machniak).
Fix JSON autodiscovery for requests with non-v1.0 syntax
Jul 19 2021, 9:24 AM

Jul 16 2021

machniak accepted D2665: Log requests during testing.
Jul 16 2021, 11:18 AM

Jul 15 2021

machniak updated the diff for D2659: Tenant settings.
  • Add getSettings() method, and use it as a optimization tool
Jul 15 2021, 10:07 AM

Jul 13 2021

machniak requested review of D2659: Tenant settings.
Jul 13 2021, 11:04 AM

Jul 12 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Remove unused Packages controllers for admin and reseller API
  • Fix SKU controllers
  • Fix Wallet controllers
  • Fix Users controllers
  • /api/discounts -> /api/users/{id}/discounts as we need the user context for this
Jul 12 2021, 11:44 AM

Jul 9 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix Group and Domain controllers, use new helper checkTenant()
Jul 9 2021, 8:00 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix InvitationsController
Jul 9 2021, 4:46 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix reseller's GroupsController and tests for it
Jul 9 2021, 3:16 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix various places where tenant context wasn't applied when selecting a sku record
Jul 9 2021, 12:39 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix obvious test regressions and a bug in the signup controller
Jul 9 2021, 10:33 AM

Jul 7 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix browser tests
Jul 7 2021, 2:51 PM

Jul 2 2021

machniak committed rSfb6622841a94: Add option to disable TNEF decoding (activesync_tnef_blacklist) (authored by machniak).
Add option to disable TNEF decoding (activesync_tnef_blacklist)
Jul 2 2021, 3:02 PM
machniak committed rRPK945ac3605d4c: Fix 2FA logon with kolab_auth's "login as" feature (authored by machniak).
Fix 2FA logon with kolab_auth's "login as" feature
Jul 2 2021, 1:56 PM
machniak requested changes to D2653: Attempt to fix issues with acl setting when acl subject has upper case letters in LDAP..
Jul 2 2021, 11:20 AM
machniak committed rS8e98b9f2a9a8: Fix Windows to Olson timezone conversion for some timezones e.g. Asia/Tehran (authored by machniak).
Fix Windows to Olson timezone conversion for some timezones e.g. Asia/Tehran
Jul 2 2021, 10:45 AM
machniak committed rSa4204ab0f838: Made Timezone format Outlook compatible (authored by mollekopf).
Made Timezone format Outlook compatible
Jul 2 2021, 10:45 AM
machniak closed D2647: Made Timezone format Outlook compatible.
Jul 2 2021, 10:45 AM
machniak committed rSffbd6a2246af: Fix PHP8 warnings (authored by machniak).
Fix PHP8 warnings
Jul 2 2021, 8:42 AM
machniak committed rS0dbfe14ceeee: Support more recent PHPUnit versions (authored by machniak).
Support more recent PHPUnit versions
Jul 2 2021, 8:42 AM
machniak committed rSd267da5cdc08: Fix array and string offset access syntax with curly braces (authored by machniak).
Fix array and string offset access syntax with curly braces
Jul 2 2021, 8:42 AM

Jun 30 2021

machniak requested changes to D2635: Further changes to the reseller implementation.
[14:20:34] <alec> I'm getting quite a lot of failing tests: Errors: 20, Failures: 51, Skipped: 7, Incomplete: 14. just from --testsuite=Feature 
[14:20:34] <alec> I guess you might be running tests with a different APP_TENANT_ID or sth 
[14:20:54] <alec> I have APP_TENANT_ID=1 in .env 
[14:22:57] <alec> damn, and I've run it with production mollie key, there 4 new users created, can you remove them? 
[14:27:32] <alec> also APP_PASSPHRASE=simple123 is needed when seeding and running tests 
[14:41:48] <alec> for browser tests: Errors: 16, Failures: 8, Skipped: 14, Incomplete: 1. 
[14:43:14] <alec> this is what I expected, changing default set of entitlements/skus is breaking a lot of tests 
[14:46:14] <alec> also phpstan has a lot to say
Jun 30 2021, 2:47 PM
machniak committed rRPK83d7667aca7e: Add missing icon for "Login As" input in Elastic skin(s) (authored by machniak).
Add missing icon for "Login As" input in Elastic skin(s)
Jun 30 2021, 2:00 PM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 12:27 PM
machniak added inline comments to D2635: Further changes to the reseller implementation.
Jun 30 2021, 11:42 AM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 10:41 AM

Jun 25 2021

machniak requested review of D2629: Fix duplicate SKUs listed in the user form.
Jun 25 2021, 9:55 AM

Jun 23 2021

machniak abandoned D2434: User controls over greylisting on the individual user basis, and SPF whitelisting for domains.

This diff is obviously broken. I updated the branch and created a new diff in https://git.kolab.org/D2623, as I wasn't able to update this one (arc diff was failing).

Jun 23 2021, 12:37 PM
machniak requested review of D2623: Greylisting + SPF.
Jun 23 2021, 12:24 PM
machniak committed rK780cfcd00fc2: Add @group to some tests (authored by machniak).
Add @group to some tests
Jun 23 2021, 12:20 PM
machniak requested review of D2617: Add tenant:create command.
Jun 23 2021, 11:07 AM