Page MenuHomekolab.org

Greylist alias test
ClosedPublic

Authored by mollekopf on Aug 2 2021, 3:09 PM.

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Aug 2 2021, 3:09 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Aug 2 2021, 3:11 PM

There may be a cleaner solution than just adding the alias and the secondary domain to the testcasetrait, I'll leaves this for somebody with a better feeling of what fits best here.

I think this is all right. Note that anything that uses setUpTest() is very slow. I'd prefer if we didn't use this method at all, or at least not in setUp() method on a file with many tests.

src/tests/Feature/Stories/GreylistTest.php
7

This is not needed here.

mollekopf updated this revision to Diff 7657.Aug 3 2021, 4:58 PM

Removed unnecessary include

mollekopf marked an inline comment as done.Aug 3 2021, 5:03 PM
vanmeeuwen accepted this revision.Aug 17 2021, 10:20 AM
This revision is now accepted and ready to land.Aug 17 2021, 10:20 AM
This revision was automatically updated to reflect the committed changes.