Page MenuHomekolab.org

Attempt to fix issues with acl setting when acl subject has upper case letters in LDAP.
Needs RevisionPublic

Authored by adomaitis on Jul 2 2021, 11:05 AM.

Details

Summary

When user name has upper case letters in LDAP kolabd treats whose users as new and sets acls. That resets acls at every LDAP synchronization as LDAP user name is not the same as it ends up being set in IMAP.

Diff Detail

Repository
rP pykolab
Branch
kolabd_case_sensitivity
Lint
Lint SkippedExcuse: just
Unit
No Unit Test Coverage
Build Status
Buildable 35542
Build 13921: arc lint + arc unit

Event Timeline

adomaitis requested review of this revision.Jul 2 2021, 11:05 AM
adomaitis created this revision.
machniak requested changes to this revision.Jul 2 2021, 11:20 AM
machniak added a subscriber: machniak.
machniak added inline comments.
pykolab/imap/__init__.py
411

I would move lowercasing before for, so it's not done on every iteration.

431

I would move _folder initialization before try. Otherwise if that fails _folder might be unset. Probably not very likely scenario, but still.

900

Something's wrong with indentation here.

This revision now requires changes to proceed.Jul 2 2021, 11:20 AM