Page MenuHomePhorge
Differential D2653

Attempt to fix issues with acl setting when acl subject has upper case letters in LDAP.
Needs RevisionPublic
Actions

Authored by adomaitis on Jul 2 2021, 11:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:31 PM
Unknown Object (File)
Sun, Apr 21, 4:31 PM
Unknown Object (File)
Sat, Apr 20, 1:56 AM
Unknown Object (File)
Fri, Apr 19, 2:58 AM
Unknown Object (File)
Wed, Apr 17, 8:55 AM
Unknown Object (File)
Sat, Apr 13, 9:23 PM
Unknown Object (File)
Tue, Apr 9, 10:49 PM
Unknown Object (File)
Thu, Apr 4, 12:02 PM
View All 30 Files
Subscribers
machniak

Details

Reviewers
vanmeeuwen
machniak
Summary

When user name has upper case letters in LDAP kolabd treats whose users as new and sets acls. That resets acls at every LDAP synchronization as LDAP user name is not the same as it ends up being set in IMAP.

Diff Detail

Repository
rP pykolab
Branch
kolabd_case_sensitivity
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 35542
Build 13921: arc lint + arc unit

Event Timeline

adomaitis requested review of this revision.Jul 2 2021, 11:05 AM
adomaitis created this revision.
Harbormaster completed remote builds in B35542: Diff 7477.Jul 2 2021, 11:05 AM
machniak requested changes to this revision.Jul 2 2021, 11:20 AM
machniak subscribed.
machniak added inline comments.
pykolab/imap/__init__.py
411

I would move lowercasing before for, so it's not done on every iteration.

431

I would move _folder initialization before try. Otherwise if that fails _folder might be unset. Probably not very likely scenario, but still.

900

Something's wrong with indentation here.

This revision now requires changes to proceed.Jul 2 2021, 11:20 AM

Revision Contents
Changeset List

PathSize
pykolab/
imap/
34 lines

Diff 7477

View Options

pykolab/imap/__init__.py

Loading...