I think the username canonification is done by kolab_auth plugin. So, maybe some problem with loading plugins/configuration.

I haven't really looked into the shortlogin issue yet, but at least for individual requests authenticated requests worked for me.
AFAIR the feature uses the username_domain roundcube config option to complete the login name if there is no domain part.

Thanks for investigating this! I can confirm that D3980 solves the synchronisation issue with Kontact for me, but like @johndoe I still have to log in with my full email address. With a shortlogin, iRony does not find the associated principal.

Yes, your patch at https://git.kolab.org/D3980 works with latest irony and roundcubemail in Thunderbird again.

Thanks for the info.

My production system with "irony 0.4.6-1~kolab1 " and "roundcubemail 1:1.5.3-0~kolab2" (older one, not the newest) shows this when I force a calendar synchronisaton in Thunderbird.

According to tcpdump -s 0 -A 'tcp dst port 80' I'm indeed getting unauthenticated PROPFIND requests, but that can't work IMO, so I'm not sure what's going on.
If anybody could confirm that they also see unauthenticated requests, and confirm what they are seeing with the old iRony, that could help.

I'm trying to reproduce the thunderbird issue:

In T7097#98258, @sicherha wrote:

(Sorry about my tone in yesterday's last-night comment; I was a tad frustrated. I'd like to do what I can to help fix this as quickly as possible.)

(Sorry about my tone in yesterday's last-night comment; I was a tad frustrated. I'd like to do what I can to help fix this as quickly as possible.)

In T7097#98246, @sicherha wrote:

It looks like the workaround (logging into iRony with the full email address) works fine with DAVx5 (on Android) but doesn't work with Kontact or Thunderbird.

Sigh... I was originally hoping to use my holiday to get Debian 11 support up & running, but there are too many fires to put out right now.

This is really not good and will break things. Please always raise the version number.

Indeed. Rule #1 for packagers: whenever the contents of a package change, bump its release number.
In my day job we use aptly, which refuses to accept an identically named .deb file with different contents, but I'm not aware that OBS supports that kind of check.

It looks like the workaround (logging into iRony with the full email address) works fine with DAVx5 (on Android) but doesn't work with Kontact or Thunderbird.

In T7097#98177, @sicherha wrote:

Which version of the roundcubemail package is installed on your system? I have 1:1.5.3-0~kolab2 and the line numbers from your log don't match the code I see on my system.

I was able to reproduce the issue with autoload.php disappearing; it seems to be a problem in the upgrade paths of the packages involved but I haven't been able to pinpoint it yet.

Yes, calendar discovery works with full email address as login, but after choosing the desired calendars and pressing OK the chosen calendars are not activated.
Pressing the activate Button does not work.

I have found a workaround for my problem: log in with the full email address (e.g. firstname.lastname@example.org). It seems that logging in with the username only (e.g. firstname.lastname) is currently broken, but I haven't yet found out why.

This is from the system where iRony does not work with Thunderbird (I have 2 systems).

... and I can reproduce the calendar-discovery issue: no calendars are discoverable via CalDAV any more; trying to access an existing URL gives me HTTP 404. I shouldn't have upgraded yet. 🙄

Which version of the roundcubemail package is installed on your system? I have 1:1.5.3-0~kolab2 and the line numbers from your log don't match the code I see on my system.

@sicherha
After installing 0.4.6-7~kolab1 every time /usr/share/iRony/vendor/autoload.php vanishes and I need to "apt-get install --reinstall roundcubemail" to make the calendar 100% work in roundcubemail.
When autload.php is missing I can create appointments in roundcubemail but cannot change them... the time for example.

@sicherha
This error I get when using irony_0.4.6-1~kolab1, but discovery and adding calendars from Thunderbird works.

Do you have any helpful log entries, for example in /var/log/iRony/errors.log?

@sicherha
irony_0.4.6-7~kolab1 breaks calendar discovery with Thunderbird 102.6.1.
Restoring to irony_0.4.6-1~kolab1 makes discovery work again.

here is another message (/var/log/roundcubemail/error.log)

I wish all a happy new year ...

👂 No objections heard since yesterday; marking this as Resolved.

Awesome! Closing this issue then. Glad to have this sorted out so we can begin the new year with a working Kolab installation.

In T7097#98096, @sicherha wrote:

@raptor2101, does updating to irony_0.4.6-7~kolab1 fix the issue for you?

@raptor2101, does updating to irony_0.4.6-7~kolab1 fix the issue for you?

I assume this is related to T7097, so I'm closing this task as a duplicate.

Which version of the php-kolabformat package is installed on your system? I presume it's already >= 1.3.0.

It's possible that we face additional incompatibilities, we have unfortunately rather poor test-coverage on these components.
But we do need the update to get to php8 support eventually.

Thanks! Upgrading the code base is of course better than downgrading the dependencies. I was just unsure whether there are additional incompatibilities besides the children property being deprecated.

Thanks for clarifying! Unless somebody still has any objections, I believe we can close this issue.

I have now included the vobject compatibility fix and I'm not planning on downgrading the sabre dependencies again.
The updated iRony package is currently in Kolab:16:Testing, but I'm still fighting an obs issue that seems to somehow pull in the libkolabxml 1.3.0 update into Debian_10...

Just for clarification:

• On Debian 10 and Ubuntu 18.04 the php-kolabformat 1.3.0 update should indeed not be available
• With the 1.3.0 update the kolabformat.php file is expected to no longer exist, as it is not required by php and no longer generated in more recent swig variants.
• Kolab is not currently php 8 compatible (though we are working towards it).

Reopening because the compatibility issue between iRony and sabre/vobject needs to be addressed as well.

Does /var/log/iRony/errors.log contain any helpful information?

@mollekopf, @machniak: Could one of you please adjust buildroundcubemailtarball.sh, recreate the tarball and bump the packages? I cannot do it myself because I don't have access to ssh://git@git.kolab.org/source/roundcubemail-skin-elastic.git.

The offending change was made here in the file buildroundcubemailtarball.sh: https://obs.kolabsys.com/package/rdiff/Kolab:16/roundcubemail-selfcontained?rev=13

Wait, that means the roundcubemail package is bundling the wrong version of sabre/vobject. It should contain 3.5.3 but actually contains 4.x. What a mess...

After downgrading the kolabformat-packages as recommended here the following error comes up:

seems to be missing the file /usr/share/php/kolabformat.php

@sicherha: kolabformat.php is still there and downgrade

Issuing following command

sudo apt-get install php-kolabformat=1.2.1-0~kolab3 libkolabxml1v5=1.2.1-0~kolab3 python-kolabformat=1.2.1-0~kolab3

Downgrading those three packages fixed reading mail and calendar entries for me.

In T7109#97847, @sicherha wrote:

I want to fix this, but I need some information. First the skin issue:

I managed to fix using the web interface skin problem by adding a symlink

What symlink is missing?

Nope doesn't work either.

Thanks for the feedback, indeed it is a duplicate, I feel sorry not to have found it.

Ah right, you have to downgrade all of the following packages (they're built from the same source package):

• libkolabxml1v5
• php-kolabformat
• python-kolabformat

First: downgrade is not possible due to dependencies. To downgrade php-kolabformat, you have to downgrade libkolabxml1v5, wich leads to the fact, that apt wants to "uninstall" the "whole kolab". I've bypassed this by manually downloading the package from here and extract the file.

Turns out php-kolabformat_1.3.0-0~kolab1 shouldn't even be available on Ubuntu 18.04 and Debian 10 since the build has been disabled in OBS - but the packages resulting from a previous build were kept in place. I have wiped these stale & broken binaries from the repository.

I think I've found the root cause: it looks like php-kolabformat_1.3.0-0~kolab1 seems to be missing the file /usr/share/php/kolabformat.php, which was still present in php-kolabformat_1.2.1-0~kolab3.

The bug reporters refer to Ubuntu 18.04 and Debian 10, so that's PHP 7.2 and 7.3, respectively.

Are you using PHP8 or something? Anyway, the problem will be in Swig-generated kolabformat code, which I'm not an expert with.

@machniak, do you have an idea what's going wrong here regarding the object-creation errors? How come these new_*() functions are overloaded?

I want to fix this, but I need some information. First the skin issue:

I managed to fix using the web interface skin problem by adding a symlink

What symlink is missing?

A fixed version of the irony package is underway: https://obs.kolabsys.com/request/show/3105

I believe I've found the underlying issue: typed properties (i.e. class member variables) were not introduced until PHP 7.4.0.
Source: https://www.php.net/manual/en/language.oop5.properties.php

That did not work either:

Okay, next try (note the leading backslash):

protected \Sabre\CardDAV\Xml\Request\AddressBookQueryReport $query;

If that doesn't work either, let's just go back to omitting the type name.

It did not work:

Looks like commit https://git.kolab.org/rI59977da735b6892075fffc802e4b656d94d75cd2 is to blame.

This is the change at line 51 of LDAPDirectory.php that is working:

I removed the fix from earlier and created an absolute symlink and it still failed with this in the iRony error logs:

[28-Dec-2022 11:54:53 -0500]: PHP Error: syntax error, unexpected 'CardDAV' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) (error 500)
#0 /usr/share/roundcubemail/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('/usr/share/iRon...')
#1 [internal function]: Composer\Autoload\ClassLoader->loadClass('Kolab\\CardDAV\\L...')
#2 /usr/share/iRony/lib/Kolab/CardDAV/UserAddressBooks.php(74): spl_autoload_call('Kolab\\CardDAV\\L...')
#3 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAV/Collection.php(57): Kolab\CardDAV\UserAddressBooks->getChild('157b7b01597b3e7...')
#4 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAV/Tree.php(111): Sabre\DAV\Collection->childExists('157b7b01597b3e7...')
#5 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAVACL/Plugin.php(834): Sabre\DAV\Tree->nodeExists('addressbooks/er...')
#6 /usr/share/roundcubemail/vendor/sabre/event/lib/WildcardEmitterTrait.php(89): Sabre\DAVACL\Plugin->beforeMethod(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#7 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAV/Server.php(456): Sabre\DAV\Server->emit('beforeMethod:PR...', Array)
#8 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAV/Server.php(253): Sabre\DAV\Server->invokeMethod(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#9 /usr/share/roundcubemail/vendor/sabre/dav/lib/DAV/Server.php(321): Sabre\DAV\Server->start()
#10 /usr/share/iRony/public_html/index.php(194): Sabre\DAV\Server->exec()
#11 {main} in /usr/share/iRony/lib/Kolab/CardDAV/LDAPDirectory.php on line 52 (PROPFIND /iRony/addressbooks/user@domain.tld/157b7b01597b3e76/)