Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Jan 14 2025

mollekopf committed rK9404752c78c1: Lookup existing clients by id, not by name.
Jan 14 2025, 1:35 PM
mollekopf closed D5082: Authentication health check.
Jan 14 2025, 1:35 PM
mollekopf committed rK6eb7bb96d066: Authentication health check.
Jan 14 2025, 1:35 PM
mollekopf updated the diff for D5086: Lookup existing clients by id, not by name.

Lookup by id

Jan 14 2025, 1:07 PM
mollekopf added a reviewer for D5086: Lookup existing clients by id, not by name: Restricted Project.
Jan 14 2025, 12:59 PM
mollekopf requested review of D5086: Lookup existing clients by id, not by name.
Jan 14 2025, 12:58 PM
machniak closed D5080: Remove "Functional" tests.
Jan 14 2025, 12:17 PM
machniak committed rK1f3f5ae10c0e: Remove "Functional" tests.
Jan 14 2025, 12:17 PM
machniak committed rSafdb54cd4b6b: Add tests for ContentId and ContentLocation, add some comments.
Jan 14 2025, 11:25 AM
machniak closed D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Jan 14 2025, 11:25 AM
machniak committed rSc7752217f73e: more tests.
Jan 14 2025, 11:25 AM
machniak committed rSc191aaa311e0: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Jan 14 2025, 11:25 AM
machniak updated the diff for D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
  • Add tests for ContentId and ContentLocation, add some comments
Jan 14 2025, 11:22 AM
mollekopf accepted D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Jan 14 2025, 8:53 AM
mollekopf added inline comments to D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Jan 14 2025, 8:49 AM
machniak updated the diff for D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
  • more tests
Jan 14 2025, 8:28 AM
machniak requested review of D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Jan 14 2025, 8:16 AM

Jan 10 2025

machniak requested changes to D5082: Authentication health check.
Jan 10 2025, 1:34 PM
mollekopf accepted D5080: Remove "Functional" tests.
Jan 10 2025, 12:19 PM
mollekopf added a reviewer for D5082: Authentication health check: Restricted Project.
Jan 10 2025, 11:09 AM
mollekopf requested review of D5082: Authentication health check.
Jan 10 2025, 11:08 AM

Jan 9 2025

machniak closed D5078: Cleanup/de-duplicate password validation code.
Jan 9 2025, 12:35 PM
machniak committed rKcfe362d051c9: Cleanup/de-duplicate password validation code.
Jan 9 2025, 12:35 PM
machniak closed D5076: Google Takeout driver for DataMigrator.
Jan 9 2025, 12:35 PM
machniak committed rK3771b0e2172a: Google Takeout driver for DataMigrator.
Jan 9 2025, 12:35 PM

Jan 8 2025

mollekopf accepted D5078: Cleanup/de-duplicate password validation code.
Jan 8 2025, 9:03 PM
machniak committed rK81407f41a8c2: Fix Undefined array key "isPending".
Jan 8 2025, 2:00 PM
machniak requested review of D5080: Remove "Functional" tests.
Jan 8 2025, 1:38 PM
machniak requested review of D5078: Cleanup/de-duplicate password validation code.
Jan 8 2025, 12:30 PM

Jan 6 2025

machniak committed rS47fe3292cca0: Fix PHP warning in getFileReference().
Jan 6 2025, 1:03 PM
machniak committed rSfbf08af75fd7: Fix regressions, don't call gzinflate() on an uncompressed data.
Jan 6 2025, 12:55 PM
machniak committed rRPK12787ff4c220: Tags: Fix removing tags from messages list on tag delete from a mail preview….
Jan 6 2025, 12:00 PM
mollekopf closed D5074: Token validation when providing it as a password.
Jan 6 2025, 11:42 AM
mollekopf committed rK77ced2efb642: Token validation when providing it as a password.
Jan 6 2025, 11:42 AM
machniak committed rRPKb3e686c00a41: Fix PHP warning.
Jan 6 2025, 11:35 AM
machniak accepted D5074: Token validation when providing it as a password.
Jan 6 2025, 11:35 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Moved the token validation to findAndAuthenticate, so we can skip mfa when a token has been validated.

Jan 6 2025, 11:24 AM
machniak requested changes to D5074: Token validation when providing it as a password.

After another look I think we might be doing something wrong here. A valid token should disable/skip 2FA use. Current User::findAndAuthenticate() will not skip 2FA if the password is a valid token.

Jan 6 2025, 10:34 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Comment style

Jan 6 2025, 10:11 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Now with an actual test

Jan 6 2025, 10:10 AM
machniak requested changes to D5074: Token validation when providing it as a password.
Jan 6 2025, 9:27 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Addressed comments

Jan 6 2025, 8:35 AM

Jan 4 2025

joe1860 created T8412: Kolab4 New deployment fails with amavis/spamassasin.
Jan 4 2025, 7:55 AM · Bug Reports

Jan 3 2025

machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Fix comment
  • ID generation for mail without Message-ID
Jan 3 2025, 2:22 PM
machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Incremental migration tests for Takeout
  • Fixes in incremental migration across drivers
Jan 3 2025, 1:42 PM
machniak planned changes to D5076: Google Takeout driver for DataMigrator.
Jan 3 2025, 10:04 AM

Jan 2 2025

machniak committed rK43bc8633f9ac: Fix regression in EWS migrator.
Jan 2 2025, 12:21 PM
machniak requested review of D5076: Google Takeout driver for DataMigrator.
Jan 2 2025, 9:49 AM
machniak closed D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Jan 2 2025, 9:32 AM
machniak committed rKeff9d8487cee: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Jan 2 2025, 9:32 AM
machniak requested changes to D5074: Token validation when providing it as a password.

Placing this in User::validateCredentials() maybe is not a bad idea, but it creates some redundancy. See NGINXController::authorizeRequest() - AuthUtils::tokenValidate() now will be called twice. Also, test this new case in Unit/UserTest::testPasswordValidation().

Jan 2 2025, 7:56 AM

Jan 1 2025

mollekopf added a reviewer for D5074: Token validation when providing it as a password: Restricted Project.
Jan 1 2025, 11:02 PM
mollekopf requested review of D5074: Token validation when providing it as a password.
Jan 1 2025, 11:00 PM
mollekopf accepted D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Jan 1 2025, 10:02 AM

Dec 27 2024

machniak requested review of D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Dec 27 2024, 11:51 AM
mollekopf abandoned D5058: Always run the seeder when horizon starts.
Dec 27 2024, 10:33 AM

Dec 24 2024

mollekopf committed rK626ded3e691c: imapd.conf fixup.
Dec 24 2024, 2:05 PM
mollekopf committed rK5070e51b48fe: ci/testctl reset mailbox routine.
Dec 24 2024, 12:03 PM
mollekopf committed rKd3b5df5a4a43: Disable per_user_logging for testing.
Dec 24 2024, 12:03 PM
mollekopf committed rKf54029a5d1f0: Some annotation support for imapcli.
Dec 24 2024, 12:03 PM
mollekopf committed rKb6eb61d4b335: Disable messages_cache for roundcube.
Dec 24 2024, 12:03 PM
mollekopf committed rKdb4ffe33ee43: Fixed plugin updates from local source.
Dec 24 2024, 12:03 PM
mollekopf committed rKa13127b28c13: imapcli tag option.
Dec 24 2024, 12:03 PM
mollekopf committed rK57a8e40e5d68: Make caldavcli usable over http.
Dec 24 2024, 12:03 PM
mollekopf committed rKb18d701a9cee: ci/testctl improvements.
Dec 24 2024, 12:03 PM
mollekopf committed rKedf0dedf94c6: IMAP/RC config for tags via ANNOTATE.
Dec 24 2024, 12:03 PM
mollekopf committed rKc4a4a8978592: Correctly filter service accounts in resync command.
Dec 24 2024, 12:03 PM
mollekopf committed rK673c0a272fbe: IMAP: Allow tls 1.2/1.3 for now.
Dec 24 2024, 12:03 PM
mollekopf committed rKa743a7db34d0: Don't validate the username of service accounts.
Dec 24 2024, 12:03 PM
mollekopf committed rK121e270afade: Only allow modern tls ciphers.
Dec 24 2024, 12:03 PM
mollekopf committed rK17bb006a8fb4: Caldav search.
Dec 24 2024, 12:03 PM
mollekopf committed R113:de3d000b6f34: Reset internal cache in appropriate places to be on a safe side (authored by machniak).
Dec 24 2024, 10:22 AM
mollekopf committed R113:6c53df30b8d3: IMAP: Partial support for ANNOTATE-EXPERIMENT-1 extension (RFC 5257) (authored by machniak).
Dec 24 2024, 10:22 AM
machniak closed D5032: Kolab Tags SQL and ANNOTATE drivers.
Dec 24 2024, 10:00 AM
machniak committed rRPK21ead0149e85: Kolab Tags SQL and ANNOTATE drivers.
Dec 24 2024, 10:00 AM
machniak closed D5062: Kolab4 tags support.
Dec 24 2024, 8:01 AM
machniak committed rS01e090894d0a: Kolab4 tags support.
Dec 24 2024, 8:01 AM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • CS fixes
  • Revert unneded change
  • ANNOTATE base tag driver
  • Improvements
  • SQL driver fixes
  • Small doc fix
  • Fixes regarding syncroton API for tags
  • Support saving task tags as categories
  • Fix regression
  • Regressions and cleanup
Dec 24 2024, 7:50 AM
machniak updated the diff for D5062: Kolab4 tags support.
  • Fix regression
Dec 24 2024, 7:22 AM
mollekopf requested changes to D5032: Kolab Tags SQL and ANNOTATE drivers.
Dec 24 2024, 7:12 AM
mollekopf reopened D5032: Kolab Tags SQL and ANNOTATE drivers.
Dec 24 2024, 7:06 AM
mollekopf requested changes to D5062: Kolab4 tags support.

Can be shipped after that adjustments IMO.

Dec 24 2024, 7:02 AM
mollekopf added a comment to D5062: Kolab4 tags support.

I think because of the latest change, this is now required:

Dec 24 2024, 7:01 AM
mollekopf committed rRPK026feb6e3fdd: Fixed php8 warnings.
Dec 24 2024, 6:58 AM
mollekopf committed rRPK8fd23ed20534: sql_where fixup.
Dec 24 2024, 6:58 AM
mollekopf committed rRPKbe4865053273: Kolab Tags SQL and ANNOTATE drivers (authored by machniak).
Dec 24 2024, 6:58 AM
mollekopf committed rRPKd7c582bd07da: Fix search by tag.
Dec 24 2024, 6:58 AM
mollekopf closed D5032: Kolab Tags SQL and ANNOTATE drivers.
Dec 24 2024, 6:58 AM
mollekopf committed rRPKabbb3921e172: Kolab Tags SQL and ANNOTATE drivers (authored by machniak).
Dec 24 2024, 6:58 AM

Dec 23 2024

mollekopf committed rC4bdc587ba9f3: Fixup for previous commit.
Dec 23 2024, 2:48 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Fix regression
Dec 23 2024, 12:44 PM
machniak closed T8400: kolab-webadmin: Uncaught Exception: Serialization of 'LDAP\Connection' is not allowed as Resolved.

Patch merged.

Dec 23 2024, 8:44 AM · Bug Reports
machniak committed rWAP180a93bcd7d6: Handle nicely json_encode() error.
Dec 23 2024, 8:24 AM
machniak committed rWAP5c0dade786b7: T8400: PHP 8.2 compatibility - close LDAP connection when serializing.
Dec 23 2024, 8:12 AM

Dec 19 2024

machniak committed rKfaa06df38342: CS fixes (lines too long mostly).
Dec 19 2024, 2:10 PM
machniak closed D5038: UI: Prefer to display suspended over degraded status.
Dec 19 2024, 12:28 PM
machniak committed rK7a6165f2311e: UI: Prefer to display suspended over degraded status.
Dec 19 2024, 12:28 PM
machniak closed D5036: Don't allow Delete jobs on non-deleted objects.
Dec 19 2024, 12:28 PM
machniak committed rK969f657690da: Don't allow Delete jobs on non-deleted objects.
Dec 19 2024, 12:28 PM
mollekopf closed D5070: Adjust to roundcube 1.6.
Dec 19 2024, 8:28 AM
First
Prev
Next