Page MenuHomePhorge

Fix mail attachment duplicates, improve attachment Method and IsInline values
ClosedPublic

Authored by machniak on Jan 14 2025, 9:15 AM.
Tags
None
Referenced Files
F18531298: D5084.id14569.diff
Sun, Feb 16, 10:06 AM
Unknown Object (File)
Sat, Feb 15, 3:35 AM
Unknown Object (File)
Sat, Feb 8, 12:54 AM
Unknown Object (File)
Sat, Feb 8, 12:54 AM
Unknown Object (File)
Sat, Feb 8, 12:54 AM
Unknown Object (File)
Sat, Feb 8, 12:54 AM
Unknown Object (File)
Sat, Feb 8, 12:54 AM
Unknown Object (File)
Fri, Feb 7, 11:49 PM

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
lib/kolab_sync_data_email.php
525

Document that this is to filter out duplicates introduced by the above array_merge because part is in attachments and inline_parts. Otherwise I'd assume we're fixing broken messages, which doesn't seem to be the case.

536

Document that 5 means embedded eml message in a comment please.

This revision is now accepted and ready to land.Jan 14 2025, 9:53 AM
  • Add tests for ContentId and ContentLocation, add some comments