Differential D5084

Fix mail attachment duplicates, improve attachment Method and IsInline values
ClosedPublic
Actions

Authored by machniak on Jan 14 2025, 8:15 AM.

Project Tags

None

Referenced Files

	F117819167: D5084.1775290223.diff
	Fri, Apr 3, 8:10 AM

	F117819075: D5084.1775289929.diff
	Fri, Apr 3, 8:05 AM

Subscribers

Syncroton Developers

Details

Reviewers

Group Reviewers

Syncroton Developers

Commits

rSafdb54cd4b6b: Add tests for ContentId and ContentLocation, add some comments
rSc7752217f73e: more tests
rSc191aaa311e0: Fix mail attachment duplicates, improve attachment Method and IsInline values

Diff Detail

Repository

Branch

master

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 52594
Build 18648: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 14 2025, 8:15 AM

machniak created this revision.

Harbormaster completed remote builds in B52592: Diff 14566.Jan 14 2025, 8:16 AM

more tests

Harbormaster completed remote builds in B52594: Diff 14568.Jan 14 2025, 8:28 AM

mollekopf subscribed.Jan 14 2025, 8:49 AM

mollekopf added inline comments.

lib/kolab_sync_data_email.php
525	Document that this is to filter out duplicates introduced by the above array_merge because part is in attachments and inline_parts. Otherwise I'd assume we're fixing broken messages, which doesn't seem to be the case.
536	Document that 5 means embedded eml message in a comment please.

mollekopf accepted this revision.Jan 14 2025, 8:53 AM

This revision is now accepted and ready to land.Jan 14 2025, 8:53 AM

Add tests for ContentId and ContentLocation, add some comments

Harbormaster completed remote builds in B52596: Diff 14570.Jan 14 2025, 11:22 AM

Closed by commit rSc191aaa311e0: Fix mail attachment duplicates, improve attachment Method and IsInline values. · Explain WhyJan 14 2025, 11:25 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rSc191aaa311e0: Fix mail attachment duplicates, improve attachment Method and IsInline values.

machniak added a commit: rSc7752217f73e: more tests.

machniak added a commit: rSafdb54cd4b6b: Add tests for ContentId and ContentLocation, add some comments.

Revision Contents
Changeset List

Path

Size

lib/

kolab_sync_data_email.php

lines

tests/

Sync/

Sync/

lines

SyncTestCase.php

lines

src/

lines

Diff 14568

lib/kolab_sync_data_email.php

Loading...

tests/Sync/Sync/EmailTest.php

Loading...

tests/SyncTestCase.php

Loading...

tests/src/mail.sync2

Loading...