In D4950#61803, @machniak wrote:

I see that MoveItems has a global Status (that we do not use) and per-item Status. https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascmd/acae4033-b4f9-4f2a-8d83-51e097eb3b90

I thought that the common status codes can be used everywhere, but the documentation is not clear. https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascmd/95cb9d7c-d33d-4b94-9366-d59911c7a060

As for 110 (server error), it looks like in general it might not be the best default error state as it means "the device SHOULD NOT retry later.". 111 (ServerErrorRetryLater) might be better for most generic error cases.

Addressed comments

Fixed the undefined $clientModifications

This works for the INBOX case I'm looking at, but it shows large differences on a Trash folder. I'm not sure if we also have to take syncroton_synckey.pendingdata into account (that's null in my case though), and maybe other things?

Fixup

This is just a refactoring and shouldn't change the behaviour.

Can you add to the commit message/description *why* you're changing this?