Page MenuHomePhorge
Feed Search

Apr 21 2022

machniak closed D3496: Update npm dependencies (for beta-release).

Merged into the beta-release branch.

Apr 21 2022, 8:22 AM
machniak committed rK8e0bd91a7219: Update npm dependencies (for beta-release).
Apr 21 2022, 8:01 AM

Apr 20 2022

machniak committed rK1dd9b9c44117: Fix file type detection, don't require it to be working in the existsing tests.
Apr 20 2022, 1:21 PM
machniak committed rKd3eb188ae136: Fix js/css linting issues.
Apr 20 2022, 12:16 PM
machniak updated the diff for D3496: Update npm dependencies (for beta-release).
  • Fix Bootstrap's regression - unwanted bold border on tables
Apr 20 2022, 12:10 PM
machniak committed rKec86a23ebcbd: Use of wss:// vs. ws:// protocol should depend on config.tls, not "local host".
Apr 20 2022, 11:33 AM
machniak committed rK28b3a7bb51bb: Fix more test regressions.
Apr 20 2022, 11:19 AM
machniak committed rKc71168f23b71: Fix various test regressions.
Apr 20 2022, 10:27 AM
machniak requested review of D3496: Update npm dependencies (for beta-release).
Apr 20 2022, 9:43 AM
machniak committed rK4716c805faf7: Fix phpstan errors.
Apr 20 2022, 8:58 AM
machniak committed rK7804304c25bd: fs:expunge command.
Apr 20 2022, 8:58 AM

Apr 19 2022

machniak committed rK29dccc0fe697: Don't use a static variable.
Apr 19 2022, 12:40 PM
machniak committed rKf70156095ff1: Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta….
Apr 19 2022, 12:27 PM
machniak retitled D3490: fs:expunge command from Remove use of unset mimetype property on files list
Apr 19 2022, 10:33 AM
machniak requested review of D3490: fs:expunge command.
Apr 19 2022, 10:25 AM

Apr 15 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Files API schema refactoring
Apr 15 2022, 11:15 AM

Apr 14 2022

machniak added a comment to D3463: [WIP] Files API.
item_id, key = 'share_<share-link-id1>', value = '{"john@kolab.org":"r"}' -- for a regular file

So, how do you search fast by the key if you don't know item_id (which is the index here)? Should we just add an index on the key column alone?

Apr 14 2022, 11:52 AM
machniak added a comment to D3463: [WIP] Files API.
  • If we move file name, size, mimetype to a separate table whenever we want to list/sort/search we have to make join(s) which will make it slow, and I'd say listing/searching by these three attributes is essential. A simplest listing needs to return at least the file size, name and mimetype, this makes this basic query much complicated/slower.

The assumption is that most if not all "lists" of "files" do not contain a column for the attributes such as size, mtime nor mimetype, let alone allow for "sorting by".

Apr 14 2022, 8:27 AM
machniak added a comment to D3463: [WIP] Files API.
  • If we move file name, size, mimetype to a separate table whenever we want to list/sort/search we have to make join(s) which will make it slow, and I'd say listing/searching by these three attributes is essential. A simplest listing needs to return at least the file size, name and mimetype, this makes this basic query much complicated/slower.
  • If we wanted to re-use the existing SettingsTrait the table name would have to be fs_file_settings, or you insist on "attributes"?
  • If we move permissions to settings/attributes then a "search by share id" query will be very slow, as it will be a non-indexed query on a big table. Therefore I'd keep the fs_permissions table as is.
  • App\Handlers\Beta\Files is there for a reason, it extends App\Handlers\Beta\Base class, but I guess I can move it to App\Handlers\Files. Note: that we still have Distlists, Resources, SharedFolders under \Beta, so it would not be consistent.
  • I understand fs_chunks needs a sequence column, but what's wrong with the incremented id? Ok, I guess with a generated id we can make it more performant, because we don't need to make an INSERT first. I.e. we'd generate chunk-id, save the chunk-file, then insert. Do you want to make the chunk id unique/primary key?
  • @mollekopf, the file_id + sequence is not unique enough, there might be more than one deleted record with the same file_id + sequence combination. Especially considering file updates and partial uploads. SO, I see a reason to have an extra id for the chunk filename.
Apr 14 2022, 7:09 AM

Apr 12 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Make max chunk size depend on SWOOLE_PACKAGE_MAX_LENGTH option
Apr 12 2022, 8:15 AM

Apr 11 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Store files in chunks (don't concatenate), some refactorings
Apr 11 2022, 1:53 PM

Apr 8 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Storage error handling
Apr 8 2022, 1:30 PM
machniak updated the diff for D3463: [WIP] Files API.
  • File upload/download via unauth API location
  • File update API
  • Files API schema/implementation refactor (slim-down)
Apr 8 2022, 11:57 AM

Mar 30 2022

machniak added a comment to D3463: [WIP] Files API.

Ok, so the current schema does not cover folders and sharing of folders. I have a simple solution for that:

--- a/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php
+++ b/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php
@@ -30,6 +30,7 @@ function (Blueprint $table) {
             function (Blueprint $table) {
                 $table->string('id', 36)->primary();
                 $table->string('library_id', 36);
+                $table->string('parent_id', 36)->nullable()->index(); // parent folder identifier
                 $table->string('name', 512);
                 $table->bigInteger('size')->unsigned()->default(0);
                 $table->string('mimetype');
Mar 30 2022, 10:04 AM

Mar 21 2022

machniak added a comment to D3463: [WIP] Files API.

@mollekopf I just added the sharing feature. What do you think about this now?

Mar 21 2022, 1:09 PM
machniak updated the diff for D3463: [WIP] Files API.
  • Add missing FilePermission model
Mar 21 2022, 1:08 PM
machniak updated the diff for D3463: [WIP] Files API.
  • Fix sharing
Mar 21 2022, 1:06 PM

Mar 15 2022

machniak requested review of D3463: [WIP] Files API.
Mar 15 2022, 11:12 AM

Mar 11 2022

machniak updated the diff for D3409: Laravel v9.
  • The daemonize option does not work
  • Min processes must be >0
  • Fixed swoole container
Mar 11 2022, 2:12 PM
machniak requested review of D3415: Create Roundcube user default identity (when creating the user).
Mar 11 2022, 1:33 PM

Mar 10 2022

machniak updated the diff for D3409: Laravel v9.
  • Fix swoole configuration
Mar 10 2022, 10:46 AM
machniak updated the diff for D3409: Laravel v9.
  • Update swoole container with php8/fedora35/swoole 4.8
  • Update the nginx containers to fedora 35 while we're at it
  • Daemonize octane, .env.local -> .env.local.example
  • Explicit octane config
Mar 10 2022, 9:20 AM

Mar 3 2022

machniak committed rKc31d0ffbc453: Use "your logo here" logos in the default theme.
Mar 3 2022, 11:11 AM

Feb 28 2022

machniak committed rKd99b8fa47e03: Add Swoole config section to config/octane.php.
Feb 28 2022, 11:15 AM
machniak updated the diff for D3409: Laravel v9.
  • Add Swoole config section to config/octane.php
Feb 28 2022, 10:59 AM

Feb 24 2022

machniak committed rK34bf24df4449: Update spomky-labs/otphp package for better PHP 8.1 support.
Feb 24 2022, 1:47 PM
machniak committed rK3e39addd4b91: Fix typo in phpdoc.
Feb 24 2022, 1:47 PM
machniak committed rKf48a28151395: Cleanup and use of new Eloquent features.
Feb 24 2022, 1:47 PM
machniak updated the diff for D3409: Laravel v9.
  • Update spomky-labs/otphp package for better PHP 8.1 support
Feb 24 2022, 1:46 PM
machniak abandoned D3397: Laravel v9.

Close in favour of D3409

Feb 24 2022, 10:51 AM
machniak updated the diff for D3409: Laravel v9.
  • Fix typo in phpdoc
Feb 24 2022, 10:51 AM
machniak requested review of D3409: Laravel v9.
Feb 24 2022, 10:47 AM
machniak updated the diff for D3397: Laravel v9.
  • Cleanup and use of new Eloquent features
Feb 24 2022, 9:05 AM

Feb 23 2022

machniak updated the diff for D3397: Laravel v9.
  • Fix some linting issues
  • More code improvements
  • Merge branch 'dev/laravel-v9' of ssh://git.kolab.org/source/kolab into dev/laravel-v9
Feb 23 2022, 12:17 PM
machniak committed rKba0ecf3e2b70: More code improvements.
Feb 23 2022, 11:58 AM
machniak committed rK9e5f09569f18: Merge branch 'dev/laravel-v9' of ssh://git.kolab.org/source/kolab into….
Feb 23 2022, 11:57 AM
machniak committed rKfae77c49eec0: Laravel v9.
Feb 23 2022, 11:57 AM
machniak committed rK200b00c8436f: Fix some linting issues.
Feb 23 2022, 11:57 AM
machniak requested review of D3397: Laravel v9.
Feb 23 2022, 10:57 AM
machniak committed rK25c201a30809: Cleanup Models' code regarding namespace use.
Feb 23 2022, 10:43 AM
machniak committed rK37a2b2f45bae: Remove routes/websockets.php.
Feb 23 2022, 10:43 AM
machniak committed rK8f38507bad02: Cleanup api routes.
Feb 23 2022, 10:43 AM
machniak committed rK5720f6160b28: Enable Octane, fix issues with shared state, fix date format issues.
Feb 23 2022, 10:43 AM
machniak committed rKd8d79772780e: Laravel v9: Fix openvidu integration.
Feb 23 2022, 10:43 AM
machniak committed rKe6f0720df71b: Laravel v9: retryAfter -> backoff.
Feb 23 2022, 10:42 AM
machniak committed rK165ea6e219b5: Get rid of LDAPUserProvider.
Feb 23 2022, 10:42 AM
machniak committed rKa1be449f6478: Redundant "use".
Feb 23 2022, 10:42 AM
machniak committed rK832bf555d728: Merge branch 'master' into dev/laravel-v9.
Feb 23 2022, 10:42 AM
machniak committed rK299950cdccbf: Complete Laravel v9 migration.
Feb 23 2022, 10:42 AM
machniak committed rK542acf82ddc3: Fix routing.
Feb 23 2022, 10:42 AM
machniak committed rK1626470679a7: Fix phpcs errors.
Feb 23 2022, 10:42 AM
machniak committed rKa93d5d8502e6: Laravel v9.
Feb 23 2022, 10:42 AM

Feb 22 2022

machniak committed rKedc1d90b1f09: Password link: Remind uses to press Submit, display error page on an….
Feb 22 2022, 9:29 AM
machniak closed D3385: Password link: Remind uses to press Submit, display error page on an expired/invalid code (in the link).
Feb 22 2022, 9:29 AM
machniak committed rK60f8cfed258b: Don't call userResponse() on failed login.
Feb 22 2022, 9:29 AM
machniak committed rKc76b08d854d8: Shared folder aliases.
Feb 22 2022, 9:29 AM
machniak closed D3325: Shared folder aliases.
Feb 22 2022, 9:28 AM
machniak closed D3337: Don't call userResponse() on failed login.
Feb 22 2022, 9:28 AM

Feb 21 2022

machniak committed rRPK9b712e73e8c9: Remove debug code.
Feb 21 2022, 9:04 AM
machniak committed rRPKe8da06886d92: Fix ldap search by a reasource owner.
Feb 21 2022, 9:04 AM

Feb 20 2022

machniak committed rRPK1507705333ff: Fix typo.
Feb 20 2022, 11:34 AM
machniak committed rRPK20c5e183f630: Fix error on inexisting ownedResources property.
Feb 20 2022, 11:13 AM

Feb 17 2022

machniak requested review of D3385: Password link: Remind uses to press Submit, display error page on an expired/invalid code (in the link).
Feb 17 2022, 11:55 AM
machniak updated the diff for D3379: Password expiration notification.
  • Add missing command description
  • Merge branch 'master' into dev/password-retention
Feb 17 2022, 9:16 AM

Feb 16 2022

machniak committed rKea6c41f6f030: Make 'min' and 'max' rules required in the password policy.
Feb 16 2022, 2:06 PM
machniak committed rKfaa4670862c0: Use stable version of Crypt_GPG.
Feb 16 2022, 1:22 PM
machniak committed rK945685d71605: Add missing space.
Feb 16 2022, 12:57 PM
machniak requested review of D3379: Password expiration notification.
Feb 16 2022, 12:54 PM
machniak committed rK679a6c49cc40: Password history.
Feb 16 2022, 11:27 AM
machniak closed D3361: Password history.
Feb 16 2022, 11:27 AM
machniak updated the diff for D3361: Password history.
  • Merge branch 'master' into dev/password-retention
  • Small code improvement
Feb 16 2022, 11:24 AM
machniak closed D3331: Close mobile menu on route change.
Feb 16 2022, 10:09 AM
machniak committed rK4c3597624e05: Close mobile menu on route change.
Feb 16 2022, 10:09 AM
machniak committed rK2fa4a831c8d7: Add button widgets.
Feb 16 2022, 10:08 AM
machniak closed D3373: Add button widgets.
Feb 16 2022, 10:07 AM

Feb 15 2022

machniak added inline comments to D3337: Don't call userResponse() on failed login.
Feb 15 2022, 5:05 PM
machniak added inline comments to D3325: Shared folder aliases.
Feb 15 2022, 4:54 PM
machniak requested changes to D3029: CompanionApp support.
Feb 15 2022, 11:56 AM
machniak committed rK94a200f66de5: Allow single character passwords on logon.
Feb 15 2022, 8:43 AM
machniak updated the diff for D3361: Password history.
  • Merge branch 'master' into dev/password-retention
  • Fix "last" policy validation
Feb 15 2022, 8:06 AM
machniak committed rKe1be01654c0e: Fix password policy validation.
Feb 15 2022, 7:57 AM

Feb 11 2022

machniak committed rK10cb1420c6b2: Move the default password policy to config/app.php.
Feb 11 2022, 12:40 PM

Feb 10 2022

machniak committed rK5aa210266729: Support shared folders of type 'file'.
Feb 10 2022, 2:41 PM
machniak updated the diff for D3361: Password history.
  • Don't store more old passwords than it's required by the account policy
Feb 10 2022, 1:06 PM

Feb 9 2022

machniak retitled D3373: Add button widgets from Don't use deprecated router-link's tag property
Feb 9 2022, 2:14 PM
machniak updated the diff for D3373: Add button widgets.
  • Add Btn widget
Feb 9 2022, 2:11 PM
machniak requested review of D3373: Add button widgets.
Feb 9 2022, 10:23 AM

Feb 8 2022

machniak committed rP4698e9a87066: Fix "RuntimeError: dictionary changed size during iteration" regression.
Feb 8 2022, 7:35 AM

Feb 7 2022

machniak updated the diff for D3361: Password history.
  • Small code improvement
Feb 7 2022, 11:25 AM
machniak updated the diff for D3361: Password history.
  • Small code refactoring
Feb 7 2022, 11:01 AM