./phpunit
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKc76b08d854d8: Shared folder aliases
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/app/Console/Commands/SharedFolder/AddAliasCommand.php | ||
---|---|---|
42 | Could another folder already occupy the same alias? | |
51 | Is there a usecase for this? Why would the validation fail and we still want to force create it? | |
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
68 | This allows to search for a user using an alias to a shared folder the user owns? | |
src/app/Resource.php | ||
34 | Why must this be the first after UuidIntKeyTrait? |
src/app/Console/Commands/SharedFolder/AddAliasCommand.php | ||
---|---|---|
42 | This check here is to prevent the same alias added twice to the folder. Answering the question... we apply the same rules as to users, see validateAlias() below. So, the same alias can be assigned to many folders in a custom domain. | |
51 | I'm not sure. It was copy-pasted from the existing user:add-alias command. | |
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
68 | I guess sometimes you might just have an email address of someone/something. So, it makes sense, but probably a rare case. | |
src/app/Resource.php | ||
34 | Both traits register "creating" event handler, and EmailPropertyTrait's handler needs the $id property to be set (which is set by the other trait). See bootEmailPropertyTrait(). |