Page MenuHomekolab.org

Password history
ClosedPublic

Authored by machniak on Feb 7 2022, 11:14 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK679a6c49cc40: Password history
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Feb 7 2022, 11:14 AM
machniak created this revision.
machniak updated this revision to Diff 9586.Feb 7 2022, 12:01 PM
  • Small code refactoring
machniak updated this revision to Diff 9592.Feb 7 2022, 12:25 PM
  • Small code improvement
machniak updated this revision to Diff 9616.Feb 10 2022, 2:06 PM
  • Don't store more old passwords than it's required by the account policy
Harbormaster completed remote builds in B38359: Diff 9616.
machniak updated this revision to Diff 9634.Feb 15 2022, 9:06 AM
  • Merge branch 'master' into dev/password-retention
  • Fix "last" policy validation
mollekopf added inline comments.
src/app/Observers/UserObserver.php
320

I would make this a >= just to be safe (even if we technically *shouldn't* ever get there).

src/app/Rules/Password.php
195
if (strlen($password) == 0) {
  return false;
}

would be easier to read imo.

Looks good otherwise.

machniak updated this revision to Diff 9649.Feb 16 2022, 12:24 PM
  • Merge branch 'master' into dev/password-retention
  • Small code improvement
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2022, 12:27 PM
Closed by commit rK679a6c49cc40: Password history (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.