Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK679a6c49cc40: Password history

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/password-retention

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38425
Build 15535: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 7 2022, 11:14 AM

machniak created this revision.

Harbormaster completed remote builds in B38302: Diff 9571.Feb 7 2022, 11:14 AM

Small code refactoring

Harbormaster completed remote builds in B38308: Diff 9586.Feb 7 2022, 12:01 PM

Small code improvement

Harbormaster completed remote builds in B38314: Diff 9592.Feb 7 2022, 12:25 PM

Don't store more old passwords than it's required by the account policy

Harbormaster completed remote builds in B38359: Diff 9616.Feb 10 2022, 2:06 PM

Harbormaster completed remote builds in B38359: Diff 9616.

Merge branch 'master' into dev/password-retention
Fix "last" policy validation

Harbormaster completed remote builds in B38395: Diff 9634.Feb 15 2022, 9:06 AM

mollekopf subscribed.Feb 15 2022, 5:40 PM

mollekopf added inline comments.

src/app/Observers/UserObserver.php
320	I would make this a >= just to be safe (even if we technically shouldn't ever get there).
src/app/Rules/Password.php
195	if (strlen($password) == 0) { return false; } would be easier to read imo.

Looks good otherwise.

Merge branch 'master' into dev/password-retention
Small code improvement

Harbormaster completed remote builds in B38425: Diff 9649.Feb 16 2022, 12:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2022, 12:27 PM

Closed by commit rK679a6c49cc40: Password history (authored by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

Password history
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9649

src/app/Http/Controllers/API/PasswordPolicyController.php

src/app/Observers/UserObserver.php

src/app/Rules/Password.php

src/app/Traits/UserConfigTrait.php

src/app/User.php

src/app/UserPassword.php

src/database/migrations/2022_02_04_100000_create_user_passwords_table.php

src/resources/lang/en/app.php

src/resources/lang/en/validation.php

src/resources/vue/Settings.vue

src/tests/Browser/SettingsTest.php

src/tests/Feature/Controller/PasswordPolicyTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/UserTest.php

src/tests/Unit/Rules/PasswordTest.php

Password historyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9649

src/app/Http/Controllers/API/PasswordPolicyController.php

src/app/Observers/UserObserver.php

src/app/Rules/Password.php

src/app/Traits/UserConfigTrait.php

src/app/User.php

src/app/UserPassword.php

src/database/migrations/2022_02_04_100000_create_user_passwords_table.php

src/resources/lang/en/app.php

src/resources/lang/en/validation.php

src/resources/vue/Settings.vue

src/tests/Browser/SettingsTest.php

src/tests/Feature/Controller/PasswordPolicyTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/UserTest.php

src/tests/Unit/Rules/PasswordTest.php

Password history
ClosedPublic
Actions

Revision Contents
Changeset List