Page MenuHomePhorge

Password history
ClosedPublic

Authored by machniak on Feb 7 2022, 11:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:57 PM
Unknown Object (File)
Sat, Mar 16, 10:44 AM
Unknown Object (File)
Sun, Mar 10, 12:01 PM
Unknown Object (File)
Mon, Mar 4, 9:15 AM
Unknown Object (File)
Sat, Mar 2, 2:21 PM
Unknown Object (File)
Sat, Mar 2, 2:20 PM
Unknown Object (File)
Sat, Mar 2, 2:20 PM
Unknown Object (File)
Sat, Mar 2, 2:19 PM
Subscribers
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK679a6c49cc40: Password history
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/password-retention
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38359
Build 15511: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Don't store more old passwords than it's required by the account policy
  • Merge branch 'master' into dev/password-retention
  • Fix "last" policy validation
mollekopf added inline comments.
src/app/Observers/UserObserver.php
320

I would make this a >= just to be safe (even if we technically *shouldn't* ever get there).

src/app/Rules/Password.php
200
if (strlen($password) == 0) {
  return false;
}

would be easier to read imo.

  • Merge branch 'master' into dev/password-retention
  • Small code improvement
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2022, 12:27 PM
Closed by commit rK679a6c49cc40: Password history (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.