Page MenuHomePhorge

Password expiration notification
ClosedPublic

Authored by machniak on Feb 16 2022, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 29, 6:50 PM
Unknown Object (File)
Wed, Nov 22, 12:11 AM
Unknown Object (File)
Sat, Nov 18, 6:54 AM
Unknown Object (File)
Tue, Nov 14, 8:37 AM
Unknown Object (File)
Sat, Nov 11, 8:29 PM
Unknown Object (File)
Tue, Nov 7, 11:14 PM
Unknown Object (File)
Tue, Nov 7, 4:10 AM
Unknown Object (File)
Fri, Nov 3, 1:22 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK8a62ff5ce853: Password expiration notification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • Add missing command description
  • Merge branch 'master' into dev/password-retention
mollekopf subscribed.

Using months as unit of the max_password_age seems rather coarse, but if it's good enough for the end users it's good enough for me (don't know to which extent this has already been discussed).

src/app/Console/Commands/PasswordRetentionCommand.php
50

I think skipping suspended users makes sense. I wouldn't skip degraded users.

src/app/Traits/UserConfigTrait.php
40

nitpick: intval($value) > 0 would do the job I think.

This revision is now accepted and ready to land.Apr 1 2022, 10:46 AM
  • Merge branch 'master' into dev/password-retention
This revision was automatically updated to reflect the committed changes.