Page MenuHomekolab.org

Password expiration notification
ClosedPublic

Authored by machniak on Feb 16 2022, 1:54 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK8a62ff5ce853: Password expiration notification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Feb 16 2022, 1:54 PM
machniak created this revision.
Harbormaster completed remote builds in B38437: Diff 9658.
machniak updated this revision to Diff 9664.Feb 17 2022, 10:16 AM
  • Add missing command description
  • Merge branch 'master' into dev/password-retention
Harbormaster completed remote builds in B38461: Diff 9664.
mollekopf accepted this revision.Apr 1 2022, 10:46 AM
mollekopf added a subscriber: mollekopf.

Using months as unit of the max_password_age seems rather coarse, but if it's good enough for the end users it's good enough for me (don't know to which extent this has already been discussed).

src/app/Console/Commands/PasswordRetentionCommand.php
50

I think skipping suspended users makes sense. I wouldn't skip degraded users.

src/app/Traits/UserConfigTrait.php
40

nitpick: intval($value) > 0 would do the job I think.

This revision is now accepted and ready to land.Apr 1 2022, 10:46 AM
machniak updated this revision to Diff 10024.Thu, Apr 21, 10:42 AM
  • Suggested changes
machniak updated this revision to Diff 10084.Thu, Apr 21, 1:44 PM
  • Merge branch 'master' into dev/password-retention
machniak updated this revision to Diff 10087.Thu, Apr 21, 1:55 PM
  • Fix test
This revision was automatically updated to reflect the committed changes.