./phpunit
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK8a62ff5ce853: Password expiration notification
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/password-retention
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 38878 Build 15775: arc lint + arc unit
Event Timeline
Comment Actions
Using months as unit of the max_password_age seems rather coarse, but if it's good enough for the end users it's good enough for me (don't know to which extent this has already been discussed).
src/app/Console/Commands/PasswordRetentionCommand.php | ||
---|---|---|
50 | I think skipping suspended users makes sense. I wouldn't skip degraded users. | |
src/app/Traits/UserConfigTrait.php | ||
40 | nitpick: intval($value) > 0 would do the job I think. |