Page MenuHomePhorge

Password expiration notification
ClosedPublic

Authored by machniak on Feb 16 2022, 1:54 PM.
Tags
None
Referenced Files
F11584524: D3379.diff
Thu, Mar 28, 8:25 AM
Unknown Object (File)
Thu, Mar 7, 3:32 AM
Unknown Object (File)
Tue, Mar 5, 9:12 PM
Unknown Object (File)
Feb 25 2024, 1:06 PM
Unknown Object (File)
Feb 25 2024, 9:24 AM
Unknown Object (File)
Jan 24 2024, 8:41 AM
Unknown Object (File)
Jan 24 2024, 8:10 AM
Unknown Object (File)
Jan 24 2024, 7:35 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK8a62ff5ce853: Password expiration notification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/password-retention
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 38896
Build 15787: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Add missing command description
  • Merge branch 'master' into dev/password-retention
mollekopf subscribed.

Using months as unit of the max_password_age seems rather coarse, but if it's good enough for the end users it's good enough for me (don't know to which extent this has already been discussed).

src/app/Console/Commands/PasswordRetentionCommand.php
50

I think skipping suspended users makes sense. I wouldn't skip degraded users.

src/app/Traits/UserConfigTrait.php
40

nitpick: intval($value) > 0 would do the job I think.

This revision is now accepted and ready to land.Apr 1 2022, 10:46 AM
  • Merge branch 'master' into dev/password-retention
This revision was automatically updated to reflect the committed changes.