ws:// socket works for me on https:// page. I use ws:// because I couldn't get wss:// socket to work in my setup, some certificate issue not related to the hostname.

Please, also fix this:

FILE: ...home/alec/repos/kolab/src/tests/Feature/Stories/GreylistTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 434 | ERROR | [x] The closing brace for the class must go on the
     |       |     next line after the body

I found one problem with this approach. The handlers registered by these traits are executed before observer's event handlers. I.e. we generate uuid before we do 'creating' pre-checks. For example EntitlementObserver. I think it makes sense to keep pre-checks in the observer, and do "simple" stuff via traits, but the order should be reversed so observers run first. Well, at least for these cases at hand it would be a proper way.

In D2815#33931, @mollekopf wrote:

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

• Remove redundant ->limit(1)

• Move greylisting setting back to user_settings, cleanup

• Merge branch 'master' into dev/status-degraded
• Add some French localization

• Performance optimizations

• Small perf. improvement, skip redundant query

I think I would prefer UuidIntKeyTrait and UuidStrKeyTrait. Other than that it looks good.

We also have three models that use uuidInt. So, another trait?

If it works, I like it. We should apply it to other models too. I'm not sure about the name, maybe UuidKeyTrait would be better?

How about a test? And I guess @vanmeeuwen might have an opinion that it will be better to keep it for development only, i.e. app/Console/Development/.

Green light from me.

• Small fixes

• Localize "/month"

Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.

• Remove jQuery for realz

One last issue. Other than that it looks good. I didn't test the docker part, I guess we'll need some intergration tests later.

I miss tests for console commands. I get they are simple and CLI has the worse coverage, but still it shouldn't be that hard.

Minor comments just after the code review, no testing and closer look on it yet.

• Support multi-currency in income calculation for stats

I'm planning on updating this diff with a fix for stats (where the income chart should sum up eur and chf payments using conversion rates and present the results in chf).