Avoid extra query if we know no entry exists
ClosedPublic
Actions

Authored by mollekopf on Aug 27 2021, 10:48 AM.

Project Tags

None

Referenced Files

	F117736698: D2851.1775150930.diff
	Wed, Apr 1, 5:28 PM

	F117724764: D2851.1774890983.diff
	Sun, Mar 29, 5:16 PM

Subscribers

machniak

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rK5ae2e7a89350: Avoid extra query if we know no entry exists

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Aug 27 2021, 10:48 AM

mollekopf created this revision.

Harbormaster completed remote builds in B36517: Diff 8197.Aug 27 2021, 10:48 AM

mollekopf added a reviewer: Restricted Project.Aug 27 2021, 10:48 AM

Please, also fix this:

FILE: ...home/alec/repos/kolab/src/tests/Feature/Stories/GreylistTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 434 | ERROR | [x] The closing brace for the class must go on the
     |       |     next line after the body

src/app/Policy/Greylist/Request.php
190	I usually would write this as `if (!$noEntry && ($connect = $this->findConnectsCollection()->first())) {` even if the brackets aren't required.

This revision now requires changes to proceed.Aug 27 2021, 10:51 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Aug 27 2021, 11:05 AM

Closed by commit rK5ae2e7a89350: Avoid extra query if we know no entry exists. · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Policy/

Greylist/

Request.php

lines

Diff 8206

View Options

src/app/Policy/Greylist/Request.php

Avoid extra query if we know no entry existsClosedPublicActions