Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rK5ae2e7a89350: Avoid extra query if we know no entry exists
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please, also fix this:
FILE: ...home/alec/repos/kolab/src/tests/Feature/Stories/GreylistTest.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 434 | ERROR | [x] The closing brace for the class must go on the | | next line after the body
src/app/Policy/Greylist/Request.php | ||
---|---|---|
190 | I usually would write this as if (!$noEntry && ($connect = $this->findConnectsCollection()->first())) { even if the brackets aren't required. |