Page MenuHomePhorge

Greylist/Request simplify logic
ClosedPublic

Authored by mollekopf on Aug 27 2021, 11:50 AM.
Tags
None
Referenced Files
F11816517: D2845.diff
Fri, Apr 19, 10:14 PM
F11816148: D2845.id8188.diff
Fri, Apr 19, 9:09 PM
Unknown Object (File)
Sat, Apr 13, 10:44 AM
Unknown Object (File)
Thu, Apr 11, 9:46 AM
Unknown Object (File)
Fri, Mar 29, 1:52 PM
Unknown Object (File)
Thu, Mar 28, 4:47 PM
Unknown Object (File)
Thu, Mar 28, 5:51 AM
Unknown Object (File)
Jan 24 2024, 1:31 PM
Subscribers
None

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKa4534ed6c24f: Greylist/Request: simplify logic
Summary
  • There can only every be one entry for the sender/recipient/net pair (due to the unique constraint)
  • We already verify in the beginning that we have an entry within the last 7 days (and otherwise purge all entries), so it can't be older than a month.

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Aug 27 2021, 11:51 AM
This revision is now accepted and ready to land.Aug 27 2021, 11:56 AM

Reuse the existing function to query for the connection

This revision was automatically updated to reflect the committed changes.
src/app/Policy/Greylist/Request.php
188

We could skip the query if we know there's no entries, i.e. see line 87.