Paths

Table of Contentst

Differential D2785

Avoid relying on hardcoded tenant ids in tests
ClosedPublic
Actions

Authored by mollekopf on Aug 20 2021, 2:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 16, 11:34 PM

	Unknown Object (File)
	Nov 7 2023, 6:37 AM

	Unknown Object (File)
	Nov 1 2023, 2:24 PM

	Unknown Object (File)
	Oct 31 2023, 11:08 PM

	Unknown Object (File)
	Oct 25 2023, 3:34 PM

	Unknown Object (File)
	Oct 22 2023, 4:09 PM

	Unknown Object (File)
	Oct 22 2023, 3:57 PM

	Unknown Object (File)
	Oct 22 2023, 11:06 AM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK887e95d73397: Avoid relying on hardcoded tenant ids in tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Aug 20 2021, 2:04 PM

mollekopf created this revision.

Harbormaster completed remote builds in B36310: Diff 8008.Aug 20 2021, 2:04 PM

mollekopf added a reviewer: Restricted Project.Aug 20 2021, 2:04 PM

machniak requested changes to this revision.Aug 25 2021, 1:15 PM

machniak subscribed.

machniak added inline comments.

src/tests/Feature/Controller/SkusTest.php
59–60	The intention of this tests (and most of other you modified) was to use non default tenant. I.e. something like `Tenant::whereNotIn('id', [\config('app.tenant_id')])->first()` might be more appropriate.
src/tests/Feature/TenantTest.php
42	Same here. We're testing for non-default tenant.

This revision now requires changes to proceed.Aug 25 2021, 1:15 PM

Use the configured id instead of assuming a name

Harbormaster completed remote builds in B36424: Diff 8098.Aug 26 2021, 1:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2021, 10:13 AM

Closed by commit rK887e95d73397: Avoid relying on hardcoded tenant ids in tests (authored by mollekopf, committed by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

tests/

Feature/

Controller/

7 lines

4 lines

4 lines

Diff 8158

src/tests/Feature/Controller/SkusTest.php

Loading...

src/tests/Feature/DomainTest.php

Loading...

src/tests/Feature/TenantTest.php

Loading...