Adjusted notification token and device id size limits
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 18 2021
Included console tests
Removed assemble changes
- Add a search for a wallet id
- Add tests for the api calls
- Here be a method not a property
- Relations are properties
I added this while using the migration code because sometimes we would just silently fail.
This is the code as we used it for the migration, I'm not looking to invest a lot of time in this until we decide to actually use it elsewhere.
Addressed comments, moved to services. url
Moved to uuids for clients
All comments resolved.
- Commentary, safety on settings not found
Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.
Aug 17 2021
Addressed comments.
- Describe $domain
- Rebase on master
One last issue. Other than that it looks good. I didn't test the docker part, I guess we'll need some intergration tests later.
- Minimal validation.
- Just use $domain->name everywhere
- Disable domain observer events in turn bumping the serial
- Make use of the records relation
- Fix typo, test domain creation/observer
Incoming! ;-)
I miss tests for console commands. I get they are simple and CLI has the worse coverage, but still it shouldn't be that hard.
Aug 16 2021
Ready for merge
Merged into D2413
Minor comments just after the code review, no testing and closer look on it yet.
Merged into D2494
Addressed comments
Include writing out the passport keys in the assemble script
- Remove another irrelevant change
- Remove useless change
Update diff to latest state