Page MenuHomePhorge
Feed All Stories

Aug 18 2021

machniak requested review of D2752: French localization.
Aug 18 2021, 3:49 PM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Adjusted notification token and device id size limits

Aug 18 2021, 12:47 PM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Included console tests

Aug 18 2021, 12:28 PM
mollekopf updated the diff for D2494: Laravel Passport support.

Removed assemble changes

Aug 18 2021, 12:28 PM
machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 18 2021, 12:15 PM
vanmeeuwen committed rKb70dbda55bad: Allow search with transaction and customer IDs (authored by vanmeeuwen).
Allow search with transaction and customer IDs
Aug 18 2021, 11:56 AM
vanmeeuwen closed D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 11:56 AM
vanmeeuwen updated the diff for D2740: Allow search with transaction and customer IDs.
  • Add a search for a wallet id
Aug 18 2021, 11:55 AM
vanmeeuwen updated the diff for D2740: Allow search with transaction and customer IDs.
  • Add tests for the api calls
Aug 18 2021, 11:46 AM
machniak accepted D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:53 AM
vanmeeuwen requested review of D2746: Replace all mentions of simple123 with the generate passphrase utility function, just in case APP_PASSPHRASE is set to something not 'simple123'.
Aug 18 2021, 10:52 AM
vanmeeuwen updated the diff for D2740: Allow search with transaction and customer IDs.
  • Here be a method not a property
Aug 18 2021, 10:50 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:45 AM
vanmeeuwen updated the diff for D2740: Allow search with transaction and customer IDs.
  • Relations are properties
Aug 18 2021, 10:42 AM
mollekopf added a reviewer for D2728: Set errors if something fails during append: Restricted Project.

I added this while using the migration code because sometimes we would just silently fail.

Aug 18 2021, 10:37 AM
mollekopf added a reviewer for D2413: Userdata migration for pst import: Restricted Project.

This is the code as we used it for the migration, I'm not looking to invest a lot of time in this until we decide to actually use it elsewhere.

Aug 18 2021, 10:36 AM
machniak added inline comments to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:35 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:34 AM
mollekopf accepted D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 10:30 AM
mollekopf added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 18 2021, 10:28 AM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Addressed comments, moved to services. url

Aug 18 2021, 10:25 AM
mollekopf updated the diff for D2494: Laravel Passport support.

Moved to uuids for clients

Aug 18 2021, 10:25 AM
vanmeeuwen added a comment to D2740: Allow search with transaction and customer IDs.

All comments resolved.

Aug 18 2021, 10:21 AM
vanmeeuwen updated the diff for D2740: Allow search with transaction and customer IDs.
  • Commentary, safety on settings not found
Aug 18 2021, 10:21 AM
vanmeeuwen committed rKb764c4cd6781: back to oauth proxy client (authored by vanmeeuwen).
back to oauth proxy client
Aug 18 2021, 9:51 AM
vanmeeuwen added inline comments to rK7bfc09bf1a0b: Change passport over to using UUIDs.
Aug 18 2021, 9:10 AM
mollekopf added inline comments to rK7bfc09bf1a0b: Change passport over to using UUIDs.
Aug 18 2021, 9:07 AM
vanmeeuwen committed rK7bfc09bf1a0b: Change passport over to using UUIDs (authored by vanmeeuwen).
Change passport over to using UUIDs
Aug 18 2021, 9:00 AM
vanmeeuwen committed rK2b7a74400512: Laravel Passport support (authored by mollekopf).
Laravel Passport support
Aug 18 2021, 9:00 AM
mollekopf added inline comments to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 8:48 AM
mollekopf added inline comments to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 8:48 AM
mollekopf added inline comments to D2740: Allow search with transaction and customer IDs.
Aug 18 2021, 8:43 AM
machniak requested changes to D2740: Allow search with transaction and customer IDs.

Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.

Aug 18 2021, 8:00 AM

Aug 17 2021

machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 6:32 PM
mollekopf added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 5:02 PM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Addressed comments.

Aug 17 2021, 5:01 PM
machniak committed rK67e900314a1b: Merge branch 'master' into dev/kolabmeet (authored by machniak).
Merge branch 'master' into dev/kolabmeet
Aug 17 2021, 3:49 PM
machniak committed rK6cf47624770c: Basic PowerDNS functionality (authored by vanmeeuwen).
Basic PowerDNS functionality
Aug 17 2021, 3:23 PM
machniak closed D2722: Basic PowerDNS functionality.
Aug 17 2021, 3:23 PM
machniak committed rKd30fd0cfff6a: Refresh package-lock.json, fix problem with frappe-charts styles integration (authored by machniak).
Refresh package-lock.json, fix problem with frappe-charts styles integration
Aug 17 2021, 3:10 PM
vanmeeuwen added inline comments to D2494: Laravel Passport support.
Aug 17 2021, 2:44 PM
mollekopf added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 2:32 PM
robertsmith updated robertsmith.
Aug 17 2021, 1:35 PM
robertsmith updated robertsmith.
Aug 17 2021, 1:34 PM
mollekopf committed rK52b13c22685f: NGINX Controller, 2fa for client connections and companion app support (authored by mollekopf).
NGINX Controller, 2fa for client connections and companion app support
Aug 17 2021, 12:55 PM
mollekopf committed rK6b017cad0c7e: Laravel Passport support (authored by mollekopf).
Laravel Passport support
Aug 17 2021, 12:55 PM
machniak committed rKa384d26dbb7f: Fix linting issues, mostly indentation (authored by machniak).
Fix linting issues, mostly indentation
Aug 17 2021, 12:16 PM
machniak committed rK89a0ce5ab84f: Bootstrap v5 (authored by machniak).
Bootstrap v5
Aug 17 2021, 12:01 PM
machniak closed D2734: Bootstrap v5.
Aug 17 2021, 12:01 PM
machniak accepted D2722: Basic PowerDNS functionality.
Aug 17 2021, 12:00 PM
vanmeeuwen updated the diff for D2722: Basic PowerDNS functionality.
  • Describe $domain
  • Rebase on master
Aug 17 2021, 11:58 AM
vanmeeuwen accepted D2734: Bootstrap v5.
Aug 17 2021, 11:42 AM
machniak updated the diff for D2734: Bootstrap v5.
  • Remove jQuery for realz
Aug 17 2021, 11:33 AM
vanmeeuwen requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 11:24 AM
vanmeeuwen requested review of D2740: Allow search with transaction and customer IDs.
Aug 17 2021, 11:17 AM
machniak added a comment to D2722: Basic PowerDNS functionality.

One last issue. Other than that it looks good. I didn't test the docker part, I guess we'll need some intergration tests later.

Aug 17 2021, 11:15 AM
machniak requested review of D2734: Bootstrap v5.
Aug 17 2021, 11:01 AM
vanmeeuwen committed rK9c0964980d2f: Add possibility to change system currency (authored by machniak).
Add possibility to change system currency
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2716: Add possibility to change system currency.
Aug 17 2021, 10:49 AM
vanmeeuwen committed rKc282a9c473bd: Consistently use website_domain for api (authored by mollekopf).
Consistently use website_domain for api
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2698: Consistently use website_domain for api.
Aug 17 2021, 10:49 AM
vanmeeuwen committed rK8ed6e378dd06: Greylist alias test (authored by mollekopf).
Greylist alias test
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2686: Greylist alias test.
Aug 17 2021, 10:49 AM
vanmeeuwen committed rKca2fa6d00b46: NGINX docker container (authored by mollekopf).
NGINX docker container
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2671: NGINX docker container.
Aug 17 2021, 10:49 AM
vanmeeuwen committed rK6d065058fc88: Add PGP keys generator (authored by machniak).
Add PGP keys generator
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2554: Add PGP keys generator.
Aug 17 2021, 10:49 AM
vanmeeuwen committed rKb54c2780027a: Fix kolab container setup (authored by mollekopf).
Fix kolab container setup
Aug 17 2021, 10:49 AM
vanmeeuwen closed D2407: Fix kolab container setup.
Aug 17 2021, 10:49 AM
vanmeeuwen accepted D2554: Add PGP keys generator.
Aug 17 2021, 10:24 AM
vanmeeuwen accepted D2698: Consistently use website_domain for api.
Aug 17 2021, 10:20 AM
vanmeeuwen accepted D2686: Greylist alias test.
Aug 17 2021, 10:20 AM
vanmeeuwen updated the diff for D2722: Basic PowerDNS functionality.
  • Minimal validation.
  • Just use $domain->name everywhere
  • Disable domain observer events in turn bumping the serial
  • Make use of the records relation
  • Fix typo, test domain creation/observer
Aug 17 2021, 10:16 AM
vanmeeuwen planned changes to D2722: Basic PowerDNS functionality.

Incoming! ;-)

Aug 17 2021, 10:16 AM
machniak added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 10:11 AM
machniak added inline comments to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 17 2021, 9:38 AM
machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.

I miss tests for console commands. I get they are simple and CLI has the worse coverage, but still it shouldn't be that hard.

Aug 17 2021, 8:46 AM

Aug 16 2021

machniak added inline comments to D2722: Basic PowerDNS functionality.
Aug 16 2021, 4:31 PM
mollekopf committed rKc05d1fa44ca8: Userdata migration for pst import (authored by mollekopf).
Userdata migration for pst import
Aug 16 2021, 4:31 PM
mollekopf committed rKc8a9d1936cc4: Set errors if something fails during append (authored by mollekopf).
Set errors if something fails during append
Aug 16 2021, 4:31 PM
mollekopf committed rK56e426ae8db6: Fix kolab container setup (authored by mollekopf).
Fix kolab container setup
Aug 16 2021, 4:31 PM
mollekopf updated the diff for D2413: Userdata migration for pst import.

Ready for merge

Aug 16 2021, 4:16 PM
mollekopf requested review of D2728: Set errors if something fails during append.
Aug 16 2021, 4:16 PM
mollekopf abandoned D2416: A docker container for the migration command.

Merged into D2413

Aug 16 2021, 4:14 PM
machniak requested changes to D2722: Basic PowerDNS functionality.

Minor comments just after the code review, no testing and closer look on it yet.

Aug 16 2021, 4:08 PM
vanmeeuwen accepted D2671: NGINX docker container.
Aug 16 2021, 3:57 PM
vanmeeuwen accepted D2407: Fix kolab container setup.
Aug 16 2021, 3:53 PM
mollekopf abandoned D2710: Seed oauth public/private keys from env variable in assemble script.

Merged into D2494

Aug 16 2021, 3:44 PM
mollekopf abandoned D2704: Geolocation support.

Merged into D2674

Aug 16 2021, 3:43 PM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Addressed comments

Aug 16 2021, 3:39 PM
mollekopf updated the diff for D2494: Laravel Passport support.

Include writing out the passport keys in the assemble script

Aug 16 2021, 3:39 PM
vanmeeuwen updated the diff for D2722: Basic PowerDNS functionality.
  • Remove another irrelevant change
Aug 16 2021, 3:05 PM
vanmeeuwen updated the diff for D2722: Basic PowerDNS functionality.
  • Remove useless change
Aug 16 2021, 3:04 PM
vanmeeuwen requested review of D2722: Basic PowerDNS functionality.
Aug 16 2021, 3:00 PM
mollekopf accepted D2716: Add possibility to change system currency.
Aug 16 2021, 1:05 PM
machniak added inline comments to D2716: Add possibility to change system currency.
Aug 16 2021, 1:00 PM
mollekopf updated the diff for D2674: NGINX Controller, 2fa for client connections and companion app support.

Update diff to latest state

Aug 16 2021, 12:46 PM
mollekopf added inline comments to D2716: Add possibility to change system currency.
Aug 16 2021, 12:37 PM
mollekopf added a reviewer for D2704: Geolocation support: Restricted Project.
Aug 16 2021, 12:24 PM
mollekopf added a reviewer for D2710: Seed oauth public/private keys from env variable in assemble script: Restricted Project.
Aug 16 2021, 12:24 PM