Page MenuHomePhorge

Set errors if something fails during append
Needs RevisionPublic

Authored by mollekopf on Aug 16 2021, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 6:49 PM
Unknown Object (File)
Tue, Mar 5, 6:47 PM
Unknown Object (File)
Tue, Mar 5, 6:28 PM
Unknown Object (File)
Feb 12 2024, 9:39 PM
Unknown Object (File)
Feb 12 2024, 8:22 AM
Unknown Object (File)
Feb 9 2024, 10:04 PM
Unknown Object (File)
Jan 15 2024, 4:35 AM
Unknown Object (File)
Jan 9 2024, 8:24 AM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKc8a9d1936cc4: Set errors if something fails during append

Diff Detail

Repository
rK kolab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36079
Build 14173: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Aug 18 2021, 10:37 AM

I added this while using the migration code because sometimes we would just silently fail.

This is upstream code, so we should be careful, and then create a PR for Roundcube to include the changes.

src/include/rcube_imap_generic.php
3053

The message should be more explanatory, maybe "Failed to write to socket on APPEND".

3061

Same here.

This revision now requires changes to proceed.Sep 20 2022, 1:00 PM