Page MenuHomePhorge
Differential D2728

Set errors if something fails during append
Needs RevisionPublic
Actions

Authored by mollekopf on Aug 16 2021, 4:16 PM.
Tags
None
Referenced Files
F11885091: D2728.diff
Wed, Apr 24, 3:32 PM
Unknown Object (File)
Wed, Apr 24, 5:41 AM
Unknown Object (File)
Sat, Apr 20, 12:37 AM
Unknown Object (File)
Fri, Apr 12, 2:52 AM
Unknown Object (File)
Tue, Apr 9, 6:36 PM
Unknown Object (File)
Mar 5 2024, 6:49 PM
Unknown Object (File)
Mar 5 2024, 6:47 PM
Unknown Object (File)
Mar 5 2024, 6:28 PM
View All 24 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKc8a9d1936cc4: Set errors if something fails during append

Diff Detail

Repository
rK kolab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36079
Build 14173: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Aug 16 2021, 4:16 PM
mollekopf created this revision.
Harbormaster completed remote builds in B36079: Diff 7768.Aug 16 2021, 4:16 PM
mollekopf added a reviewer: Restricted Project.Aug 18 2021, 10:37 AM

I added this while using the migration code because sometimes we would just silently fail.

machniak subscribed.Sep 20 2022, 1:00 PM

This is upstream code, so we should be careful, and then create a PR for Roundcube to include the changes.

src/include/rcube_imap_generic.php
3053

The message should be more explanatory, maybe "Failed to write to socket on APPEND".

3061

Same here.

machniak requested changes to this revision.Sep 20 2022, 1:00 PM
This revision now requires changes to proceed.Sep 20 2022, 1:00 PM

Revision Contents
Changeset List

PathSize
src/
include/
3 lines

Diff 7768

View Options

src/include/rcube_imap_generic.php

Loading...