Page MenuHomePhorge
Feed Search

Aug 16 2021

machniak requested changes to D2674: NGINX Controller, 2fa for client connections and companion app support.
Aug 16 2021, 8:18 AM

Aug 13 2021

machniak updated the diff for D2716: Add possibility to change system currency.
  • More tests
Aug 13 2021, 6:37 AM
machniak updated the summary of D2716: Add possibility to change system currency.
Aug 13 2021, 6:27 AM

Aug 12 2021

machniak updated the diff for D2716: Add possibility to change system currency.
  • Add tests, fix small bugs
  • Use wallet currency in bonus/penalty dialog
Aug 12 2021, 1:36 PM
machniak planned changes to D2716: Add possibility to change system currency.
Aug 12 2021, 12:03 PM
machniak requested review of D2716: Add possibility to change system currency.
Aug 12 2021, 9:59 AM

Aug 10 2021

machniak updated the diff for D2371: Degraded accounts.
  • Remove unintentionally recovered app/Console/Development/UserStatus.php
  • Cleanup
Aug 10 2021, 10:21 AM
machniak updated the diff for D2371: Degraded accounts.
  • Merge branch 'master' into dev/status-degraded
  • Fix regressions regarding tenants
  • Fix more regressions
  • Small cleanup
Aug 10 2021, 10:02 AM

Aug 9 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • "Move" pgp.enable to per-tenant settings
Aug 9 2021, 2:36 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Fix a test breaking other tests
Aug 9 2021, 12:52 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Merge branch 'master' into dev/encryption
Aug 9 2021, 10:35 AM
machniak committed rK49da450ef27c: Fix some flaky browser tests assertions.
Aug 9 2021, 9:22 AM
machniak committed rKb61bace3b004: Skip horizon test if it's not installed.
Aug 9 2021, 8:57 AM
machniak committed rK51b0e87be933: Fix costsPerDay() test.
Aug 9 2021, 8:44 AM

Aug 2 2021

machniak added a comment to D2686: Greylist alias test.

I think this is all right. Note that anything that uses setUpTest() is very slow. I'd prefer if we didn't use this method at all, or at least not in setUp() method on a file with many tests.

Aug 2 2021, 4:16 PM

Jul 31 2021

machniak committed rPNL9bcc57027a06: Fix PHP 8.1 compatibility where LDAP connection is not a resource, but an object.
Jul 31 2021, 3:37 PM
machniak committed rPNL8c1b36bb9fa9: Fix PHP 8.1 deprecation warnings.
Jul 31 2021, 3:34 PM

Jul 30 2021

machniak committed rKdea894c6f30b: Fix some browser tests in mobile mode.
Jul 30 2021, 1:42 PM
machniak committed rK97429f370ebe: Refactored tenant:create command's code to fix strange phpstan errors.
Jul 30 2021, 12:01 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Switch new keypair algorithms to RSA
  • Use Laravel's Storage functionality
  • Add exportPublicKey() use
  • Generate a keypair for new alias
  • Unregister keys on alias delete
  • Add forgotten file
  • Fix issues found by phpstan
Jul 30 2021, 11:26 AM
machniak committed rKcfe21edcc120: Update stylelint.
Jul 30 2021, 10:22 AM
machniak committed rKcd7b7bfa791c: Update more npm deps.
Jul 30 2021, 10:16 AM
machniak committed rK1bddbe52d3c3: Update some npm deps.
Jul 30 2021, 10:16 AM
machniak committed rK14543c757732: Fix one more test.
Jul 30 2021, 7:51 AM
machniak committed rK54dc4cddd144: Fix some tests dependency on APP_NAME.
Jul 30 2021, 7:44 AM
machniak committed rK96ee1e4826b9: Set MAIL_REPLYTO_ADDRESS in .env.example.
Jul 30 2021, 7:24 AM
machniak committed rKb0d4d89a22a9: Fix regressions.
Jul 30 2021, 7:08 AM
machniak committed rKeca49d51185b: Fix "Could not scan for classes inside "database/factories"".
Jul 30 2021, 6:13 AM

Jul 29 2021

machniak committed rRPKc99ac18b8940: Use ISO week numbers in both full-calendar and date picker.
Jul 29 2021, 12:34 PM
machniak updated the diff for D2623: Greylisting + SPF.
  • Remove redundant generatePassphrase()
  • Fix migration
  • Fix regression
  • Fix various bugs found by phpstan and test regressions
Jul 29 2021, 12:04 PM

Jul 28 2021

machniak updated the diff for D2659: Tenant settings.
  • Fix withObjectTenantContext macro
    • It's result should not depend on the current user role
    • It was throwing exceptions when working with an unauth user (e.g. /meet endpoints)
    • Fixed some tests
Jul 28 2021, 12:11 PM

Jul 22 2021

machniak committed rAC9386fe6e5fb6: Add an option to respond to mobilesync requests only.
Jul 22 2021, 1:39 PM
machniak committed rKb584482f2d8d: Fix body padding issue after deleting a user.
Jul 22 2021, 12:19 PM
machniak committed rK86b4731f2166: Fix call to undefined method App\Providers\Payment\Mollie::exchangeRate().
Jul 22 2021, 12:00 PM
machniak requested review of D2680: Meet: Audio volume control.
Jul 22 2021, 10:06 AM
machniak committed rK9fa729c67776: Fix missing localization label.
Jul 22 2021, 7:46 AM
machniak added a comment to T6610: style.css and files_api.js only http not https.

The kolab_files plugin has some configuration. You can set these to an absolute URLs.

// URL of kolab-chwala installation
$config['kolab_files_url'] = '/chwala/';
Jul 22 2021, 6:32 AM · Bug Reports
machniak added a comment to T6670: Deleted groups still appearing under Global Address Book.

The ldap group information is cached, by default for 10 minutes. Check ldap_cache and ldap_cache_ttl settings. You can disable the cache with $config['ldap_cache'] = null;.

Jul 22 2021, 6:30 AM · Roundcube

Jul 19 2021

machniak committed rAC2e81ac04b413: Set AutoDiscoverSMTPAddress to user login, and fallback to email, the same as….
Jul 19 2021, 1:43 PM
machniak committed rAC9372ec6fc7a0: Merge branch 'master' of ssh://git.kolab.org/diffusion/AC/autoconf.
Jul 19 2021, 11:57 AM
machniak committed rACbade385c19e2: Return early on unsupported protocol.
Jul 19 2021, 11:57 AM
machniak committed rAC9906f5974c08: Typo: ErrorCore -> ErrorCode.
Jul 19 2021, 8:26 AM
machniak committed rAC31b044adcd83: Fix JSON autodiscovery for requests with non-v1.0 syntax.
Jul 19 2021, 7:24 AM

Jul 16 2021

machniak accepted D2665: Log requests during testing.
Jul 16 2021, 9:18 AM

Jul 15 2021

machniak updated the diff for D2659: Tenant settings.
  • Add getSettings() method, and use it as a optimization tool
Jul 15 2021, 8:07 AM

Jul 13 2021

machniak requested review of D2659: Tenant settings.
Jul 13 2021, 9:04 AM

Jul 12 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Remove unused Packages controllers for admin and reseller API
  • Fix SKU controllers
  • Fix Wallet controllers
  • Fix Users controllers
  • /api/discounts -> /api/users/{id}/discounts as we need the user context for this
Jul 12 2021, 9:44 AM

Jul 9 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix Group and Domain controllers, use new helper checkTenant()
Jul 9 2021, 6:00 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix InvitationsController
Jul 9 2021, 2:46 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix reseller's GroupsController and tests for it
Jul 9 2021, 1:16 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix various places where tenant context wasn't applied when selecting a sku record
Jul 9 2021, 10:39 AM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix obvious test regressions and a bug in the signup controller
Jul 9 2021, 8:33 AM

Jul 7 2021

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix browser tests
Jul 7 2021, 12:51 PM

Jul 2 2021

machniak committed rSfb6622841a94: Add option to disable TNEF decoding (activesync_tnef_blacklist).
Jul 2 2021, 1:02 PM
machniak committed rRPK945ac3605d4c: Fix 2FA logon with kolab_auth's "login as" feature.
Jul 2 2021, 11:56 AM
machniak requested changes to D2653: Attempt to fix issues with acl setting when acl subject has upper case letters in LDAP..
Jul 2 2021, 9:20 AM
machniak committed rS8e98b9f2a9a8: Fix Windows to Olson timezone conversion for some timezones e.g. Asia/Tehran.
Jul 2 2021, 8:45 AM
machniak committed rSa4204ab0f838: Made Timezone format Outlook compatible (authored by mollekopf).
Jul 2 2021, 8:45 AM
machniak closed D2647: Made Timezone format Outlook compatible.
Jul 2 2021, 8:45 AM
machniak committed rSffbd6a2246af: Fix PHP8 warnings.
Jul 2 2021, 6:42 AM
machniak committed rS0dbfe14ceeee: Support more recent PHPUnit versions.
Jul 2 2021, 6:42 AM
machniak committed rSd267da5cdc08: Fix array and string offset access syntax with curly braces.
Jul 2 2021, 6:42 AM

Jun 30 2021

machniak requested changes to D2635: Further changes to the reseller implementation.
[14:20:34] <alec> I'm getting quite a lot of failing tests: Errors: 20, Failures: 51, Skipped: 7, Incomplete: 14. just from --testsuite=Feature 
[14:20:34] <alec> I guess you might be running tests with a different APP_TENANT_ID or sth 
[14:20:54] <alec> I have APP_TENANT_ID=1 in .env 
[14:22:57] <alec> damn, and I've run it with production mollie key, there 4 new users created, can you remove them? 
[14:27:32] <alec> also APP_PASSPHRASE=simple123 is needed when seeding and running tests 
[14:41:48] <alec> for browser tests: Errors: 16, Failures: 8, Skipped: 14, Incomplete: 1. 
[14:43:14] <alec> this is what I expected, changing default set of entitlements/skus is breaking a lot of tests 
[14:46:14] <alec> also phpstan has a lot to say
Jun 30 2021, 12:47 PM
machniak committed rRPK83d7667aca7e: Add missing icon for "Login As" input in Elastic skin(s).
Jun 30 2021, 12:00 PM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 10:27 AM
machniak added inline comments to D2635: Further changes to the reseller implementation.
Jun 30 2021, 9:42 AM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 8:41 AM

Jun 25 2021

machniak requested review of D2629: Fix duplicate SKUs listed in the user form.
Jun 25 2021, 7:55 AM

Jun 23 2021

machniak abandoned D2434: User controls over greylisting on the individual user basis, and SPF whitelisting for domains.

This diff is obviously broken. I updated the branch and created a new diff in https://git.kolab.org/D2623, as I wasn't able to update this one (arc diff was failing).

Jun 23 2021, 10:37 AM
machniak requested review of D2623: Greylisting + SPF.
Jun 23 2021, 10:24 AM
machniak committed rK780cfcd00fc2: Add @group to some tests.
Jun 23 2021, 10:20 AM
machniak requested review of D2617: Add tenant:create command.
Jun 23 2021, 9:07 AM

Jun 22 2021

machniak committed rK897ac4cf63a8: Merge branch 'dev/D2434' of ssh://git.kolab.org/source/kolab into dev/D2434.
Jun 22 2021, 1:51 PM
machniak committed rK6141a934bdb6: Fix various bugs and regressions (SPF/Greylist related).
Jun 22 2021, 1:51 PM
machniak committed rKb092e3716a6a: Bits of cleanup and further developing with rate limiting (authored by vanmeeuwen).
Jun 22 2021, 1:51 PM
machniak committed rK7c3e28002fc8: Things not found yield a 200 response code as well (authored by vanmeeuwen).
Jun 22 2021, 1:51 PM
machniak committed rK6b22c967553d: Trim trailing dots from the SPF whitelist entries (authored by vanmeeuwen).
Jun 22 2021, 1:51 PM
machniak committed rK94d067c05740: User controls over greylisting on the individual user basis, and SPF… (authored by vanmeeuwen).
Jun 22 2021, 1:51 PM
machniak committed rK0f7eddbb84a0: Greylisting/SPF UI.
Jun 22 2021, 1:51 PM
machniak committed rK2cc377b6e1a6: Preliminary implementation of a greylisting database and spf service (authored by vanmeeuwen).
Jun 22 2021, 1:51 PM
machniak closed T6640: RC 1.4.11 | RC Plugins kolab calendar 3.5.7 | bday calendar with carddav contacts as Invalid.

I'd say it's the carddav plugin issue. Maybe it does not "inject" its addressbook sources on task=calendar requests or sth like that.

Jun 22 2021, 9:18 AM · Roundcube Kolab Plugins , Bug Reports
machniak committed rK99df85eb7386: Support groups in Entitlement::entitleableTitle().
Jun 22 2021, 8:26 AM

Jun 21 2021

machniak updated the diff for D2371: Degraded accounts.
  • Rebase
Jun 21 2021, 12:18 PM
machniak requested review of D2611: Upgrade to PHPUnit v9, drop unused dependencies.
Jun 21 2021, 9:01 AM
machniak requested review of D2554: Add PGP keys generator.
Jun 21 2021, 8:02 AM
machniak updated the diff for D2554: Add PGP keys generator.
  • Rebase
Jun 21 2021, 8:01 AM
machniak updated the diff for D2554: Add PGP keys generator.
  • Add forgotten file
Jun 21 2021, 8:00 AM
machniak committed rK188b09b503e7: Fix test regression and one flaky assertion.
Jun 21 2021, 7:59 AM
machniak committed rK8304c5a72f94: UI localization.
Jun 21 2021, 7:59 AM
machniak closed D2581: UI localization.
Jun 21 2021, 7:59 AM

Jun 17 2021

machniak updated the diff for D2593: Update to Openvidu-browser 2.18.
  • Bump Openvidu version in Dockerfile
Jun 17 2021, 7:45 AM
machniak committed rKcddd31f4d0d2: Improve wallet() methods accuracy.
Jun 17 2021, 6:52 AM
machniak closed D2587: Improve wallet() methods accuracy.
Jun 17 2021, 6:52 AM
machniak committed rK3d33f21cfacc: Add slow requests log.
Jun 17 2021, 6:52 AM
machniak closed D2605: Add slow requests log.
Jun 17 2021, 6:52 AM
machniak committed rKb5af9125bba8: Improve themes, add some scss vars, add missing localization for the default….
Jun 17 2021, 6:52 AM
machniak closed D2599: Improve themes, add some scss vars, add missing localization for the default theme.
Jun 17 2021, 6:52 AM

Jun 16 2021

machniak requested review of D2605: Add slow requests log.
Jun 16 2021, 12:55 PM
machniak requested review of D2599: Improve themes, add some scss vars, add missing localization for the default theme.
Jun 16 2021, 11:19 AM

Jun 15 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • Generate a keypair for new alias
  • Unregister keys on alias delete
Jun 15 2021, 11:52 AM