Ignore exceptions

phpstan errors:

Line   app/Http/Controllers/API/AuthController.php                  
------ ------------------------------------------------------------- 
 157    Access to an undefined property object::$error_description.  
------ -------------------------------------------------------------

Included in the passport diff

Included the sql logging patch

Implemented in guam 91f1f2e5c7b2fb2d5c32ac463f37cac3b1ff078d

Addressed comments

I can't reproduce the test failures on my workstation. I'll try running the test on a separate system, to see if I can reproduce there.

Merged into dev/reseller

Didn't go through the tests yet.

• Add tests
• Debit reseller's wallet on user deletion (for the negative balance value)
• Credit/debit reseller's wallet on Penalize/Award action

In D2494#29305, @machniak wrote:

1. See inline comments

Got most tests to pass

• Migration fixes, tests fixes, added some simple tests

• Custom authentication hook for passport (so we can insert 2fa)
• Added 2fa to user verification
• Rely on second factor authentication in user model (instead of auth controller)
• Disabled unnecessary passport routes
• Fixed password-reset and signup to use the plain-text password for oauth

Rebase

Rebase

The same Groups/Distlist mix as the other diff, looks ok otherwise.

I thought we agreed on calling this Distlists instead of Groups (to leave "groups" as a more generic term for another feature), other than that this looks ok to me.

Merged into dev/reseller.

1. See inline comments
2. When logging into the user UI I see this in the log:

[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]

I.e. a duplicated query. Would be good to investigate why it is done twice.

3. Token refresh does not work. A scenario:
   • set token_expiry_minutes = 1 minute,
   • log in to the UI, and wait a minute,
   • you'll see that the refresh request returns 401 Unauthorized.
   • in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
   • I guess you just have to add refresh_token to the request in line 166 of app.js.
4. When runing Feature suite tests I got 3 errors:

1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput
ErrorException: Undefined property: stdClass::$access_token
2) Tests\Feature\Controller\SignupTest::testSignupValidInput
ErrorException: Undefined property: stdClass::$access_token
3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount
ErrorException: Undefined property: stdClass::$access_token

5. Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
6. We should think how deploy encryption keys across multiple hosts.
7. Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?

I ran into those with the pst import code.

Merged into dev/reseller.

Just the final fix, you can then ship it.

Correctly ignore the default migrations

Adjusted migrations (merged, foreign key constraint on user id pk, matching types)