Page MenuHomePhorge
Feed Search

Feb 1 2021

machniak committed rK8ca91d53f4fc: Fix connection role propagation to new connections.
Feb 1 2021, 10:47 AM
machniak committed rKd80c6c0ebeeb: Add tests for media setup dialog.
Feb 1 2021, 10:47 AM
machniak committed rK610cf13921c4: Fix test regressions.
Feb 1 2021, 10:47 AM
machniak committed rK4088e8d694b6: Media setup dialog.
Feb 1 2021, 10:47 AM
machniak committed rK918f5bfcbc2f: Test updateConnection endpoint.
Feb 1 2021, 10:47 AM
machniak committed rKbab58fac8f70: More tests.
Feb 1 2021, 10:47 AM
machniak committed rK6eb144d54850: Simplify resize() calls.
Feb 1 2021, 10:47 AM
machniak committed rK9b82d3a28500: Cleanup.
Feb 1 2021, 10:47 AM
machniak committed rK660032eb2a6f: Publisher-to-subscriber and vice-versa.
Feb 1 2021, 10:47 AM
machniak committed rK06226e33da8b: Tests: Use the menu when changing nickname.
Feb 1 2021, 10:47 AM
machniak committed rK1c61c1e36f17: Fix regressions.
Feb 1 2021, 10:47 AM
machniak committed rKb7baff245328: Use proper event system to handle audio/video status indication Add "Nickname"….
Feb 1 2021, 10:47 AM
machniak committed rKd0bfc17e4ba5: Improve menu layout.
Feb 1 2021, 10:47 AM
machniak committed rKff81deb8fecd: Publisher-to-subscriber and vice-versa.
Feb 1 2021, 10:47 AM
machniak updated the diff for D2197: Improve handling of screen-sharing connection tokens.
  • Fix type hint
Feb 1 2021, 10:32 AM
machniak requested review of D2197: Improve handling of screen-sharing connection tokens.
Feb 1 2021, 10:21 AM
machniak committed rRPK87fbaea6960a: PHP8 compatibility fixes.
Feb 1 2021, 7:31 AM
machniak closed D2185: PHP8 compatibility fixes.
Feb 1 2021, 7:30 AM · Roundcube Kolab Plugins
machniak committed rRPKfba24494dd26: Elastic dark mode.
Feb 1 2021, 7:25 AM
machniak closed D2179: Elastic dark mode.
Feb 1 2021, 7:25 AM

Jan 29 2021

machniak requested review of D2191: OpenVidu: Moderators.
Jan 29 2021, 9:43 AM

Jan 28 2021

machniak added a reviewer for D2185: PHP8 compatibility fixes: Roundcube Kolab Plugins Developers.
Jan 28 2021, 3:14 PM · Roundcube Kolab Plugins
machniak requested review of D2185: PHP8 compatibility fixes.
Jan 28 2021, 3:14 PM · Roundcube Kolab Plugins
machniak added a reviewer for D2179: Elastic dark mode: Roundcube Kolab Plugins Developers.
Jan 28 2021, 3:01 PM
machniak updated the diff for D2179: Elastic dark mode.

-fix

Jan 28 2021, 2:59 PM
machniak requested review of D2179: Elastic dark mode.
Jan 28 2021, 2:56 PM
machniak committed rRPK2bee26214028: Merge branch 'dev/dark-mode' of ssh://git.kolab.org/diffusion/RPK into dev/dark….
Jan 28 2021, 2:52 PM
machniak committed rRPKebf36c0a36ea: Fix compat. with lessjs v4.
Jan 28 2021, 2:51 PM
machniak committed rRPK8863dc521940: Fix compatibility with Roundcube 1.4.
Jan 28 2021, 2:51 PM
machniak committed rRPK3e6d66ac1102: Fix compat. with less.js v4.
Jan 28 2021, 2:51 PM
machniak committed rRPKc45cb992f440: Elastic dark mode.
Jan 28 2021, 2:51 PM
machniak added a member for Autoconf Developers: mollekopf.
Jan 28 2021, 2:49 PM
machniak accepted D2173: Support forcing a subscription state.

The disabled attribute value could be boolean not string, but it will work either way.

Jan 28 2021, 9:30 AM
machniak requested changes to D2173: Support forcing a subscription state.
Jan 28 2021, 8:46 AM

Jan 27 2021

machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
  • Media setup dialog
  • Fix test regressions
  • Add tests for media setup dialog
  • Fix connection role propagation to new connections
Jan 27 2021, 11:19 AM
machniak updated the diff for D2068: OpenVidu: Store join request identifier in localStorage.
  • Rebase
Jan 27 2021, 8:20 AM

Jan 26 2021

machniak updated the diff for D2167: Meet/Beta - private vs public beta.
  • Add missing migration file
Jan 26 2021, 4:13 PM
machniak requested review of D2167: Meet/Beta - private vs public beta.
Jan 26 2021, 3:53 PM
machniak requested review of D2167: Meet/Beta - private vs public beta.
Jan 26 2021, 3:53 PM
machniak planned changes to D2149: Publisher-to-subscriber and vice-versa.

I've found one issue. The role change is not propagated to new connections. Scenario:

  1. User1 joins as a subscriber
  2. Moderator promotes him to a publisher
  3. User2 joins and sees a UI issue, because the User1 tail is a subscriber-like tile, and there's a video element of User1 "out of the matrix".
Jan 26 2021, 12:15 PM
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Add tests for media setup dialog
Jan 26 2021, 11:31 AM
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Fix test regressions
Jan 26 2021, 10:53 AM
machniak accepted D2143: Remove folder typedata in-memory cache.
Jan 26 2021, 10:47 AM · Roundcube Kolab Plugins
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Media setup dialog
Jan 26 2021, 10:34 AM

Jan 22 2021

machniak committed rRPKf5678b7c5bf1: PHP8 fixes.
Jan 22 2021, 5:23 PM
machniak added a comment to D2143: Remove folder typedata in-memory cache.

If you think that this internal cache is not really needed then go this way and remove use of self::$typedata. In rare cases when we list folders for all folder types separately in a single request, we'll end up with several requests to the Roundcube imap cache, instead of one. I'm afraid that we might call folder_typedata() or folder_type() methods quite a lot, but I didn't check that, so I'm not sure.

Jan 22 2021, 12:55 PM · Roundcube Kolab Plugins
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
Jan 22 2021, 10:00 AM

Jan 21 2021

machniak requested review of D2149: Publisher-to-subscriber and vice-versa.
Jan 21 2021, 2:21 PM
machniak added a comment to D2143: Remove folder typedata in-memory cache.

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

Jan 21 2021, 11:09 AM · Roundcube Kolab Plugins
machniak added a comment to D2143: Remove folder typedata in-memory cache.

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

Jan 21 2021, 10:41 AM · Roundcube Kolab Plugins

Jan 19 2021

machniak committed rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions.
Jan 19 2021, 3:04 PM
machniak closed D2098: [MEET]: Generic implementation of Roles/Permissions.
Jan 19 2021, 3:04 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Fix typo
Jan 19 2021, 11:41 AM
machniak removed a member for Roundcube Kolab Plugins Developers: Adityab.
Jan 19 2021, 11:05 AM
machniak added a member for Roundcube Kolab Plugins Developers: mollekopf.
Jan 19 2021, 11:05 AM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
Jan 19 2021, 10:26 AM
machniak committed rK14d3d27bddef: Prevent double-submission of payments form.
Jan 19 2021, 10:12 AM
machniak closed D2104: Prevent double-submission of payments form.
Jan 19 2021, 10:12 AM
machniak committed rKab1b623aa93c: Update npm dependencies.
Jan 19 2021, 10:12 AM
machniak closed D2116: Update npm dependencies.
Jan 19 2021, 10:11 AM
machniak accepted D2056: Bump collectionChanges even if we failed to retrieve the entry..
Jan 19 2021, 10:07 AM
machniak accepted D2062: Compress pendingdata.
Jan 19 2021, 10:06 AM
machniak accepted D2092: Do not ignore INBOX for the displayed folder hierarchy.
Jan 19 2021, 10:04 AM
machniak added a comment to D2131: Avoid Sync unnecessary FolderSync interaction.

Wouldn't global STATUS_FOLDER_HIERARCHY_HAS_CHANGED status be more appropriate? Or this does not work with Outlook?

Jan 19 2021, 9:44 AM
machniak added a comment to D2128: A synckey that is not matching the server sync key is invalid..

This code is not supposed to be used by Kolab backend. We're using kolab_sync_backend_state::validate().

Jan 19 2021, 9:28 AM

Jan 18 2021

machniak committed rRPK625914a705b8: Fix PHP warnings, fix typo-regression in calendar preferences.
Jan 18 2021, 6:46 PM
machniak added a member for Chwala Developers: mollekopf.
Jan 18 2021, 12:56 PM
machniak accepted D2122: Pass on a language identifier even if we couldn't find a translation file.
Jan 18 2021, 12:29 PM
machniak added inline comments to D2122: Pass on a language identifier even if we couldn't find a translation file.
Jan 18 2021, 12:21 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Fix: session_id should be indexed but not unique
Jan 18 2021, 9:15 AM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Add unique key on openvidu_connections.session_id
Jan 18 2021, 8:07 AM

Jan 15 2021

machniak added a comment to D2092: Do not ignore INBOX for the displayed folder hierarchy.

I'm not sure I like this. While fixing the issue you also changed how the list will look like. I.e. flat list instead of a tree-like list. If we do this anyway we should do the same in kolab_delegation plugin.

Jan 15 2021, 2:24 PM
machniak updated the diff for D2116: Update npm dependencies.
  • Fix phpstan error and flaky tests
Jan 15 2021, 12:54 PM
machniak requested review of D2116: Update npm dependencies.
Jan 15 2021, 11:08 AM
machniak updated the diff for D2110: Fix cache reset in scalpel commands.
  • Add tests
Jan 15 2021, 8:30 AM
machniak requested review of D2110: Fix cache reset in scalpel commands.
Jan 15 2021, 8:10 AM

Jan 14 2021

machniak requested review of D2104: Prevent double-submission of payments form.
Jan 14 2021, 3:10 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Improve constants handling
Jan 14 2021, 1:24 PM
machniak requested review of D2098: [MEET]: Generic implementation of Roles/Permissions.
Jan 14 2021, 1:04 PM

Jan 13 2021

machniak requested review of D2086: Add scalpel:wallet-setting:update, scalpel:wallet-setting:create, scalpel:wallet:settings.
Jan 13 2021, 1:18 PM

Jan 9 2021

machniak committed rRPKe480f0c5f998: CS fixes, indentation.
Jan 9 2021, 9:24 AM

Jan 8 2021

machniak committed rRPKe7ef210689b5: PHP8 fixes.
Jan 8 2021, 2:02 PM
machniak updated the diff for D2068: OpenVidu: Store join request identifier in localStorage.
  • Fix browser tests regression
Jan 8 2021, 1:22 PM
machniak planned changes to D2068: OpenVidu: Store join request identifier in localStorage.
Jan 8 2021, 12:49 PM
machniak requested review of D2068: OpenVidu: Store join request identifier in localStorage.
Jan 8 2021, 12:45 PM
machniak updated the diff for D1924: Restoring a user/domain.
  • Complete restoring/restored events handlers in user and domain observers
  • Add test for user:restore command
  • Add domain:restore command
  • Set proper status in user/domain DeleteJob
Jan 8 2021, 12:21 PM
machniak retitled D1924: Restoring a user/domain from [Draft] Restoring a user account
Jan 8 2021, 11:21 AM
machniak updated the diff for D1924: Restoring a user/domain.
  • Set proper status in user/domain DeleteJob
Jan 8 2021, 11:21 AM
machniak updated the diff for D1924: Restoring a user/domain.
  • Complete restoring/restored events handlers in user and domain observers
  • Add test for user:restore command
  • Add domain:restore command
Jan 8 2021, 11:04 AM
machniak added a comment to D2062: Compress pendingdata.
  1. Did you check/estimate max number of messages we can handle with default 1MB packet?
  2. This requires php-zlib extension which is not a default. We should make sure it's marked as required in packaging, I guess.
  3. I'm not sure pushing compressed data into database is safe (without e.g. base64-encoding it).
Jan 8 2021, 7:46 AM
machniak added a comment to D2056: Bump collectionChanges even if we failed to retrieve the entry..

Also, maybe we should tackle this from a different angle. If the folder has been disabled why do we even attempt to sync anything from that folder. We should tell the client that a hierarchy changed. So, maybe the problem is somewhere else, and could be fixed in a better way. We of course can still keep this solution as it prevents from timeout issues caused by other factors.

Jan 8 2021, 7:34 AM

Jan 7 2021

machniak accepted D2050: Fix group creation / update issues.
Jan 7 2021, 11:14 AM

Jan 6 2021

machniak committed rRPK1cc788bedce0: PHP8 fixes.
Jan 6 2021, 7:35 PM
machniak committed rRPK9dbda8401ed5: PHP8 fixes, CS fixes, short array syntax, indentation.
Jan 6 2021, 7:35 PM
machniak requested review of D2044: Join video conference by pressing return key.
Jan 6 2021, 2:21 PM
machniak updated the diff for D2014: Integrate video chat into app.js (as an async component).
  • Fix unexpected logon form when accessing the room
Jan 6 2021, 1:10 PM
machniak updated the diff for D2014: Integrate video chat into app.js (as an async component).
  • Remove redundant code
Jan 6 2021, 11:04 AM

Jan 5 2021

machniak retitled D2014: Integrate video chat into app.js (as an async component) from [Draft] Integrate video chat into app.js (as an async component)
Jan 5 2021, 3:29 PM
machniak updated the diff for D2014: Integrate video chat into app.js (as an async component).
  • Corrected components lazy-loading + loader element
Jan 5 2021, 3:19 PM

Jan 4 2021

machniak committed rK08708e476aa8: OpenVidu: Add browser tests for screen sharing.
Jan 4 2021, 11:59 AM