@adomaitis this depends on some earlier commit: https://git.kolab.org/rRPK2ad0d6651dfbcb32c146465ad9539848b285e3f9

What is more. When user receives iTip response for an exception and updates the event, Outlook will incorrectly send Sync-Add command for the new exception, which then creates a duplicate object. Which leads to a "missing" event in Roundcube and error in syncroton log. This in itself is another issue, but I see that with correct ExceptionStartTime Outlook does not send such requests.

@vanmeeuwen, this is still broken. Could you take a look?

Fixed in 6046b4085ae.

The code that does not support these is:

$subnet = ip2long($subnet);
$mask = -1 << $bits;
$subnet &= $mask;  // just in case the supplied subnet wasn't correctly aligned
if (($ipbin & $mask) == $subnet) {
    return true;
}

in Utils::checkIpRange().

Fixed in a60c81d1b [master] and f9151f6830 [release-1.2]

So, I started working on this. I thought it's reasonably simple to implement, but testing this with Outlook 2013 I see a lot of strange comminication that is not described in the documentation. It sends redundant Sync commands with event updates, so in the end, after accepting an invitation the event ends up being still in un-responded state.

Fixed by 0c02d0d45c6 in roundcubemail-plugins-kolab [master].

I verified with the code that if the original event would specify SCHEDULE-AGENT=CLIENT for the attendee it would be properly recognized by SabreDAV classes and the CANCEL would not be sent. So, what we need is to store this initial SCHEDULE-AGENT value in custom properties of Kolab format (or extend the format of https://wiki.kolab.org/User:Mollekopf/Drafts/KEP:17#Attendee).

Looks good to me. You can remove also COMMASPACE = ', ' line as we don't use this var anymore.

This way you can end up with true. I'd rather make sure $relation['members'] is an array. e.g.

'members' => implode("\n", (array) $relation['members']),

However, https://tools.ietf.org/html/rfc6638#section-3.2.1.2 says that CANCEL is sent when an event was modified and previous scheduling was done by the server (default if SCHEDULE-AGENT is not specified). So, probably the issue is in recognizing the previous state.

@vanmeeuwen, what's your take on this?

Fixed in bf4326c834 [master].

I can confirm that. In my test it does not find messages even if they use UTF-8/8bit encoding, i.e. no decoding is required. Maybe squatter handles that better, I don't know.

Still can't find the way to reproduce the issue. Another source informed us that it had the same issue and there was CalDAV client involved. I reviewed the code and I don't see what actions could lead to such invalid timezone entries. Here's a patch that we could use, but I think the issue is in another place:

--- a/plugins/calendar/calendar.php
+++ b/plugins/calendar/calendar.php
@@ -1974,6 +1974,8 @@ class calendar extends rcube_plugin
    */
   private function write_preprocess(&$event, $action)
   {
+    $event['start'] = preg_replace('/\s*\(.*\)/', '', $event['start']);
+    $event['end']   = preg_replace('/\s*\(.*\)/', '', $event['end']);
     // convert dates into DateTime objects in user's current timezone
     $event['start']  = new DateTime($event['start'], $this->timezone);
     $event['end']    = new DateTime($event['end'], $this->timezone);

That looks like simple mistake in the code. Fixed in rRPKc2e8cc16abf3.

Fixed.

@adomaitis Looks like both DayOfWeek and Until are optional. In this case I think we just should not include DayOfWeek in the response. Did you test that?

Not exactly the same error, but we have already T2163.

1. So, the iTips differ not much. I don't think CLASS:PUBLIC is relevant.
2. I think it's possible. When the event time changes client could request "re-sheduling". You'd need to see what's in G's iTip in step 4.

We'd need to see iTip payload. I guess that in step 4, the event is in "re-sheduling" mode, i.e. the attendee status is re-set to NEEDS-ACTION. In such a case (and settings) wallace will not respond with ACCEPT. I have no idea what could be different in iTip replies sent in step 2 and 6.

FYI, Collabora Online 2.1.2 added support for avatars and custom button. So, technically it should be possible to move all our functionality into the editor frame.

Fixed.

SendResponse element was added in version >=16.0 of the ActiveSync protocol, which means it is optional and can be excluded from the initial implementation. Also, from what I see it is about calendar events. I didn't found any information about handling of iTips for TODO (tasks), so they are probably ignored.

Add note about uid and changed fields

One additional change is required in the ldap_public config:

Note: To make the LDAP addressbook sources working we need two additional
	//       fields ('uid' and 'changed') specified in the fieldmap array
	//       of the LDAP configuration ('ldap_public' option). For example:
	//          'uid'     => 'nsuniqueid',
	//          'changed' => 'modifytimestamp',

Describe new blacklist and GAL options

This is done. Required configuration for Outlook:

$config['activesync_gal_sync'] = array('windowsoutlook');
$config['activesync_multifolder_blacklist_contact'] = array('windowsoutlook');

1-3 is fixed via merged D204.

Search for files with content "FLE Daylight Time" in /var/spool/imap/domain/ and provide a sample file.