Page MenuHomePhorge
Create Task
Maniphest T2549

kolab freebusy doesn't understand network/subnet definition in trustednetworks
Closed, ResolvedPublic
Actions

Description

kolab-freebusy-1.1-2.16.el7.kolab_16.noarch
I'm trying to allow all IP's to access the freebusy service by modifying trustednetworks section in config.ini file:

[trustednetworks]
; allow = ::1,127.0.0.1,104.0.0.0.0/0,0/0
allow = ::1,127.0.0.1,0.0.0.0-255.255.255.255

The commented line doesn't work - meaning that freebusy is still asking me to authenticate. The only config that works is uncommented line.

Details

Ticket Type
Task

Related Objects

Event Timeline

adomaitis created this task.Jul 17 2017, 12:20 PM
adomaitis added a project: Free/Busy.
adomaitis added a subscriber: Free/Busy Developers.
machniak subscribed.Jul 17 2017, 12:29 PM

The code that does not support these is:

$subnet = ip2long($subnet);
$mask = -1 << $bits;
$subnet &= $mask;  // just in case the supplied subnet wasn't correctly aligned
if (($ipbin & $mask) == $subnet) {
    return true;
}

in Utils::checkIpRange().

machniak mentioned this in rF6046b4085ae4: T2549: Special entries in trustednetworks.allow to allow all IPs.Jul 17 2017, 1:49 PM
machniak closed this task as Resolved.Jul 17 2017, 1:49 PM
machniak claimed this task.

Fixed in 6046b4085ae.