Page MenuHomePhorge
Feed Advanced Search

Feb 24 2017

machniak added a project to T1853: Syncroton - Missing ldap_close function in kolab_auth.php: Kolab Enterprise 14.
Feb 24 2017, 10:13 AM · Kolab Enterprise 14, Kolab 16, Bug Reports
machniak closed T1853: Syncroton - Missing ldap_close function in kolab_auth.php as Resolved.

Done in 99cd2b17522.

Feb 24 2017, 10:12 AM · Kolab Enterprise 14, Kolab 16, Bug Reports
machniak reopened T1853: Syncroton - Missing ldap_close function in kolab_auth.php as "Open".

Actually the change need to be backported from master to roundcubemail-plugins-kolab-3.2 branch.

Feb 24 2017, 10:12 AM · Kolab Enterprise 14, Kolab 16, Bug Reports
machniak committed rRPK99cd2b175221: T1521: kolab_auth: Add possibility to close LDAP connection on request (authored by machniak).
T1521: kolab_auth: Add possibility to close LDAP connection on request
Feb 24 2017, 10:10 AM

Feb 21 2017

machniak retitled D393: Fix PHP Warning: Invalid argument supplied for foreach() (T2265) from
Feb 21 2017, 4:05 PM
machniak added a revision to T2265: PHP Warning: Invalid argument supplied for foreach(): D393: Fix PHP Warning: Invalid argument supplied for foreach() (T2265).
Feb 21 2017, 4:05 PM · iRony
machniak closed T2250: PHP Fatal error when moving/copying/updating a file via WebDAV as Resolved.
Feb 21 2017, 4:02 PM · Kolab 16, iRony, Chwala
machniak committed rC0413beda3d92: Fix PHP Fatal error: Call to undefined method file_api_file_move… (authored by machniak).
Fix PHP Fatal error: Call to undefined method file_api_file_move…
Feb 21 2017, 4:02 PM
machniak created T2265: PHP Warning: Invalid argument supplied for foreach().
Feb 21 2017, 3:43 PM · iRony
machniak added a comment to T2250: PHP Fatal error when moving/copying/updating a file via WebDAV.

To reproduce the issue just try to rename a file over WebDAV.

Feb 21 2017, 3:37 PM · Kolab 16, iRony, Chwala
machniak added a revision to T2262: Failed to create WebDAV folder on root level: D390: Fix creating files folders on highest level of the folder hierarchy (T2262).
Feb 21 2017, 3:33 PM · iRony
machniak retitled D390: Fix creating files folders on highest level of the folder hierarchy (T2262) from
Feb 21 2017, 3:33 PM
machniak created T2262: Failed to create WebDAV folder on root level.
Feb 21 2017, 3:30 PM · iRony
machniak added a revision to T2259: PHP Warning: rewind(): stream does not support seeking: D387: Fix PHP Warning: rewind(): stream does not support seeking (T2259).
Feb 21 2017, 3:20 PM · iRony
machniak retitled D387: Fix PHP Warning: rewind(): stream does not support seeking (T2259) from
Feb 21 2017, 3:20 PM
machniak created T2259: PHP Warning: rewind(): stream does not support seeking.
Feb 21 2017, 3:16 PM · iRony
machniak added a revision to T2253: PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN': D384: Fix PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN' (T2253).
Feb 21 2017, 3:11 PM · iRony
machniak retitled D384: Fix PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN' (T2253) from Fix PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN' (#2253)
Feb 21 2017, 3:11 PM
machniak retitled D384: Fix PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN' (T2253) from to Fix PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN' (#2253).
Feb 21 2017, 2:55 PM
machniak created T2253: PHP Fatal error: Undefined class constant 'ERROR_FORBIDDEN'.
Feb 21 2017, 2:49 PM · iRony
machniak added a project to T2250: PHP Fatal error when moving/copying/updating a file via WebDAV: Kolab 16.
Feb 21 2017, 1:09 PM · Kolab 16, iRony, Chwala
machniak created T2250: PHP Fatal error when moving/copying/updating a file via WebDAV.
Feb 21 2017, 1:02 PM · Kolab 16, iRony, Chwala
machniak added a comment to T2205: chwala and seafile on a hidden server [patch].

So, this would load the whole file into memory. Not something we'd like to do. So, first of all this probably should be an optional feature. Second, we should use seafile_request_observer to proxy the file content directly to the client. See seafile_file_storage::save_file_content(). Would you like to create a differential?

Feb 21 2017, 12:53 PM · Chwala, Bug Reports

Feb 20 2017

machniak committed rRPK45ce87f5459f: Remove duplicates on cache synchronization. (authored by machniak).
Remove duplicates on cache synchronization.
Feb 20 2017, 12:13 PM
machniak committed rRPK5dddb7a8872c: Remove duplicates on cache synchronization. (authored by machniak).
Remove duplicates on cache synchronization.
Feb 20 2017, 12:12 PM

Feb 17 2017

machniak committed rRPKeac7bcf4d2eb: Improvements on "Remove tag" selection list (Bifrost#T20281) (authored by machniak).
Improvements on "Remove tag" selection list (Bifrost#T20281)
Feb 17 2017, 12:44 PM
machniak committed rRPKfebb0d4bfa17: Improvements on "Remove tag" selection list (Bifrost#T20281) (authored by machniak).
Improvements on "Remove tag" selection list (Bifrost#T20281)
Feb 17 2017, 12:43 PM
machniak committed rRSC1876d1860cc2: Fix tag actions icon :hover style when the action is disabled (authored by machniak).
Fix tag actions icon :hover style when the action is disabled
Feb 17 2017, 12:23 PM
machniak committed rRPK8044f158db8b: Fix missing tags on messages list in Roundcube 1.3 widescreen mode (authored by machniak).
Fix missing tags on messages list in Roundcube 1.3 widescreen mode
Feb 17 2017, 10:46 AM

Feb 13 2017

machniak committed rRPK159025d14262: Fix race conditions in Tasks UI that can cause drag-n-drop issues… (authored by machniak).
Fix race conditions in Tasks UI that can cause drag-n-drop issues…
Feb 13 2017, 10:26 AM
machniak committed rRPK231bedba3a4e: Fix race conditions in Tasks UI that can cause drag-n-drop issues… (authored by machniak).
Fix race conditions in Tasks UI that can cause drag-n-drop issues…
Feb 13 2017, 10:23 AM

Feb 10 2017

machniak added a comment to T2223: Outlook and folders under INBOX.

@adomaitis, committed 1d7e1237f2d to master. I don't know if there's anything more we can do here.

Feb 10 2017, 11:24 AM · Syncroton, Bug Reports
machniak committed rS1d7e1237f2dd: Nicely handle errors on FolderCreate (T2223) (authored by machniak).
Nicely handle errors on FolderCreate (T2223)
Feb 10 2017, 11:04 AM

Feb 9 2017

machniak added a comment to T2235: Syncroton + Outlook 2013 - folder rename does not work correctly.

Confirmed. The problem here is that Outlook completely ignores the error we send in response to Sync request (after FolderUpdate). It should re-synchronize folders hierarchy according to the protocol specification.

Feb 9 2017, 4:22 PM · Syncroton, Bug Reports
machniak added a comment to T2223: Outlook and folders under INBOX.

@adomaitis I'm testing a fix and can't make Outlook display an error. I tried valid ActiveSync response with different error codes and even http error 500. In all cases Outlook just ignores the error and displays the folder as any other folder. So, while I'll commit the change it looks that it's not possible to tell Outlook the operation failed.

Feb 9 2017, 2:56 PM · Syncroton, Bug Reports
machniak retitled D378: Fix and unify IMAP reconnection on folder create with Murder (Bifrost#T23626) from
Feb 9 2017, 10:21 AM

Feb 8 2017

machniak committed rRPK0d02866be6f5: Improved organizer handling on a shared event (Bifrost#T23218) (authored by machniak).
Improved organizer handling on a shared event (Bifrost#T23218)
Feb 8 2017, 7:29 PM
machniak committed rRPKb5ceae7d2dc5: Improved organizer handling on a shared event (Bifrost#T23218) (authored by machniak).
Improved organizer handling on a shared event (Bifrost#T23218)
Feb 8 2017, 7:27 PM

Feb 7 2017

machniak committed rRPKedf07aa32c87: Ignore iTip attachments in multipart/report messages (Bifrost#T20440) (authored by machniak).
Ignore iTip attachments in multipart/report messages (Bifrost#T20440)
Feb 7 2017, 1:10 PM
machniak committed rRPK2742a8e2dedb: Ignore iTip attachments in multipart/report messages (Bifrost#T20440) (authored by machniak).
Ignore iTip attachments in multipart/report messages (Bifrost#T20440)
Feb 7 2017, 1:09 PM
machniak added a comment to T1401: Kolab Winterfell Installation bug report on Debian Jessie.

I tried installing Kolab 16 (from OBS as of today) on Jessie.
From all the above issues I confirm issues 2.1, 5 and 6.

Feb 7 2017, 11:59 AM · Jessie, Bug Reports

Feb 6 2017

machniak added a comment to T2223: Outlook and folders under INBOX.

Note to myself: See https://msdn.microsoft.com/en-us/library/gg651087(v=exchg.80).aspx for list of possible error status codes. Looks like code 3 might suit the best this case, but there are a few other cases that we might want to distinguish in error code.

Feb 6 2017, 2:47 PM · Syncroton, Bug Reports
machniak added a comment to T2223: Outlook and folders under INBOX.

Looks like you are right. There's a TODO entry in the folder creation code to throw exception on error, but it's not implemented and indeed no error is returned to the client. However, throwing an exception here is not enough, we need some more code in the Syncroton library itself to handle nicely the exception (returning properly formatted response instead of just a http error).

Feb 6 2017, 2:40 PM · Syncroton, Bug Reports
machniak added a comment to rKCdc0565751e0f: Use Amnesia, get rid of Ecto.

As you can see in the Details section above, it is in develop.

Feb 6 2017, 10:52 AM
machniak closed T1829: IRC meeting for Kolab 16 on Debian as Invalid.
Feb 6 2017, 9:51 AM · Stretch, Jessie
machniak added a project to T1401: Kolab Winterfell Installation bug report on Debian Jessie: Jessie.
Feb 6 2017, 9:50 AM · Jessie, Bug Reports

Feb 3 2017

machniak added a comment to T1394: jessie installation is installing the community edition skin..

See also T2208.

Feb 3 2017, 10:47 AM · Wheezy, Kolab Enterprise 14, Jessie, Bug Reports
machniak added a comment to T2208: Debian/Jessie: roundcubemail contains empty directory skins/kolab.

We should also remove the old classic skin. Some kolab plugins just does not work with classic skin.

Feb 3 2017, 10:44 AM · Jessie, Bug Reports

Feb 2 2017

machniak committed rRPK09f4b068757d: Fix some missing localization labels (authored by machniak).
Fix some missing localization labels
Feb 2 2017, 12:01 PM
machniak committed rRPKfeb4d9dbba1f: Fix some missing localization labels (authored by machniak).
Fix some missing localization labels
Feb 2 2017, 12:01 PM
machniak committed rRPK22a1d82f107b: Allow Status:Tentative (Bifrost#T15994) (authored by machniak).
Allow Status:Tentative (Bifrost#T15994)
Feb 2 2017, 11:21 AM
machniak committed rRPKd4e66f9bbb91: Allow Status:Tentative (Bifrost#T15994) (authored by machniak).
Allow Status:Tentative (Bifrost#T15994)
Feb 2 2017, 11:20 AM
machniak added a comment to T2118: Rooms/Channels API design.

@seigo, I started working on a 1:1 chat. Creating and using a chat is simple. Problem is with invitations/notifications. I suppose we'd need some kind of event system. Consider scenario:

  1. UserA first time wants to talk with UserB
  2. UserB is notified about "incoming chat". He joins the conversation.
  3. UserB disconnects, closes the chat window. Then connects again.
  4. UserA want's still to talk with UserB again.
Feb 2 2017, 10:13 AM · Kolab Chat

Feb 1 2017

machniak closed T2124: User status as Resolved.
Feb 1 2017, 11:16 AM · Kolab Chat
machniak closed T2124: User status, a subtask of T2109: User presence persistence, as Resolved.
Feb 1 2017, 11:16 AM · Kolab Chat
machniak closed T2115: Internal design considerations - users as Resolved.
Feb 1 2017, 11:16 AM · Kolab Chat
machniak closed T2109: User presence persistence as Resolved.
Feb 1 2017, 11:15 AM · Kolab Chat
machniak committed rKCa9c74d5219fc: Make context optional (authored by machniak).
Make context optional
Feb 1 2017, 10:51 AM

Jan 31 2017

machniak committed rKCd559d48cd134: User status persistence (authored by machniak).
User status persistence
Jan 31 2017, 2:03 PM
machniak committed rKC81943deedb58: Merge branch 'develop' into dev-status-context (authored by machniak).
Merge branch 'develop' into dev-status-context
Jan 31 2017, 2:03 PM
machniak committed rKC4355ac6fac4b: Don't update presence on invalid status (authored by machniak).
Don't update presence on invalid status
Jan 31 2017, 2:03 PM
machniak committed rKC3d0604c56921: Implement more status values (T2124) (authored by machniak).
Implement more status values (T2124)
Jan 31 2017, 2:03 PM
machniak committed rKC61cf7036b9b0: Better status/presence handling (T2109) (authored by machniak).
Better status/presence handling (T2109)
Jan 31 2017, 2:03 PM
machniak closed D363: Better status/presence handling (T2109) by committing rKC61cf7036b9b0: Better status/presence handling (T2109).
Jan 31 2017, 2:03 PM

Jan 30 2017

machniak committed rKC58fb220ad1d6: Merge branch 'feature/amnesia' into develop (authored by machniak).
Merge branch 'feature/amnesia' into develop
Jan 30 2017, 12:11 PM
machniak committed rKCdc0565751e0f: Use Amnesia, get rid of Ecto (authored by machniak).
Use Amnesia, get rid of Ecto
Jan 30 2017, 12:11 PM
machniak closed D369: Use Amnesia, get rid of Ecto by committing rKCdc0565751e0f: Use Amnesia, get rid of Ecto.
Jan 30 2017, 12:11 PM

Jan 20 2017

machniak committed rRPK37a97639425f: Fix "unknown" dates in event dialog (Bifrost#T21544) (authored by machniak).
Fix "unknown" dates in event dialog (Bifrost#T21544)
Jan 20 2017, 10:39 AM
machniak committed rRPK853860e9b244: Merge branch 'master' of ssh://git.kolab.org/diffusion/RPK/roundcubemail… (authored by machniak).
Merge branch 'master' of ssh://git.kolab.org/diffusion/RPK/roundcubemail…
Jan 20 2017, 10:39 AM
machniak committed rRPKd6ea9104ba77: Fix "unknown" dates in event dialog (Bifrost#T21544) (authored by machniak).
Fix "unknown" dates in event dialog (Bifrost#T21544)
Jan 20 2017, 10:39 AM

Jan 18 2017

machniak retitled D369: Use Amnesia, get rid of Ecto from
Jan 18 2017, 2:03 PM
machniak added a comment to D363: Better status/presence handling (T2109).

Two connections with the same user and context should "share" the status, i.e. the status should always be the same for them. If you change status in one window it should change in other windows for the same user+context.
I don't see how a separate channel can help here. Maybe using system:<context> as a channel name would help. I don't know, Presence will still see these two connections as separate. No? Feel free to fix this.

Jan 18 2017, 10:54 AM

Jan 17 2017

machniak added a comment to T2115: Internal design considerations - users.

@seigo, what do you think about use of https://github.com/meh/amnesia ?

Jan 17 2017, 12:47 PM · Kolab Chat
machniak added a comment to D363: Better status/presence handling (T2109).

Presence maybe is nice chunk of code, but still we need to implement:

  1. last status persistence. I'm not even sure how to implement that, what's the "last status" of the user if he uses multiple clients? But I think it would be reasonable to not force "online" status when user connects to the service. Or should we only store status in a session? So only connection with expired session will set the status to "online".
  2. the context handling and best availability status setting should be done server-side, for privacy and performance reasons.
  3. if some user is not connected no one will see him as an existing user and will not be able to invite him - we need a user list on the server that is not based on Presence.
Jan 17 2017, 11:53 AM
machniak updated the diff for D363: Better status/presence handling (T2109).

Don't update presence on invalid status

Jan 17 2017, 11:43 AM

Jan 16 2017

machniak updated the diff for D363: Better status/presence handling (T2109).

Implement more status values (T2124)

Jan 16 2017, 12:30 PM
machniak added a comment to T2109: User presence persistence.

See D363. Still I prefer to use system channel for presence operations. Additionally implemented "client context". Still does not implement status persistence.

Jan 16 2017, 10:21 AM · Kolab Chat
machniak retitled D363: Better status/presence handling (T2109) from
Jan 16 2017, 10:19 AM

Jan 12 2017

machniak added a comment to T2187: 'bool' object has no attribute 'lower' from pykolab/imap/_init_.py", line 832 after "pykolab.imap ERROR Could not create ..." (MIGMAK-751).

Proposed fix:

-- a/pykolab/auth/ldap/__init__.py
+++ b/pykolab/auth/ldap/__init__.py
@@ -1683,6 +1683,8 @@ class LDAP(pykolab.base.Base):
                     entry[mailserver_attribute]
                 )
Jan 12 2017, 7:37 PM · PyKolab, Bug Reports
machniak committed rRPK2ebd853f4dd3: Doc: Add note about "--" selection in invitation handler (Bifrost#T20284) (authored by machniak).
Doc: Add note about "--" selection in invitation handler (Bifrost#T20284)
Jan 12 2017, 11:44 AM
machniak committed rRPK861a49918204: Doc: Add note about "--" selection in invitation handler (Bifrost#T20284) (authored by machniak).
Doc: Add note about "--" selection in invitation handler (Bifrost#T20284)
Jan 12 2017, 11:44 AM

Jan 11 2017

machniak added a comment to T2115: Internal design considerations - users.

We already use Phoenix.Token for user authentication tokens. But I don't understand for what you propose to use it. User metadata? I suppose not for anything else?

Jan 11 2017, 11:18 AM · Kolab Chat

Jan 10 2017

machniak added a comment to T2109: User presence persistence.

@seigo, I'm having trouble with this. Would you mind taking a look? I thought it will be a simple change in system_channel.ex, but I can't make it working.

Jan 10 2017, 1:57 PM · Kolab Chat
machniak added a comment to T2109: User presence persistence.

We already use (authenticated) system channel for that and I think it should/can be used still. I just wasn't sure channel about data persistence or channel data size limitations. So, it looks that if we use the system channel all we need is to properly handle user joins to the channel. I'll go this route for now.

Jan 10 2017, 11:23 AM · Kolab Chat
machniak added a comment to T2115: Internal design considerations - users.

@seigo, I'm not sure we can do it without SQL, how about invitations? I'm thinking of a case of "I'm logging in, give me all pending invitations". I don't think we can store invitations inside a chat. I'm used to use relational databases and can't imagine how to use key/value store here.

Jan 10 2017, 10:58 AM · Kolab Chat

Jan 4 2017

machniak added a comment to T2175: Download all attachments in Roundcube.

This is already implemented. Enable zipdownload plugin and make sure php-zip is installed.

Jan 4 2017, 6:50 PM · Roundcube, Architecture & Design
machniak added a comment to T917: libcalendaring creates broken undefined RDATE rules.

I'm unable to reproduce this with Roundcube Calendar. So, it might be already fixed or the bug is in iRony.

Jan 4 2017, 11:41 AM · Roundcube Kolab Plugins , iRony
machniak committed rRPKbd0e027e2863: Prevent from adding delegation for the same user many times (Bifrost#T20383) (authored by machniak).
Prevent from adding delegation for the same user many times (Bifrost#T20383)
Jan 4 2017, 11:15 AM
machniak committed rRPKf67df88238d1: Prevent from adding delegation for the same user many times (Bifrost#T20383) (authored by machniak).
Prevent from adding delegation for the same user many times (Bifrost#T20383)
Jan 4 2017, 11:15 AM
machniak committed rRPK919797a09201: Fix delegatedto/delegatedfrom labels (Bifrost#T20377) (authored by machniak).
Fix delegatedto/delegatedfrom labels (Bifrost#T20377)
Jan 4 2017, 9:19 AM
machniak committed rRPKbfa8ff2a677d: Fix delegatedto/delegatedfrom labels (Bifrost#T20377) (authored by machniak).
Fix delegatedto/delegatedfrom labels (Bifrost#T20377)
Jan 4 2017, 9:18 AM

Jan 3 2017

machniak closed T1895: Presence as Resolved.
Jan 3 2017, 12:59 PM · Kolab Chat
machniak committed rKCc757f6973e81: Text chat (using public room) (authored by machniak).
Text chat (using public room)
Jan 3 2017, 12:59 PM
machniak committed rKCd6b1c4f000b0: Install bootstrap js/fonts and jquery (authored by machniak).
Install bootstrap js/fonts and jquery
Jan 3 2017, 12:59 PM
machniak committed rKCd6d297b3adba: User status (presence) (authored by machniak).
User status (presence)
Jan 3 2017, 12:59 PM
machniak committed rKCe9998e5d7fe4: Initial websocket comminication with auth tokens (authored by machniak).
Initial websocket comminication with auth tokens
Jan 3 2017, 12:59 PM
machniak closed D351: Websockets, auth tokens, presence, text chat by committing rKCe9998e5d7fe4: Initial websocket comminication with auth tokens.
Jan 3 2017, 12:59 PM
machniak closed T1582: (Calendar) Interpretation of BYSETPOS in RRULE as Resolved.
Jan 3 2017, 12:44 PM · Kolab Enterprise 14, Kolab 16, Roundcube Kolab Plugins
machniak committed rRPKe9545b9eef8b: T1582: Support BYSETPOS recurrence on event import (authored by machniak).
T1582: Support BYSETPOS recurrence on event import
Jan 3 2017, 12:43 PM
machniak committed rRPK8edb261a0b8c: T1582: Support BYSETPOS recurrence on event import (authored by machniak).
T1582: Support BYSETPOS recurrence on event import
Jan 3 2017, 12:42 PM