Use Amnesia, get rid of Ecto
ClosedPublic

Authored by machniak on Jan 18 2017, 2:03 PM.

Details

Summary

@seigo, I'm not sure about these "require Amnesia" statements

Diff Detail

Repository
rKC kolab-chat
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
machniak retitled this revision from to Use Amnesia, get rid of Ecto.Jan 18 2017, 2:03 PM
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: Kolab Chat Developers.
machniak added a subscriber: seigo.
seigo accepted this revision.Jan 20 2017, 10:55 AM
seigo added a reviewer: seigo.

Those require statements look fine IMHO. Yes, it's a bit more verbose that one could imagine if it were placed somewhere central, but at least this way it is explicit: this code requires that API .. and so it says so right there. That kind of clarity makes that extra line worth it ... +1 from me.

This revision is now accepted and ready to land.Jan 20 2017, 10:55 AM
This revision was automatically updated to reflect the committed changes.