Differential D369

Use Amnesia, get rid of Ecto
ClosedPublic
Actions

Authored by machniak on Jan 18 2017, 2:03 PM.

Tags

None

Referenced Files

	F15346587: D369.id.diff
	Mon, Sep 16, 2:23 PM

	Unknown Object (File)
	Sat, Sep 7, 5:51 AM

	Unknown Object (File)
	Sat, Sep 7, 4:09 AM

	Unknown Object (File)
	Wed, Sep 4, 7:31 AM

	Unknown Object (File)
	Fri, Aug 30, 9:20 PM

	Unknown Object (File)
	Thu, Aug 29, 3:33 PM

	Unknown Object (File)
	Sat, Aug 24, 8:47 AM

	Unknown Object (File)
	Thu, Aug 22, 11:29 AM

Subscribers

Details

Reviewers

Group Reviewers

Kolab Chat Developers

Commits

rKCdc0565751e0f: Use Amnesia, get rid of Ecto

Summary

@seigo, I'm not sure about these "require Amnesia" statements

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 846.Jan 18 2017, 2:03 PM

machniak retitled this revision from to Use Amnesia, get rid of Ecto.

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: Kolab Chat Developers.

machniak added a subscriber: • seigo.

Those require statements look fine IMHO. Yes, it's a bit more verbose that one could imagine if it were placed somewhere central, but at least this way it is explicit: this code requires that API .. and so it says so right there. That kind of clarity makes that extra line worth it ... +1 from me.

This revision is now accepted and ready to land.Jan 20 2017, 10:55 AM

Closed by commit rKCdc0565751e0f: Use Amnesia, get rid of Ecto (authored by machniak, committed by machniak). · Explain WhyJan 30 2017, 12:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

config/

1 line

9 lines

9 lines

lib/

2 lines

kolab_chat/

19 lines

9 lines

11 lines

web/

channels/

5 lines

controllers/

auth_controller.ex

21 lines

plugs/

14 lines

models/

19 lines

Diff 855

README.md

Loading...

config/config.exs

Loading...

config/dev.exs

Loading...

config/test.exs

Loading...

lib/kolab_chat.ex

Loading...

lib/kolab_chat/database.ex

Loading...

lib/kolab_chat/repo.ex

Loading...

mix.exs

Loading...

mix.lock

Loading...

web/channels/user_socket.ex

Loading...

web/controllers/auth_controller.ex

Loading...

web/controllers/plugs/set_user.ex

Loading...

web/models/user.ex

Loading...

web/web.ex

Loading...