@seigo, I'm not sure about these "require Amnesia" statements
Details
Details
- Reviewers
• seigo - Group Reviewers
Kolab Chat Developers - Commits
- rKCdc0565751e0f: Use Amnesia, get rid of Ecto
Diff Detail
Diff Detail
- Repository
- rKC kolab-chat
- Branch
- feature/amnesia
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 7785 Build 7989: arc lint + arc unit
Event Timeline
Comment Actions
Those require statements look fine IMHO. Yes, it's a bit more verbose that one could imagine if it were placed somewhere central, but at least this way it is explicit: this code requires that API .. and so it says so right there. That kind of clarity makes that extra line worth it ... +1 from me.