Any updates when this will land?

PHP >= 7.1 compat. issue. Fixed.

In T1141#17069, @machniak wrote:

This scenario is not possible at the moment and because SeaFile has it's own WebDAV service I'm not sure there's a need to use iRony for that. You can configure iRony to provide CalDAV and CardDAV only if needed.

Correcting the priority from 60/40 to Normal

This ticket is no longer relevant.

This ticket is no longer relevant.

Fixed.

Fixed in 57e061251ee.

Fixed in 876c956c24a4d.

So maybe we can just change in:

$size = $response['headers']['content-length'][0];

Looks like the fix in https://git.kolab.org/rC3b776f3a10e2443c0e47d331333265f9c75d7392 wasn't correct. We need to just support both cases.

I didn't logged the $response, good point. The server is returning the header but I think the format is different.

So, your webdav server does not return Content-Length or the http client code is buggy? Did you try to log response headers ($response['headers'])?

Fixed.

I've replaced the https_check() function with

As far as I can trace the calls back... our old friend api_url() is used to create the base URL and the scheme depends only on rcube_utils::https_check() and nothing else.
If the scheme "http" is used this can only mean, that rcube_utils::https_check() returned false - please correct me, if I'm wrong. Perhaps we should have a look at it next.

https://git.kolab.org/diffusion/C/browse/master/lib/viewers/text.php;0349c2d846613e4c828ed6f7af00b87ed6a75f79$120

I've changed the file_api_url setting to some nonsense for testing purposes... Of course, it does not work, but the changed URL is passed along.

I've created a new text file and tried to open it. Same issue :-(

In this case it is Roundcube connecting to Chwala directly. It looks like the config has been ignored. I have no idea how's that possible. Maybe there's something in between that caches the request and returns old response? Check with a different file.

Is there anything I can do to help you to diagnose it?

I've set in kolab_files.inc.php

But it should work if you set file_api_url to a full url with https:// prefix? Do you set options in /etc/roundcubemail/config.inc.php? I'm unable to reproduce.

Yes, I've set use_https to true and applied the mentioned fixes. I'm sorry, but the issue persists :-/

And that is with use_https=true? BTW, there's another fix: rC0349c2d84661.

Now the error is away. Thank you!

Ok, try this change: rCd0539d6f029d.

I don't see how $_SERVER['SERVER_PORT'] == 80 would make it appended to the url. The if statement requires it to be different than $port and than 80. Maybe we should use intval($_SERVER['SERVER_PORT']).

I've written out $_SERVER['SERVER_PORT'] ... it's port 80. I assume that rcube_utils::https_check() returns true, so $schema is "https", this leads to $port = 443 and to a true, when evaluating the new if-block. So the port is appended to the hostname.

I've done just copy & paste. The code of the resulting function is ...

Maybe you just applied the patch incorrectly. Note the dot character in this line:

$url .= ':' . $_SERVER['SERVER_PORT'];

Forget my last comment. There's no such thing like $_SERVER['HTTP_PORT'].

Hmm... I'm just thinking. Maybe in your env you don't have $_SERVER['SERVER_PORT'] set either. Then try replacing this with $_SERVER['HTTP_PORT'].

What if you replace $_SERVER['SERVER_NAME'] with $_SERVER['HTTP_HOST']?

Thank you for the fix, but it doesn't seem to work :-/

Hope rCd886aeac2aec fixes that.

Setting use_https to true does has not the desired effect. The created URL now contains the scheme "https", but it still uses port 80. Other parts of the application now complain about errors like this one:

Fixed. You now would need to set use_https to true or file_api_uri to full chwala api path.

The fix is in roundcubemail-plugins-kolab repo.