I found one problem with this approach. The handlers registered by these traits are executed before observer's event handlers. I.e. we generate uuid before we do 'creating' pre-checks. For example EntitlementObserver. I think it makes sense to keep pre-checks in the observer, and do "simple" stuff via traits, but the order should be reversed so observers run first. Well, at least for these cases at hand it would be a proper way.

In D2815#33931, @mollekopf wrote:

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

• Remove redundant ->limit(1)

• Move greylisting setting back to user_settings, cleanup

• Merge branch 'master' into dev/status-degraded
• Add some French localization

• Performance optimizations

• Small perf. improvement, skip redundant query

I think I would prefer UuidIntKeyTrait and UuidStrKeyTrait. Other than that it looks good.

We also have three models that use uuidInt. So, another trait?

If it works, I like it. We should apply it to other models too. I'm not sure about the name, maybe UuidKeyTrait would be better?

How about a test? And I guess @vanmeeuwen might have an opinion that it will be better to keep it for development only, i.e. app/Console/Development/.

Green light from me.

• Small fixes

• Localize "/month"

Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.

• Remove jQuery for realz

One last issue. Other than that it looks good. I didn't test the docker part, I guess we'll need some intergration tests later.

I miss tests for console commands. I get they are simple and CLI has the worse coverage, but still it shouldn't be that hard.

Minor comments just after the code review, no testing and closer look on it yet.

• Support multi-currency in income calculation for stats

I'm planning on updating this diff with a fix for stats (where the income chart should sum up eur and chf payments using conversion rates and present the results in chf).

• More tests

• Add tests, fix small bugs
• Use wallet currency in bonus/penalty dialog

• Remove unintentionally recovered app/Console/Development/UserStatus.php
• Cleanup

• Merge branch 'master' into dev/status-degraded
• Fix regressions regarding tenants
• Fix more regressions
• Small cleanup

• "Move" pgp.enable to per-tenant settings

• Fix a test breaking other tests

• Merge branch 'master' into dev/encryption

I think this is all right. Note that anything that uses setUpTest() is very slow. I'd prefer if we didn't use this method at all, or at least not in setUp() method on a file with many tests.

• Switch new keypair algorithms to RSA
• Use Laravel's Storage functionality
• Add exportPublicKey() use
• Generate a keypair for new alias
• Unregister keys on alias delete
• Add forgotten file
• Fix issues found by phpstan

• Remove redundant generatePassphrase()
• Fix migration
• Fix regression
• Fix various bugs found by phpstan and test regressions

• Fix withObjectTenantContext macro
  • It's result should not depend on the current user role
  • It was throwing exceptions when working with an unauth user (e.g. /meet endpoints)
  • Fixed some tests