Page MenuHomePhorge

Wallet balance checks/notifications/actions
ClosedPublic

Authored by machniak on Sep 16 2020, 3:12 PM.
Tags
None
Referenced Files
F11593533: D1558.id4183.diff
Fri, Mar 29, 7:17 AM
Unknown Object (File)
Tue, Mar 12, 5:21 PM
Unknown Object (File)
Feb 26 2024, 9:02 AM
Unknown Object (File)
Feb 22 2024, 5:23 AM
Unknown Object (File)
Feb 10 2024, 4:52 AM
Unknown Object (File)
Jan 30 2024, 7:02 PM
Unknown Object (File)
Jan 19 2024, 1:55 AM
Unknown Object (File)
Jan 17 2024, 10:54 PM
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKc7aa3fdf4590: Wallet balance checks/notifications/actions
Summary

Work in progress

Diff Detail

Repository
rK kolab
Branch
dev/negative-balance
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30760
Build 11431: arc lint + arc unit

Event Timeline

machniak created this revision.
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
src/app/Console/Commands/WalletCharge.php
44

Should we also say, something like "where number of entitlements > 0"?

Because the thing is, everyone gets a wallet, but at least currently, most users have no entitlements charged to their wallets.

src/app/Jobs/WalletCheck.php
58

For consistency, should we use balance_negative_since?

73

"comming" -> "upcoming"

This revision now requires changes to proceed.Sep 16 2020, 4:28 PM
machniak added inline comments.
src/app/Console/Commands/WalletCharge.php
44

We could, but it would not give us much improvement. I'd not do this.

And I wouldn't be so sure that it's most users.

src/app/Jobs/WalletCheck.php
58

Sure.

175

@vanmeeuwen what do you think about storing entries like these in transactions table? I mean we'd have "for free" a wallet history including sent mail notifications. Of course, it would appear in UI for admins only.

src/app/Console/Commands/WalletCharge.php
44

For the sake of memory consumption then, does it make sense to, instead of ->get(), do an ->each() over a closure?

src/app/Jobs/WalletCheck.php
175

I would suppose this could get in as a future development, such that it would more generically be a log of "what happened". In this case, we can use system logs and possibly even nginx imap/smtp proxy requests, as well as actions such as these and the actions of users, in a more complete timeline.

  • Small fixes
  • Add job:walletcheck command
  • Add templates for negative balance emails
  • Negative balance mail improvements
  • Code improvements
  • Add tests for negative balance mails
  • Wallet check tests
  • Fix automatic unsuspending, add test for this case
  • Add wallet:charge tests and possibility to run it for a specified wallet only
  • Fix migration case so first run of WalletCheck will sent notifications for negative-balance wallets
This revision is now accepted and ready to land.Sep 18 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.