Work in progress
Details
- Reviewers
vanmeeuwen - Group Reviewers
Restricted Project - Commits
- rKc7aa3fdf4590: Wallet balance checks/notifications/actions
Diff Detail
- Repository
- rK kolab
- Branch
- dev/negative-balance
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 30733 Build 11404: arc lint + arc unit
Event Timeline
src/app/Console/Commands/WalletCharge.php | ||
---|---|---|
43 | Should we also say, something like "where number of entitlements > 0"? Because the thing is, everyone gets a wallet, but at least currently, most users have no entitlements charged to their wallets. | |
src/app/Jobs/WalletCheck.php | ||
58 | For consistency, should we use balance_negative_since? | |
73 | "comming" -> "upcoming" |
src/app/Console/Commands/WalletCharge.php | ||
---|---|---|
43 | We could, but it would not give us much improvement. I'd not do this. And I wouldn't be so sure that it's most users. | |
src/app/Jobs/WalletCheck.php | ||
58 | Sure. | |
175 | @vanmeeuwen what do you think about storing entries like these in transactions table? I mean we'd have "for free" a wallet history including sent mail notifications. Of course, it would appear in UI for admins only. |
src/app/Console/Commands/WalletCharge.php | ||
---|---|---|
43 | For the sake of memory consumption then, does it make sense to, instead of ->get(), do an ->each() over a closure? | |
src/app/Jobs/WalletCheck.php | ||
175 | I would suppose this could get in as a future development, such that it would more generically be a log of "what happened". In this case, we can use system logs and possibly even nginx imap/smtp proxy requests, as well as actions such as these and the actions of users, in a more complete timeline. |
- Small fixes
- Add job:walletcheck command
- Add templates for negative balance emails
- Negative balance mail improvements
- Code improvements
- Add tests for negative balance mails
- Wallet check tests
- Fix migration case so first run of WalletCheck will sent notifications for negative-balance wallets