Page MenuHomePhorge
Differential D1558

Wallet balance checks/notifications/actions
ClosedPublic
Actions

Authored by machniak on Sep 16 2020, 3:12 PM.
Tags
None
Referenced Files
F11803419: D1558.id.diff
Fri, Apr 19, 6:03 AM
F11796942: D1558.id4171.diff
Thu, Apr 18, 9:45 PM
F11786940: D1558.diff
Thu, Apr 18, 3:07 PM
Unknown Object (File)
Tue, Apr 16, 9:52 PM
Unknown Object (File)
Sat, Apr 13, 1:41 PM
Unknown Object (File)
Fri, Apr 5, 5:02 AM
Unknown Object (File)
Wed, Apr 3, 11:05 PM
Unknown Object (File)
Wed, Apr 3, 10:34 AM
View All 40 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKc7aa3fdf4590: Wallet balance checks/notifications/actions
Summary

Work in progress

Diff Detail

Repository
rK kolab
Branch
dev/negative-balance
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30760
Build 11431: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 16 2020, 3:12 PM
machniak created this revision.
Harbormaster completed remote builds in B30709: Diff 4129.Sep 16 2020, 3:12 PM
vanmeeuwen requested changes to this revision.Sep 16 2020, 4:28 PM
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
src/app/Console/Commands/WalletCharge.php
44

Should we also say, something like "where number of entitlements > 0"?

Because the thing is, everyone gets a wallet, but at least currently, most users have no entitlements charged to their wallets.

src/app/Jobs/WalletCheck.php
58

For consistency, should we use balance_negative_since?

73

"comming" -> "upcoming"

This revision now requires changes to proceed.Sep 16 2020, 4:28 PM
machniak planned changes to this revision.Sep 16 2020, 6:39 PM
machniak added inline comments.
src/app/Console/Commands/WalletCharge.php
44

We could, but it would not give us much improvement. I'd not do this.

And I wouldn't be so sure that it's most users.

src/app/Jobs/WalletCheck.php
58

Sure.

175

@vanmeeuwen what do you think about storing entries like these in transactions table? I mean we'd have "for free" a wallet history including sent mail notifications. Of course, it would appear in UI for admins only.

vanmeeuwen added inline comments.Sep 17 2020, 8:42 AM
src/app/Console/Commands/WalletCharge.php
44

For the sake of memory consumption then, does it make sense to, instead of ->get(), do an ->each() over a closure?

src/app/Jobs/WalletCheck.php
175

I would suppose this could get in as a future development, such that it would more generically be a log of "what happened". In this case, we can use system logs and possibly even nginx imap/smtp proxy requests, as well as actions such as these and the actions of users, in a more complete timeline.

machniak updated this revision to Diff 4147.Sep 17 2020, 2:12 PM
  • Small fixes
  • Add job:walletcheck command
  • Add templates for negative balance emails
  • Negative balance mail improvements
  • Code improvements
  • Add tests for negative balance mails
  • Wallet check tests
Harbormaster completed remote builds in B30733: Diff 4147.Sep 17 2020, 2:13 PM
machniak updated this revision to Diff 4153.Sep 17 2020, 2:58 PM
  • Add more tests
Harbormaster completed remote builds in B30739: Diff 4153.Sep 17 2020, 2:58 PM
machniak updated this revision to Diff 4159.Sep 17 2020, 3:41 PM
  • Fix automatic unsuspending, add test for this case
Harbormaster completed remote builds in B30745: Diff 4159.Sep 17 2020, 3:41 PM
machniak updated this revision to Diff 4165.Sep 17 2020, 4:04 PM
  • Fix test cleanup
Harbormaster completed remote builds in B30751: Diff 4165.Sep 17 2020, 4:04 PM
machniak updated this revision to Diff 4171.Sep 17 2020, 7:43 PM
  • Add wallet:charge tests and possibility to run it for a specified wallet only
Harbormaster completed remote builds in B30757: Diff 4171.Sep 17 2020, 7:43 PM
machniak updated this revision to Diff 4177.Sep 17 2020, 8:11 PM
  • Fix migration case so first run of WalletCheck will sent notifications for negative-balance wallets
Harbormaster completed remote builds in B30760: Diff 4177.Sep 17 2020, 8:11 PM
vanmeeuwen accepted this revision.Sep 18 2020, 10:23 AM
This revision is now accepted and ready to land.Sep 18 2020, 10:23 AM
Closed by commit rKc7aa3fdf4590: Wallet balance checks/notifications/actions (authored by machniak, committed by vanmeeuwen). · Explain WhySep 18 2020, 11:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
1 line
src/
app/
Console/
Commands/
Job/
40 lines
24 lines
Jobs/
17 lines
278 lines
Mail/
28 lines
23 lines
33 lines
NegativeBalanceReminder.php
NegativeBalance.php
33 lines
NegativeBalanceSuspended.php
NegativeBalance.php
33 lines
Observers/
40 lines
18 lines
resources/
lang/
en/
25 lines
views/
emails/
html/
21 lines
22 lines
22 lines
plain/
17 lines
19 lines
19 lines
tests/
Feature/
Console/
105 lines
6 lines
6 lines
7 lines
Jobs/
3 lines
6 lines
245 lines
27 lines
Unit/
Mail/
84 lines
23 lines
NegativeBalanceReminderTest.php
NegativeBalanceTest.php
21 lines
NegativeBalanceSuspendedTest.php
NegativeBalanceTest.php
23 lines
10 lines

Diff 4177

View Options

bin/phpunit

Loading...
View Options

src/app/Console/Commands/Job/WalletCheck.php

Loading...
View Options

src/app/Console/Commands/WalletCharge.php

Loading...
View Options

src/app/Jobs/UserVerify.php

Loading...
View Options

src/app/Jobs/WalletCheck.php

Loading...
View Options

src/app/Mail/Helper.php

Loading...
View Options

src/app/Mail/NegativeBalance.php

Loading...
View Options

src/app/Mail/NegativeBalanceBeforeDelete.php

Loading...
View Options

src/app/Mail/NegativeBalanceReminder.php

Loading...
View Options

src/app/Mail/NegativeBalanceSuspended.php

Loading...
View Options

src/app/Observers/WalletObserver.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/resources/lang/en/mail.php

Loading...
View Options

src/resources/views/emails/html/negative_balance_before_delete.blade.php

Loading...
View Options

src/resources/views/emails/html/negative_balance_reminder.blade.php

Loading...
View Options

src/resources/views/emails/html/negative_balance_suspended.blade.php

Loading...
View Options

src/resources/views/emails/plain/negative_balance_before_delete.blade.php

Loading...
View Options

src/resources/views/emails/plain/negative_balance_reminder.blade.php

Loading...
View Options

src/resources/views/emails/plain/negative_balance_suspended.blade.php

Loading...
View Options

src/tests/Feature/Console/WalletChargeTest.php

Loading...
View Options

src/tests/Feature/DomainOwnerTest.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/EntitlementTest.php

Loading...
View Options

src/tests/Feature/Jobs/UserUpdateTest.php

Loading...
View Options

src/tests/Feature/Jobs/UserVerifyTest.php

Loading...
View Options

src/tests/Feature/Jobs/WalletCheckTest.php

Loading...
View Options

src/tests/Feature/WalletTest.php

Loading...
View Options

src/tests/Unit/Mail/HelperTest.php

Loading...
View Options

src/tests/Unit/Mail/NegativeBalanceBeforeDeleteTest.php

Loading...
View Options

src/tests/Unit/Mail/NegativeBalanceReminderTest.php

Loading...
View Options

src/tests/Unit/Mail/NegativeBalanceSuspendedTest.php

Loading...
View Options

src/tests/Unit/Mail/NegativeBalanceTest.php

Loading...