Paths

Table of Contentst

Differential D3626

[Python 3] wallace - modules change / relative imports
ClosedPublic
Actions

Authored by ghane on Jun 14 2022, 4:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 10, 7:51 PM

	Unknown Object (File)
	Mon, Dec 9, 2:32 PM

	Unknown Object (File)
	Fri, Dec 6, 6:13 PM

	Unknown Object (File)
	Fri, Dec 6, 1:07 PM

	Unknown Object (File)
	Fri, Dec 6, 4:21 AM

	Unknown Object (File)
	Sat, Nov 30, 11:33 PM

	Unknown Object (File)
	Sat, Nov 30, 6:46 AM

	Unknown Object (File)
	Sat, Nov 16, 10:48 AM

Subscribers

Details

Reviewers

Group Reviewers

PyKolab Developers

Commits

rP015ece8de436: [Python 3] wallace - modules change / relative imports

Summary

some modules changed
and there are also some relative imports fixes (dynamic imports)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ghane requested review of this revision.Jun 14 2022, 4:57 PM

ghane created this revision.

ghane added a child revision: D3632: [Python 3] test-wallace changed modules.Jun 14 2022, 7:43 PM

sicherha requested changes to this revision.Jun 15 2022, 11:46 PM

sicherha subscribed.

sicherha added inline comments.

wallace/module_gpgencrypt.py
32	`email.mime.base.MIMEBase` and `email.mime.text.MIMEText` are both available in Python 2.7 - we can drop the `try` and consistently use the new module names.

This revision now requires changes to proceed.Jun 15 2022, 11:46 PM

dropped old imports in try..except lesser than 2.7
try...except removed

sicherha accepted this revision.Jun 16 2022, 11:33 PM

This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM

Turns out the changes in wallace/__init__.py and wallace/modules.py have already landed on master - see commits 63532e93 and c2b69efb. Could you drop them from this diff and keep only the changes to wallace/module_gpgencrypt.py?

This revision now requires changes to proceed.Jun 16 2022, 11:46 PM

removed comitted code

sicherha accepted this revision.Jun 17 2022, 10:06 PM

This revision is now accepted and ready to land.Jun 17 2022, 10:06 PM

Closed by commit rP015ece8de436: [Python 3] wallace - modules change / relative imports (authored by sicherha). · Explain WhyJun 17 2022, 10:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

wallace/

module_gpgencrypt.py

4 lines

Diff 10463

wallace/module_gpgencrypt.py

Loading...