Page MenuHomePhorge

[Python 3] wallace - modules change / relative imports
ClosedPublic

Authored by ghane on Jun 14 2022, 4:57 PM.
Tags
None
Referenced Files
F13755693: D3626.diff
Fri, Jul 12, 3:15 AM
Unknown Object (File)
Sun, Jun 23, 1:35 AM
Unknown Object (File)
Fri, Jun 21, 8:46 AM
Unknown Object (File)
Thu, Jun 20, 1:30 PM
Unknown Object (File)
Sun, Jun 16, 9:07 AM
Unknown Object (File)
Thu, Jun 13, 4:19 AM
Unknown Object (File)
Wed, Jun 12, 6:17 PM
Unknown Object (File)
Jun 10 2024, 2:15 PM
Subscribers

Details

Summary

some modules changed
and there are also some relative imports fixes (dynamic imports)

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Jun 14 2022, 4:57 PM
ghane created this revision.
sicherha subscribed.
sicherha added inline comments.
wallace/module_gpgencrypt.py
32

email.mime.base.MIMEBase and email.mime.text.MIMEText are both available in Python 2.7 - we can drop the try and consistently use the new module names.

This revision now requires changes to proceed.Jun 15 2022, 11:46 PM
ghane marked an inline comment as done.

dropped old imports in try..except lesser than 2.7
try...except removed

This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM

Turns out the changes in wallace/__init__.py and wallace/modules.py have already landed on master - see commits 63532e93 and c2b69efb. Could you drop them from this diff and keep only the changes to wallace/module_gpgencrypt.py?

This revision now requires changes to proceed.Jun 16 2022, 11:46 PM
This revision is now accepted and ready to land.Jun 17 2022, 10:06 PM
This revision was automatically updated to reflect the committed changes.