Page MenuHomePhorge
Differential D3632

[Python 3] test-wallace changed modules
ClosedPublic
Actions

Authored by ghane on Jun 14 2022, 7:43 PM.

Details

Reviewers
sicherha
Group Reviewers
PyKolab Developers
Commits
rP727d3ae9fc3f: [Python 3] test-wallace changed modules
Summary

modulenames or their structure changed

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ghane requested review of this revision.Jun 14 2022, 7:43 PM
ghane created this revision.
ghane added a parent revision: D3626: [Python 3] wallace - modules change / relative imports.
sicherha requested changes to this revision.Jun 15 2022, 11:52 PM
sicherha subscribed.
sicherha added inline comments.
test-wallace.py
35–39

All these modules are available in Python 2.7. Drop the try-block and use only the imports from the except-block.

Also, I think Encoders isn't used anywhere in this file, so we can probably drop that line.

This revision now requires changes to proceed.Jun 15 2022, 11:52 PM
ghane updated this revision to Diff 10430.Jun 16 2022, 12:34 PM
ghane marked an inline comment as done.

try...except
and old or unused imports
removed as explained

sicherha accepted this revision.Jun 16 2022, 11:33 PM
This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM
Closed by commit rP727d3ae9fc3f: [Python 3] test-wallace changed modules. · Explain WhyJun 16 2022, 11:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
9 lines

Diff 10439

View Options

test-wallace.py

Loading...