Page MenuHomePhorge

[Python 3] test-wallace changed modules
ClosedPublic

Authored by ghane on Jun 14 2022, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 26, 3:06 AM
Unknown Object (File)
Fri, May 24, 2:42 PM
Unknown Object (File)
Fri, May 24, 1:38 AM
Unknown Object (File)
Thu, May 23, 2:01 PM
Unknown Object (File)
Fri, May 17, 8:11 AM
Unknown Object (File)
Fri, May 17, 3:18 AM
Unknown Object (File)
Thu, May 16, 5:30 AM
Unknown Object (File)
Tue, May 7, 7:21 AM
Subscribers

Details

Summary

modulenames or their structure changed

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ghane requested review of this revision.Jun 14 2022, 7:43 PM
ghane created this revision.
sicherha subscribed.
sicherha added inline comments.
test-wallace.py
35–39

All these modules are available in Python 2.7. Drop the try-block and use only the imports from the except-block.

Also, I think Encoders isn't used anywhere in this file, so we can probably drop that line.

This revision now requires changes to proceed.Jun 15 2022, 11:52 PM
ghane marked an inline comment as done.

try...except
and old or unused imports
removed as explained

This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM
This revision was automatically updated to reflect the committed changes.