Page MenuHomekolab.org

[Python 3] test-wallace changed modules
ClosedPublic

Authored by ghane on Tue, Jun 14, 7:43 PM.

Details

Summary

modulenames or their structure changed

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ghane requested review of this revision.Tue, Jun 14, 7:43 PM
ghane created this revision.
sicherha requested changes to this revision.Wed, Jun 15, 11:52 PM
sicherha added a subscriber: sicherha.
sicherha added inline comments.
test-wallace.py
35–39

All these modules are available in Python 2.7. Drop the try-block and use only the imports from the except-block.

Also, I think Encoders isn't used anywhere in this file, so we can probably drop that line.

This revision now requires changes to proceed.Wed, Jun 15, 11:52 PM
ghane updated this revision to Diff 10430.Thu, Jun 16, 12:34 PM
ghane marked an inline comment as done.

try...except
and old or unused imports
removed as explained

sicherha accepted this revision.Thu, Jun 16, 11:33 PM
This revision is now accepted and ready to land.Thu, Jun 16, 11:33 PM
This revision was automatically updated to reflect the committed changes.