Page MenuHomekolab.org

[Python 3] wallace - modules change / relative imports
ClosedPublic

Authored by ghane on Tue, Jun 14, 4:57 PM.

Details

Summary

some modules changed
and there are also some relative imports fixes (dynamic imports)

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ghane requested review of this revision.Tue, Jun 14, 4:57 PM
ghane created this revision.
sicherha requested changes to this revision.Wed, Jun 15, 11:46 PM
sicherha added a subscriber: sicherha.
sicherha added inline comments.
wallace/module_gpgencrypt.py
32

email.mime.base.MIMEBase and email.mime.text.MIMEText are both available in Python 2.7 - we can drop the try and consistently use the new module names.

This revision now requires changes to proceed.Wed, Jun 15, 11:46 PM
ghane updated this revision to Diff 10433.Thu, Jun 16, 12:39 PM
ghane marked an inline comment as done.

dropped old imports in try..except lesser than 2.7
try...except removed

sicherha accepted this revision.Thu, Jun 16, 11:33 PM
This revision is now accepted and ready to land.Thu, Jun 16, 11:33 PM
sicherha requested changes to this revision.Thu, Jun 16, 11:46 PM

Turns out the changes in wallace/__init__.py and wallace/modules.py have already landed on master - see commits 63532e93 and c2b69efb. Could you drop them from this diff and keep only the changes to wallace/module_gpgencrypt.py?

This revision now requires changes to proceed.Thu, Jun 16, 11:46 PM
ghane updated this revision to Diff 10445.Fri, Jun 17, 10:12 AM

removed comitted code

sicherha accepted this revision.Fri, Jun 17, 10:06 PM
This revision is now accepted and ready to land.Fri, Jun 17, 10:06 PM
This revision was automatically updated to reflect the committed changes.